[Android] Abstract ExternalNavHandler dependence on InstantAppsHandler
ExternalNavigationHandler has a dependence on InstantAppsHandler for //chrome-level functionality of interaction with instant apps. This CL abstracts that dependence through ExternalNavigationDelegate.java to aid in componentization of ExternalNavigationHandler for sharing with WebLayer. The functionality exercised by the existing tests is now split between ExternalNavigationHandlerTest.java (testing functionality independent of the delegate impl) and ExternalNavigationDelegateImplTest.java (testing the production functionality now contained in the delegate impl). Note that there is a longer-term issue of to what extent we will incorporate //chrome's instantapps code in WebLayer. That is a larger issue than just the functionality covered in this CL (e.g., the existing maybeLaunchInstantApp() method of ExternalNavigationDelegate.java). We are examining that issue separately. Bug: 1031465 Change-Id: Ie22ee0083217dba65622eb1f4274a5e587b0c8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085211Reviewed-by:Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#748157}
Showing
Please register or sign in to comment