[WebTransport] Turn some methods into attributes and rename them

https://github.com/WICG/web-transport/pull/135

Bug: 1011392
Change-Id: Ifd765d9986a3e3cb47358cd5c1c5572445a408d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435025Reviewed-by: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811567}

content/browser/loader/quic_transport_browsertest.cc

@@ -188,8 +188,8 @@ IN_PROC_BROWSER_TEST_F(QuicTransportBrowserTest, EchoViaWebTransport) {
     async function run() {
       const transport = new WebTransport('quic-transport://localhost:%d/echo');
 
-      const writer = transport.sendDatagrams().getWriter();
-      const reader = transport.receiveDatagrams().getReader();
+      const writer = transport.writableDatagrams.getWriter();
+      const reader = transport.readableDatagrams.getReader();
 
       const data = new Uint8Array([65, 66, 67]);
       const id = setInterval(() => {

third_party/blink/renderer/modules/webtransport/web_transport.h

@@ -33,22 +33,26 @@ class MODULES_EXPORT WebTransport final
   ~WebTransport() override;
 
   // WebTransport IDL implementation.
-  ScriptPromise createSendStream(ScriptState* script_state,
-                                 ExceptionState& exception_state) {
+  ScriptPromise createUnidirectionalStream(ScriptState* script_state,
+                                           ExceptionState& exception_state) {
     return quic_transport_->createSendStream(script_state, exception_state);
   }
-  ReadableStream* receiveStreams() { return quic_transport_->receiveStreams(); }
+  ReadableStream* incomingUnidirectionalStreams() {
+    return quic_transport_->receiveStreams();
+  }
 
   ScriptPromise createBidirectionalStream(ScriptState* script_state,
                                           ExceptionState& exception_state) {
     return quic_transport_->createBidirectionalStream(script_state,
                                                       exception_state);
   }
-  ReadableStream* receiveBidirectionalStreams() {
+  ReadableStream* incomingBidirectionalStreams() {
     return quic_transport_->receiveBidirectionalStreams();
   }
-  WritableStream* sendDatagrams() { return quic_transport_->sendDatagrams(); }
-  ReadableStream* receiveDatagrams() {
+  WritableStream* writableDatagrams() {
+    return quic_transport_->sendDatagrams();
+  }
+  ReadableStream* readableDatagrams() {
     return quic_transport_->receiveDatagrams();
   }
   void close(const WebTransportCloseInfo* close_info) {

third_party/blink/renderer/modules/webtransport/web_transport.idl

@@ -10,17 +10,15 @@
 ] interface WebTransport {
   [CallWith=ScriptState, RaisesException, MeasureAs=WebTransport] constructor(USVString url, optional QuicTransportOptions options = {});
   [CallWith=ScriptState, RaisesException] Promise<SendStream>
-      createSendStream();
-  // TODO(ricea): This should probably be changed to an attribute in the
-  // standard.
-  ReadableStream receiveStreams();
+      createUnidirectionalStream();
+  readonly attribute ReadableStream incomingUnidirectionalStreams;
 
   [CallWith=ScriptState, RaisesException] Promise<BidirectionalStream>
       createBidirectionalStream();
-  ReadableStream receiveBidirectionalStreams();
+  readonly attribute ReadableStream incomingBidirectionalStreams;
 
-  WritableStream sendDatagrams();
-  ReadableStream receiveDatagrams();
+  readonly attribute WritableStream writableDatagrams;
+  readonly attribute ReadableStream readableDatagrams;
 
   void close(optional WebTransportCloseInfo closeInfo = {});
   readonly attribute Promise<void> ready;

third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

@@ -3804,15 +3804,15 @@ interface WebSocketStream
 interface WebTransport
     attribute @@toStringTag
     getter closed
+    getter incomingBidirectionalStreams
+    getter incomingUnidirectionalStreams
+    getter readableDatagrams
     getter ready
+    getter writableDatagrams
     method close
     method constructor
     method createBidirectionalStream
-    method createSendStream
-    method receiveBidirectionalStreams
-    method receiveDatagrams
-    method receiveStreams
-    method sendDatagrams
+    method createUnidirectionalStream
 interface WindowClient : Client
     attribute @@toStringTag
     getter focused

third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt

@@ -3900,15 +3900,15 @@ Starting worker: resources/global-interface-listing-worker.js
 [Worker] interface WebTransport
 [Worker]     attribute @@toStringTag
 [Worker]     getter closed
+[Worker]     getter incomingBidirectionalStreams
+[Worker]     getter incomingUnidirectionalStreams
+[Worker]     getter readableDatagrams
 [Worker]     getter ready
+[Worker]     getter writableDatagrams
 [Worker]     method close
 [Worker]     method constructor
 [Worker]     method createBidirectionalStream
-[Worker]     method createSendStream
-[Worker]     method receiveBidirectionalStreams
-[Worker]     method receiveDatagrams
-[Worker]     method receiveStreams
-[Worker]     method sendDatagrams
+[Worker]     method createUnidirectionalStream
 [Worker] interface Worker : EventTarget
 [Worker]     attribute @@toStringTag
 [Worker]     getter onerror

third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

@@ -11209,15 +11209,15 @@ interface WebSocketStream
 interface WebTransport
     attribute @@toStringTag
     getter closed
+    getter incomingBidirectionalStreams
+    getter incomingUnidirectionalStreams
+    getter readableDatagrams
     getter ready
+    getter writableDatagrams
     method close
     method constructor
     method createBidirectionalStream
-    method createSendStream
-    method receiveBidirectionalStreams
-    method receiveDatagrams
-    method receiveStreams
-    method sendDatagrams
+    method createUnidirectionalStream
 interface WheelEvent : MouseEvent
     attribute @@toStringTag
     attribute DOM_DELTA_LINE

third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt

@@ -3681,15 +3681,15 @@ Starting worker: resources/global-interface-listing-worker.js
 [Worker] interface WebTransport
 [Worker]     attribute @@toStringTag
 [Worker]     getter closed
+[Worker]     getter incomingBidirectionalStreams
+[Worker]     getter incomingUnidirectionalStreams
+[Worker]     getter readableDatagrams
 [Worker]     getter ready
+[Worker]     getter writableDatagrams
 [Worker]     method close
 [Worker]     method constructor
 [Worker]     method createBidirectionalStream
-[Worker]     method createSendStream
-[Worker]     method receiveBidirectionalStreams
-[Worker]     method receiveDatagrams
-[Worker]     method receiveStreams
-[Worker]     method sendDatagrams
+[Worker]     method createUnidirectionalStream
 [Worker] interface WorkerGlobalScope : EventTarget
 [Worker]     attribute @@toStringTag
 [Worker]     getter addressSpace