Commit 7a56e05e authored by Gavin Williams's avatar Gavin Williams Committed by Commit Bot

Remove unused printer subtext ARIA labels for CUPS printers

-The subtext variable/location on the CUPS printer page is intended to
 hold supplementary information for printers show on screen, but right
 now it is unused. Therefore, having aria-describedby="printerSubtext"
 gives no further context while unintentionally stopping the tooltip
 from being read by ChromeVox. So I will remove these references now
 then revisit these ARIA labels once we understand what the printer
 subtext will be.

Fixed: 1014145
Change-Id: I481a018a5d7e75f4f8ac28e6c60262fefa9805a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930695Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720637}
parent 15204aaf
......@@ -24,24 +24,21 @@
</div>
<template is="dom-if" if="[[isSavedPrinter_(printerEntry.printerType)]]">
<cr-icon-button class="icon-more-vert" on-click="onOpenActionMenuTap_"
title="$i18n{moreActions}" aria-labelledby="printerName"
aria-describedby="printerSubtext">
title="$i18n{moreActions}" aria-labelledby="printerName">
</cr-icon-button>
</template>
<template is="dom-if"
if="[[isDiscoveredPrinter_(printerEntry.printerType)]]">
<cr-button id="setupPrinterButton"
on-click="onAddDiscoveredPrinterTap_"
aria-label$="[[getSetupButtonAria_()]]"
aria-describedby="printerSubtext">
aria-label$="[[getSetupButtonAria_()]]">
$i18n{setupPrinter}
</cr-button>
</template>
<template is="dom-if"
if="[[isAutomaticPrinter_(printerEntry.printerType)]]">
<cr-button id="savePrinterButton" on-click="onAddAutomaticPrinterTap_"
aria-label$="[[getSaveButtonAria_()]]"
aria-describedby="printerSubtext">
aria-label$="[[getSaveButtonAria_()]]">
$i18n{savePrinter}
</cr-button>
</template>
......
......@@ -15,7 +15,7 @@ Polymer({
/**
* TODO(jimmyxgong): Determine how subtext should be set and what
* information it should have.
* information it should have, including necessary ARIA labeling
* The additional information subtext for a printer.
* @type {string}
*/
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment