Commit 7a75cccc authored by Kenneth Russell's avatar Kenneth Russell Committed by Commit Bot

Restrict Adreno 3xx driver bug workarounds to pre-Android 10.

Some recent devices use this chipset series, including even the
previously-problematic Adreno 330, but apparently with newer graphics
drivers that pass OpenGL ES 3.0 conformance. Have tested successfully
on a Nokia 1.3 (Adreno 308) with the WebGL 2.0.0 conformance suite.

Starting with Android 10, remove the earlier graphics driver bug
workarounds, and enable WebGL 2.0 on these devices.

Bug: 1042214
Change-Id: Ie1290cf42900891357ceae1cef2709db43a87d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443399Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812967}
parent d008dc58
...@@ -60,9 +60,9 @@ ...@@ -60,9 +60,9 @@
{ {
"id": 19, "id": 19,
"comment": "Corresponds to software rendering list #140", "comment": "Corresponds to software rendering list #140",
"description": "Disable depth textures on older Qualcomm GPUs (legacy blocklist entry, original problem unclear)", "description": "Disable depth textures on older Adreno 2xx Qualcomm GPUs (legacy blocklist entry, original problem unclear)",
"cr_bugs": [682075], "cr_bugs": [682075, 1042214],
"gl_renderer": "Adreno \\(TM\\) [23].*", "gl_renderer": "Adreno \\(TM\\) 2.*",
"features": [ "features": [
"disable_depth_texture" "disable_depth_texture"
], ],
...@@ -1884,11 +1884,18 @@ ...@@ -1884,11 +1884,18 @@
"comment": [ "comment": [
"Corresponds to software rendering list #140", "Corresponds to software rendering list #140",
"Mysteriously, the first workaround won't work without the second. crbug.com/698197#c10", "Mysteriously, the first workaround won't work without the second. crbug.com/698197#c10",
"MSAA workaround shouldn't be needed beyond Adreno 3xx. crbug.com/682075#c17" "MSAA workaround shouldn't be needed beyond Adreno 3xx and Android 10. crbug.com/682075#c17, crbug.com/1042214"
], ],
"description": "Some Adreno 3xx don't setup scissor state correctly when FBO0 is bound, nor support MSAA properly.", "description": "Some Adreno 3xx don't setup scissor state correctly when FBO0 is bound, nor support MSAA properly.",
"cr_bugs": [670607, 682075, 696627, 698197, 707839], "cr_bugs": [670607, 682075, 696627, 698197, 707839, 1042214],
"gl_renderer": "Adreno \\(TM\\) 3.*", "gl_renderer": "Adreno \\(TM\\) 3.*",
"os": {
"type": "android",
"version": {
"op": "<",
"value": "10.0"
}
},
"features": [ "features": [
"force_update_scissor_state_when_binding_fbo0", "force_update_scissor_state_when_binding_fbo0",
"disable_chromium_framebuffer_multisample" "disable_chromium_framebuffer_multisample"
...@@ -3639,6 +3646,26 @@ ...@@ -3639,6 +3646,26 @@
"features": [ "features": [
"force_enable_color_buffer_float_except_rgb32f" "force_enable_color_buffer_float_except_rgb32f"
] ]
},
{
"id": 359,
"comment": "Corresponds to software rendering list #140",
"description": "Disable depth textures on Adreno 3xx Qualcomm GPUs pre-Android 10 (legacy blocklist entry, original problem unclear)",
"cr_bugs": [682075, 1042214],
"gl_renderer": "Adreno \\(TM\\) 3.*",
"os": {
"type": "android",
"version": {
"op": "<",
"value": "10.0"
}
},
"features": [
"disable_depth_texture"
],
"disabled_extensions": [
"GL_OES_depth_texture"
]
} }
] ]
} }
...@@ -1247,10 +1247,17 @@ ...@@ -1247,10 +1247,17 @@
}, },
{ {
"id": 140, "id": 140,
"comment": "Corresponds to GPU driver bugs #19, #214", "comment": "Corresponds to GPU driver bugs #19, #214, #359",
"description": "MSAA and depth texture buggy on Adreno 3xx, also disable WebGL2", "description": "MSAA and depth texture buggy on Adreno 3xx prior to Android 10, also disable WebGL2",
"cr_bugs": [449116, 698197], "cr_bugs": [449116, 698197, 1042214],
"gl_renderer": "Adreno \\(TM\\) 3.*", "gl_renderer": "Adreno \\(TM\\) 3.*",
"os": {
"type": "android",
"version": {
"op": "<",
"value": "10.0"
}
},
"features": [ "features": [
"accelerated_webgl2" "accelerated_webgl2"
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment