Commit 7ac5d625 authored by Jesse Schettler's avatar Jesse Schettler Committed by Commit Bot

Reland "arc: Enable print-spooler-experiment feature flag by default"

This reverts commit 3af7932b.

Reason for revert: ARC++ printing can pass CTS

Original change's description:
> Revert "arc: Enable print-spooler-experiment feature flag by default"
>
> This reverts commit c79e6751.
>
> Reason for revert: Fixing CTS for ToT
>
> Original change's description:
> > arc: Enable print-spooler-experiment feature flag by default
> >
> > Also, enable the flag for all channels except stable.
> >
> > Bug: b:130798103
> > Test: android-sh -c getprop | grep ro.boot.arc_print_spooler
> > Change-Id: I4ca45c248737bbc0e5c90ed679bfe2b77ec9ed12
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784006
> > Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
> > Commit-Queue: Jesse Schettler <jschettler@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#693860}
>
> TBR=yusukes@chromium.org,elijahtaylor@chromium.org,jschettler@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: b:130798103
> Change-Id: I400c7050bbf4c82ffba230b1900d14daa309c628
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831273
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Commit-Queue: Jesse Schettler <jschettler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#701184}

TBR=yusukes@chromium.org,elijahtaylor@chromium.org,jschettler@chromium.org

Bug: b:130798103
Change-Id: I378ae1dee61231462f8588bd1303400b47158bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914479Reviewed-by: default avatarJesse Schettler <jschettler@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714973}
parent 3c9f5858
...@@ -66,7 +66,7 @@ const base::Feature kPictureInPictureFeature{"ArcPictureInPicture", ...@@ -66,7 +66,7 @@ const base::Feature kPictureInPictureFeature{"ArcPictureInPicture",
// Controls experimental print spooler feature for ARC. // Controls experimental print spooler feature for ARC.
const base::Feature kPrintSpoolerExperimentFeature{ const base::Feature kPrintSpoolerExperimentFeature{
"ArcPrintSpoolerExperiment", base::FEATURE_DISABLED_BY_DEFAULT}; "ArcPrintSpoolerExperiment", base::FEATURE_ENABLED_BY_DEFAULT};
// Controls Smart Text Selection for Chrome. // Controls Smart Text Selection for Chrome.
// When enabled, the context menu will show contextual quick actions based on // When enabled, the context menu will show contextual quick actions based on
......
...@@ -372,8 +372,7 @@ void ArcSessionImpl::DoStartMiniInstance(size_t num_cores_disabled) { ...@@ -372,8 +372,7 @@ void ArcSessionImpl::DoStartMiniInstance(size_t num_cores_disabled) {
params.arc_custom_tabs_experiment = is_custom_tab_enabled; params.arc_custom_tabs_experiment = is_custom_tab_enabled;
const bool is_arc_print_spooler_enabled = const bool is_arc_print_spooler_enabled =
base::FeatureList::IsEnabled(arc::kPrintSpoolerExperimentFeature) && base::FeatureList::IsEnabled(arc::kPrintSpoolerExperimentFeature) &&
delegate_->GetChannel() != version_info::Channel::STABLE && delegate_->GetChannel() != version_info::Channel::STABLE;
delegate_->GetChannel() != version_info::Channel::BETA;
params.arc_print_spooler_experiment = is_arc_print_spooler_enabled; params.arc_print_spooler_experiment = is_arc_print_spooler_enabled;
params.lcd_density = lcd_density_; params.lcd_density = lcd_density_;
params.num_cores_disabled = num_cores_disabled; params.num_cores_disabled = num_cores_disabled;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment