Skip to content

GitLab

T
tangled
Commit 7aeed1c5 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot
Browse files
Options

::-webkit-textfield-decoration-container should not accept writing-mode changes 

Specifying a 'writing-mode' value different from the host INPUT to its
::-webkit-textfield-decoration-container broke many things, and it was
not helpful because inner-editor always has the 'writing-mode' value
same as the host INPUT.  This CL prohibits authors to specify
'writing-mode' to ::-webkit-textfield-decoration-container.

Bug: 1144088
Change-Id: I6f19f541fbcbd6e4ff4eb074807d764ddce15004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509409Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822586}
parent bc3bfb93
Hide whitespace changes
Inline Side-by-side
Showing with 35 additions and 0 deletions
third_party/blink/renderer/core/html/resources/html.css
View file @ 7aeed1c5
...@@ -442,6 +442,7 @@ input::-webkit-textfield-decoration-container { ...@@ -442,6 +442,7 @@ input::-webkit-textfield-decoration-container {
align-items: center; align-items: center;
-webkit-user-modify: read-only !important; -webkit-user-modify: read-only !important;
content: none !important; content: none !important;
writing-mode: inherit !important;
-internal-align-self-block: center; -internal-align-self-block: center;
} }
......
third_party/blink/web_tests/fast/forms/number/number-broken-by-container-style-expected.html 0 → 100644
View file @ 7aeed1c5
<!DOCTYPE html>
<input type=number placeholder="foo">
<input type=number value="123456">
<script>
document.querySelectorAll('input')[1].focus();
</script>
third_party/blink/web_tests/fast/forms/number/number-broken-by-container-style.html 0 → 100644
View file @ 7aeed1c5
<!DOCTYPE html>
<style>
input::-webkit-textfield-decoration-container {
writing-mode: vertical-rl;
}
</style>
<input type=number placeholder="foo">
<input type=number value="123456">
<script>
document.querySelectorAll('input')[1].focus();
</script>
third_party/blink/web_tests/fast/forms/search/search-broken-by-container-style-expected.html 0 → 100644
View file @ 7aeed1c5
<!DOCTYPE html>
<input type=search placeholder="foo">
<input type=search value="query">
<script>
document.querySelectorAll('input')[1].focus();
</script>
third_party/blink/web_tests/fast/forms/search/search-broken-by-container-style.html 0 → 100644
View file @ 7aeed1c5
<!DOCTYPE html>
<style>
input::-webkit-textfield-decoration-container {
writing-mode: vertical-rl;
}
</style>
<input type=search placeholder="foo">
<input type=search value="query">
<script>
document.querySelectorAll('input')[1].focus();
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment