Commit 7af63ca2 authored by Nohemi Fernandez's avatar Nohemi Fernandez Committed by Chromium LUCI CQ

[iOS] Add experiment feature flag kRestoreGaiaCookiesOnUserAction.

Bug: 1157475
Change-Id: Ifa0d6e112be23a489e2a5cc73b483e52308396d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584028Reviewed-by: default avatarJérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836085}
parent e79b4abb
...@@ -4181,6 +4181,11 @@ ...@@ -4181,6 +4181,11 @@
"owners": [ "fernandex", "chrome-signin-team" ], "owners": [ "fernandex", "chrome-signin-team" ],
"expiry_milestone": 96 "expiry_milestone": 96
}, },
{
"name": "restore-gaia-cookies-on-user-action",
"owners": ["fernandex", "chrome-signin-team" ],
"expiry_milestone": 96
},
{ {
"name": "restrict-gamepad-access", "name": "restrict-gamepad-access",
"owners": [ "//device/gamepad/OWNERS", "jameshollyer@chromium.org" ], "owners": [ "//device/gamepad/OWNERS", "jameshollyer@chromium.org" ],
......
...@@ -16,6 +16,9 @@ bool ForceStartupSigninPromo() { ...@@ -16,6 +16,9 @@ bool ForceStartupSigninPromo() {
const base::Feature kRestoreGaiaCookiesIfDeleted{ const base::Feature kRestoreGaiaCookiesIfDeleted{
"RestoreGAIACookiesIfDeleted", base::FEATURE_DISABLED_BY_DEFAULT}; "RestoreGAIACookiesIfDeleted", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kRestoreGaiaCookiesOnUserAction{
"RestoreGAIACookiesOnUserAction", base::FEATURE_DISABLED_BY_DEFAULT};
const char kDelayThresholdMinutesToUpdateGaiaCookie[] = const char kDelayThresholdMinutesToUpdateGaiaCookie[] =
"minutes-delay-to-restore-gaia-cookies-if-deleted"; "minutes-delay-to-restore-gaia-cookies-if-deleted";
......
...@@ -18,6 +18,10 @@ bool ForceStartupSigninPromo(); ...@@ -18,6 +18,10 @@ bool ForceStartupSigninPromo();
// Feature controlling whether to restore GAIA cookies if they are deleted. // Feature controlling whether to restore GAIA cookies if they are deleted.
extern const base::Feature kRestoreGaiaCookiesIfDeleted; extern const base::Feature kRestoreGaiaCookiesIfDeleted;
// Feature controlling whether to restore GAIA cookies when the user explicitly
// requests to sign in to a Google service.
extern const base::Feature kRestoreGaiaCookiesOnUserAction;
// Name of multi-value switch that controls the delay (in minutes) for polling // Name of multi-value switch that controls the delay (in minutes) for polling
// for the existence of Gaia cookies for google.com. // for the existence of Gaia cookies for google.com.
extern const char kDelayThresholdMinutesToUpdateGaiaCookie[]; extern const char kDelayThresholdMinutesToUpdateGaiaCookie[];
......
...@@ -556,6 +556,11 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -556,6 +556,11 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flag_descriptions::kRestoreGaiaCookiesIfDeletedDescription, flag_descriptions::kRestoreGaiaCookiesIfDeletedDescription,
flags_ui::kOsIos, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(signin::kRestoreGaiaCookiesIfDeleted)}, FEATURE_VALUE_TYPE(signin::kRestoreGaiaCookiesIfDeleted)},
{"restore-gaia-cookies-on-user-action",
flag_descriptions::kRestoreGaiaCookiesOnUserActionName,
flag_descriptions::kRestoreGaiaCookiesOnUserActionDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(signin::kRestoreGaiaCookiesOnUserAction)},
{"use-username-for-signin-notification-infobar-title", {"use-username-for-signin-notification-infobar-title",
flag_descriptions::kSigninNotificationInfobarUsernameInTitleName, flag_descriptions::kSigninNotificationInfobarUsernameInTitleName,
flag_descriptions::kSigninNotificationInfobarUsernameInTitleDescription, flag_descriptions::kSigninNotificationInfobarUsernameInTitleDescription,
......
...@@ -351,6 +351,12 @@ const char kRestoreGaiaCookiesIfDeletedDescription[] = ...@@ -351,6 +351,12 @@ const char kRestoreGaiaCookiesIfDeletedDescription[] =
"When enabled, will restore GAIA cookies for signed-in Chrome users if " "When enabled, will restore GAIA cookies for signed-in Chrome users if "
"they are deleted."; "they are deleted.";
const char kRestoreGaiaCookiesOnUserActionName[] =
"Restore GAIA cookies on user action";
const char kRestoreGaiaCookiesOnUserActionDescription[] =
"When enabled, will restore GAIA cookies for signed-in Chrome users if "
"the user explicitly requests a Google service.";
const char kSafeBrowsingAvailableName[] = "Make Safe Browsing available"; const char kSafeBrowsingAvailableName[] = "Make Safe Browsing available";
const char kSafeBrowsingAvailableDescription[] = const char kSafeBrowsingAvailableDescription[] =
"When enabled, navigation URLs are compared to Safe Browsing blocklists, " "When enabled, navigation URLs are compared to Safe Browsing blocklists, "
......
...@@ -409,9 +409,16 @@ extern const char kWebPageAlternativeTextZoomDescription[]; ...@@ -409,9 +409,16 @@ extern const char kWebPageAlternativeTextZoomDescription[];
extern const char kWebViewNativeContextMenuName[]; extern const char kWebViewNativeContextMenuName[];
extern const char kWebViewNativeContextMenuDescription[]; extern const char kWebViewNativeContextMenuDescription[];
// Title and description for the flag to restore Gaia cookies as soon as Chrome
// detects that they have been removed.
extern const char kRestoreGaiaCookiesIfDeletedName[]; extern const char kRestoreGaiaCookiesIfDeletedName[];
extern const char kRestoreGaiaCookiesIfDeletedDescription[]; extern const char kRestoreGaiaCookiesIfDeletedDescription[];
// Title and description for the flag to restore Gaia cookies when the user
// explicitly requests to be signed in to a Google service.
extern const char kRestoreGaiaCookiesOnUserActionName[];
extern const char kRestoreGaiaCookiesOnUserActionDescription[];
extern const char kRecordSnapshotSizeName[]; extern const char kRecordSnapshotSizeName[];
extern const char kRecordSnapshotSizeDescription[]; extern const char kRecordSnapshotSizeDescription[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment