Commit 7b06f8f3 authored by Lijin Shen's avatar Lijin Shen Committed by Commit Bot

Limit multi-display test to P+ and fix a typo

- Limit test to P+ as it fails on O for unknown reason.
- Fix the typo in tab persistence policy

Bug: 1081912
Change-Id: I9e8b9203dfac4fb359c9e9b4d337323950dc9324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202508Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#769061}
parent fab3e6b3
...@@ -61,7 +61,7 @@ public class TabbedModeTabPersistencePolicy implements TabPersistencePolicy { ...@@ -61,7 +61,7 @@ public class TabbedModeTabPersistencePolicy implements TabPersistencePolicy {
*/ */
private static final Object CLEAN_UP_TASK_LOCK = new Object(); private static final Object CLEAN_UP_TASK_LOCK = new Object();
/** Tracks whether tabs from two TabPersistentStores tabs are being merged together. */ /** Tracks whether tabs from two TabPersistentStores tabs are being merged together. */
// TODO(crbug.com/2139709): Transit AtomicBoolean to an AtomicInteger to keep track the task id // TODO(crbug.com/1082936): Transit AtomicBoolean to an AtomicInteger to keep track the task id
// of activity being merged. // of activity being merged.
private static final AtomicBoolean MERGE_IN_PROGRESS = new AtomicBoolean(); private static final AtomicBoolean MERGE_IN_PROGRESS = new AtomicBoolean();
......
...@@ -517,7 +517,7 @@ public class TabModelMergingTest { ...@@ -517,7 +517,7 @@ public class TabModelMergingTest {
@Test @Test
@LargeTest @LargeTest
@EnableFeatures(ChromeFeatureList.ANDROID_MULTIPLE_DISPLAY) @EnableFeatures(ChromeFeatureList.ANDROID_MULTIPLE_DISPLAY)
@DisableIf.Build(sdk_is_less_than = VERSION_CODES.O) @DisableIf.Build(sdk_is_less_than = VERSION_CODES.P)
public void testMergeOnMultiDisplay_CTA_Resumed_CTA2_Not_Resumed() throws TimeoutException { public void testMergeOnMultiDisplay_CTA_Resumed_CTA2_Not_Resumed() throws TimeoutException {
TestThreadUtils.runOnUiThreadBlocking(() -> { TestThreadUtils.runOnUiThreadBlocking(() -> {
mActivity1.saveState(); mActivity1.saveState();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment