Roll src/net/third_party/quiche/src/ c41d2fe86..4581908be (16 commits)

https://quiche.googlesource.com/quiche.git/+log/c41d2fe865c9..4581908bee97

$ git log c41d2fe86..4581908be --date=short --no-merges --format='%ad %ae %s'
2020-07-08 vasilvv Make QuicFrame a standard-layout struct.
2020-07-07 renjietang Rename QuicConnection::RetransmitZeroRttPackets() to MarkZeroRttPacketsForRetransmission() because the method doesn't actually retransmit the data.
2020-07-07 fayang Enable gfe2_reloadable_flag_quic_fix_undecryptable_packets and gfe2_reloadable_flag_quic_fix_packet_number_length in //third_party/quic/core/http:end_to_end_test.
2020-07-07 quiche-dev Don’t assume `QuicheStringPiece::const_iterator` is a `const char*`
2020-07-07 dschinazi Deprecate quic_google_transport_param_send_new
2020-07-07 quiche-dev Remove SSL methods from non-SSL base class
2020-07-06 dschinazi Fix packet number length computation
2020-07-06 renjietang Deprecate gfe2_reloadable_flag_quic_do_not_retransmit_immediately_on_zero_rtt_reject
2020-07-06 wub For quic loss detection tuning, add a new reward function using average http latency and run it side by side with the existing reward function. protected by --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe.
2020-07-06 fayang Deprecate gfe2_reloadable_flag_quic_fix_write_pending_crypto_retransmission.
2020-07-06 fayang Deprecate gfe2_reloadable_flag_quic_fix_willing_and_able_to_write.
2020-07-06 fayang Deprecate gfe2_reloadable_flag_quic_move_amplification_limit.
2020-07-06 fayang Deprecate gfe2_reloadable_flag_quic_bundle_crypto_data_with_initial_ack.
2020-07-06 wub Deprecate --gfe2_reloadable_flag_quic_update_ack_alarm_in_send_all_pending_acks.
2020-07-06 haoyuewang Remove max_ack_delay_ in rttstats. this field is unused and should be removed when deprecating quic_sent_packet_manager_cleanup flag, and hence not flag protected.
2020-07-01 dschinazi Prevent infinite loops in QUIC e2e test

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=dschinazi@chromium.org

Change-Id: Ib7aab5e79c77db6abaaca6beb70c0fbfb2424b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287892
Auto-Submit: Bin Wu <wub@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786416}

DEPS

@@ -322,7 +322,7 @@ vars = {
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling feed
   # and whatever else without interference from each other.
-  'quiche_revision': 'c41d2fe865c99b1e01fcaecf697247d126cdf8fd',
+  'quiche_revision': '4581908bee97ea8a068fae818209ae3b0783fd64',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling ios_webkit
   # and whatever else without interference from each other.

net/quic/quic_flags_list.h

@@ -316,47 +316,17 @@ QUIC_FLAG(bool,
           FLAGS_quic_restart_flag_quic_google_transport_param_omit_old,
           false)
 
-// When true, QUIC+TLS will send and parse the new-format Google-specific
-// transport parameters.
-QUIC_FLAG(bool,
-          FLAGS_quic_restart_flag_quic_google_transport_param_send_new,
-          true)
-
-// If true, return from QuicCryptoStream::WritePendingCryptoRetransmission after
-// partial writes.
-QUIC_FLAG(
-    bool,
-    FLAGS_quic_reloadable_flag_quic_fix_write_pending_crypto_retransmission,
-    true)
-
 // If true, QUIC will free writer-allocated packet buffer if writer->WritePacket
 // is not called.
 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_avoid_leak_writer_buffer, false)
 
-// If true, QuicConnection::SendAllPendingAcks will Update instead of Set the
-// ack alarm.
-QUIC_FLAG(
-    bool,
-    FLAGS_quic_reloadable_flag_quic_update_ack_alarm_in_send_all_pending_acks,
-    true)
-
 // If true, the B2HI connection option limits reduction of inflight_hi to
 // (1-Beta)*CWND.
 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr2_limit_inflight_hi, false)
 
-// When true, always check the amplification limit before writing, not just for
-// handshake packets.
-QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_move_amplification_limit, true)
-
 // If true, SendAllPendingAcks always send the earliest ACK.
 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_always_send_earliest_ack, true)
 
-// If true, check connection level flow control for send control stream and
-// qpack streams in QuicSession::WillingAndAbleToWrite.
-QUIC_FLAG(bool,
-          FLAGS_quic_reloadable_flag_quic_fix_willing_and_able_to_write,
-          true)
-
 // If true, disable QUIC version h3-T050.
 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_disable_version_t050, false)
 
@@ -398,18 +368,6 @@ QUIC_FLAG(bool,
 // in the undecryptable packets list.
 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_undecryptable_packets, true)
 
-// If true, QUIC client only tries to retransmit data when 1-RTT key is
-// available.
-QUIC_FLAG(
-    bool,
-    FLAGS_quic_reloadable_flag_quic_do_not_retransmit_immediately_on_zero_rtt_reject,
-    true)
-
-// If true, try to bundle INITIAL data when trying to send INITIAL ACK.
-QUIC_FLAG(bool,
-          FLAGS_quic_reloadable_flag_quic_bundle_crypto_data_with_initial_ack,
-          true)
-
 // If true, do not use QuicUtil::IsBidirectionalStreamId() to determine gQUIC
 // stream type.
 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_gquic_stream_type, true)
@@ -453,3 +411,7 @@ QUIC_FLAG(
     bool,
     FLAGS_quic_reloadable_flag_quic_determine_serialized_packet_fate_early,
     false)
+
+// If true, take the largest acked packet into account when computing the sent
+// packet number length.
+QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_packet_number_length, false)