Commit 7b2b73c5 authored by Olivier Robin's avatar Olivier Robin Committed by Commit Bot

Only log ClearBrowsingData_Cookies for normal Browser

All the other ClearBrowsingData_* metrics are logged
when the user clear them using the clear browsing data
screen.
ClearBrowsingData_Cookies is the only one that is also
log when destroying an incognito browser, leading to
metrics inconsistencies.

Only log ClearBrowsingData_Cookies for normal browser
fix the issue.

Bug: 1132818
Change-Id: I169d474b326fd1d53885524ab584000336768d46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434338Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarMohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811777}
parent 2b37a368
...@@ -295,7 +295,11 @@ void BrowsingDataRemoverImpl::RemoveImpl(base::Time delete_begin, ...@@ -295,7 +295,11 @@ void BrowsingDataRemoverImpl::RemoveImpl(base::Time delete_begin,
web::WebThread::IO, base::TaskShutdownBehavior::BLOCK_SHUTDOWN}; web::WebThread::IO, base::TaskShutdownBehavior::BLOCK_SHUTDOWN};
if (IsRemoveDataMaskSet(mask, BrowsingDataRemoveMask::REMOVE_COOKIES)) { if (IsRemoveDataMaskSet(mask, BrowsingDataRemoveMask::REMOVE_COOKIES)) {
base::RecordAction(base::UserMetricsAction("ClearBrowsingData_Cookies")); if (!browser_state_->IsOffTheRecord()) {
// ClearBrowsingData_Cookies should not be reported when cookies are
// cleared as part of an incognito browser shutdown.
base::RecordAction(base::UserMetricsAction("ClearBrowsingData_Cookies"));
}
net::CookieDeletionInfo::TimeRange deletion_time_range = net::CookieDeletionInfo::TimeRange deletion_time_range =
net::CookieDeletionInfo::TimeRange(delete_begin, delete_end); net::CookieDeletionInfo::TimeRange(delete_begin, delete_end);
base::PostTask( base::PostTask(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment