Roll src/third_party/openh264/src/ 6f26bce0b..a5473711f (98 commits)

https://chromium.googlesource.com/external/github.com/cisco/openh264/+log/6f26bce0b1c4..a5473711f3e2

$ git log 6f26bce0b..a5473711f --date=short --no-merges --format='%ad %ae %s'
2020-04-22 Merge pull request #3272 from mstorsjo/fix-test-refs by huili2
2020-04-22 Merge pull request #3144 from disigma/master by guangwei
2020-04-21 martin Fix test references after pull request #3266
2020-04-10 linjie.fu codec/encoder: loose the reference check
2020-04-10 linjie.fu codec/encoder: fix multi refs encoding support for FFmpeg
2020-03-24 yanqian add v2.1.0 binaries link in releasenote
2020-03-04 guxiwei-hf Using and operation when detecting Loongson mmi instructions
2020-03-03 yanqian update v2.1.0 ReleasNote
2020-02-26 wme-jenkins.gen update version to 2.1.0
2020-02-26 guangwwa fix ut build issue for android
2020-02-19 huili2 fix ubsan failure in UT
2020-02-18 huili2 fix ubsan failure in UT
2020-02-17 martin Fix libdir path in pkg-config files when built with make
2020-02-13 xiaotianshimail2 fix osx thread testcase.
2020-01-28 jisorce meson: fix libdir in openh264.pc.in
2019-10-22 guxiwei-hf Adjust the mmi/msa detection mode for mips platform.
2019-08-24 philn Travis: Update To Xenial and Meson 0.47.
2019-08-13 philn meson: New build option to enable/disable tests
2019-12-11 xiaotianshimail fix oss-fuzz issues 18747 and 18864. Temp disable thread decoder unit_test.
2019-12-11 xiaotianshimail Thread decoding  deblocking update by setting pNzc array for neighboring MBs.
2019-12-02 martin Remove a leftover printf from a test
2019-11-26 xiaotianshimail add thread decoding unit test.
2019-11-25 xiaotianshimail Fix a few more fixes found during creating thread unit tests. 1. set all none-zero pCurDqLayer->pNzc to 1 before a MB deblocking. 2. make ReleaseBufferedReadyPicture to behaviour to be more close between thread and non-thread. 3. Fix a typo "sSliceDecodeFinsh"
2019-11-20 xiaotianshimail Fix a thread buffering bug: a few yuv frames at output can be dropped due to unexpected pDst reset. This is resolved by moving pDst into SBufferInfo data structure.
2019-11-15 xiaotianshimail Fix a few test cases in UT for thread decoding.
2019-11-11 xiaotianshimail Threaded decoding enhancement:
2019-11-07 xiaotianshimail fix issue 3203 - oss-fuzz reported bug 18747 which was not fixed in by the commit for fixing the issue 3197.
2019-11-05 xiaotianshimail fix fuzz issues 18744, 18746 and 18747 by clearing info of buffered video frames when decreasing DPB buffers.
2019-11-03 xiaotianshimail replace magic number 17 with MAX_DPB_COUNT.
2019-11-01 xiaotianshimail fix issue 3193 (fuzz 18644) by adding missing initialization of PPicture's refPic lists
2019-10-18 martin Fix building for android
2019-10-31 xiaotianshimail commit-4 of multi-thread decoding support.
2019-10-30 xiaotianshimail add support for NAL with duplicated MBs in threaded decoding mode.
2019-10-28 xiaotianshimail Mainly update DecodeCurrentAccessUnit and associated functions to do threaded parallel frame decodings.
2019-10-25 xiaotianshimail Fix issue 3186 (fuzz 18458). Reset held picture reordering list before calling DestroyPicBuff.
2019-10-18 martin Fix the build for Windows Phone and Windows Store
2019-10-18 martin Fix building for android
2019-10-16 xiaotianshimail second commit for threaded decoding support: Add function WelsDecodeAndConstructSlice (and add associted functions) which combines decoding->reconstructing->deblocking in single MB loop so that it allows multile frames to decode MBs in parallel.
2019-10-15 xiaotianshimail re-structure SWelsDecoderContext and others and prepare for the support of multi-threading support.
2019-08-29 othko97 meson.build: Bump soname version to 5
2019-07-23 xiaotianshimail re-fix oss-buzz bug 14423.
2019-07-10 guxiwei-hf codec/common: [loongson] Fix unaligned access in BACKUP_REG.
2019-07-04 guxiwei-hf codec/processing: [loongson] Add mmi optimization for m_pfSad.
2019-06-27 yang.yu Fix symbol hiding for x86 asm.
2019-06-13 aiszhang update v2.0.0 libraries download URL
2019-05-09 wme-jenkins.gen update version to 2.0.0
2019-05-07 aiszhang Update RELEASES
2019-04-23 xiaotianshimail Fix oss-fuzz reported bug 14423 which is caused by the fix of 14267 in DecreasePicBuff.
2019-04-21 xiaotianshimail Better way to fix oss-fuzz reported bug 14267 by re-assigning reference's references after memory reallocations in DecreasePicBuff instead of just reset.
2019-04-21 xiaotianshimail Additional fix for oss-fuzz 14267. moving up the removing reference's references
2019-04-19 xiaotianshimail Fix oss-fuzz newly reported bug 14267. reset reference's references after call DecreasePicBuff when new sequence arrives
2019-04-04 xiaotianshimail fix oss-fuzzer reported bug 14060 by resetting decoder in time based on the error conditions.
2019-04-03 xiaotianshimail removed the usage of magic number in the fix of issue 14035.
2019-04-03 xiaotianshimail Fix oss-fuzzer 14035. Reset all B-frame's reference's references when IDR is lost to prevent temporal prediction from trying to access lost references.
2019-03-28 xiaotianshimail Fix oss-fuzz reported bug 13941 Heap-use-after-free in WelsDec::MapColToList0.
2019-03-15 xiaotianshimail Prevent decoded pictures of Scalable Baseline Profile (83) (no b-frame) stream from being buffered for reordering. fix "dec crash for spec bitstream (gop2.h264) cisco#3110".
2019-03-15 xiaotianshimail try to use decoder error conditions to determine how to continue instead of trying to loacate deleted references.
2019-02-27 jan deblocking: Disambiguate reference pictures
2019-03-13 jan Revert "enable bs test in UT"
2019-02-27 jan parse_mb_syn_cavlc: Commenting updates
2019-02-27 jan deblocking: make some functions static
2019-02-27 jan decode_slice: Fix some typos in debug messages
2019-02-27 jan decode_slice: Rename ComputeColocated
2019-03-15 martin Move -fstack-protector-all to platform specific makefiles
2019-03-13 xiaotianshimail fix ossz-buzz 13692. validate source yuv pointers before recontructing MBs
2019-03-12 xiaotianshimail Fix AddressSanitizer: heap-use-after-free at decoder.cpp:178. New GOP start can be missed if GOP does not start with picture POC = 0 or the picture POC failed to decoder. The fix is to detect GOP change more accurately so that previous pictures can be flushed out immediately.
2019-03-03 xiaotianshimail additional fix for ossz-buzz bug 13457.
2019-03-01 xiaotianshimail Fix ossz-buzz reported bug 13457. (Don't try to dereference never existing P referemece->reference.
2019-01-23 guangwwa enable stack protector
2019-02-18 xiaotianshimail Fix ossz-buzz reported bug 13185: make the code to be more readable.
2019-02-18 xiaotianshimail Fix ossz-buzz reported bug 13185 by resetting the references of previously deleted references.
2019-02-13 xiaotianshimail Fix ossz-fuzz reported bug-13001.  the fix has added one error code in codec_app_def.h which handles null ptrs in ref pic lists within refCount.
2019-02-12 xiaotianshimail Fix Issues 13030 and 13039 in oss-fuzz.
2019-02-08 xiaotianshimail Fix Bugzilla reported bug 1526107.
2019-02-08 xiaotianshimail Fix Bugzilla reported bug 1526408.
2019-02-08 xiaotianshimail Refix Bugzilla reported bug-1525097.
2019-02-08 daniel.minor Only check for working compiler in NDK if $(CXX) contains slashes
2019-02-06 xiaotianshimail coding style consistent by adding {}.
2019-02-06 xiaotianshimail Fix Bugzilla reported bug 1522172_2 (second test case) and 1535089.
2019-02-06 xiaotianshimail Refix Bugzilla reported bug 1525361 per huili's comment https://github.com/cisco/openh264/pull/3093
2019-02-05 nirbheek meson: Fix generation of import library on Windows
2019-02-05 xiaotianshimail fix newly Bugzilla reported (Feb. 5) bug 1525361.
2019-02-05 daniel.minor Remove check for working compiler in NDK
2019-02-04 xiaotianshimail Fix Bugzilla reported bug-1525097.
2019-01-29 xiaotianshimail Additional fix for Bugzilla reported bug-1522172. Do not try tocontinue B-frame temporal direct prediction when previously encountered a concealed errors.
2019-01-26 xiaotianshimail Fix new Bugzilla reported bug-1522172
2019-01-23 xiaotianshimail Fix new Bugzilla reported bug 1522183
2019-01-23 xiaotianshimail Fix new Bugzillia reported bug 1522179.
2019-01-22 xiaotianshimail Fix Bugzilla Bug 152676
2019-01-22 xiaotianshimail Fix Bugzilla Bug 1521684 OpenH264: heap-buffer-overflow in [@ WelsDec::CWelsDecoder::FlushFrame]
2019-01-08 xiaotianshimail Bugzilla 1479656, 1485229 and 1486223 fixes without mixing with other update.
2019-01-07 xiaotianshimail Add 3-cabac and 3-cavlc b-frame temporal direct prediction mode decoding test cases.
2019-01-07 xiaotianshimail Fix Ref Picture count check for CAVLC B motion prediction.
2018-12-26 huili2 fix low memory crash issue
2019-01-04 xiaotianshimail Implemented a generic way to prevent the queued decoded B-frame buffers from being overwritten.
2019-01-04 volvet2002 refine the macro for PSNR calculate
2019-01-03 xiaotianshimail Update and fix temporal direct prediction and fix multi-reference picure re-ordering.
2019-01-02 xiaotianshimail Fix modified Colocated MB type for B frame decoding direct prediction mode.
2018-12-19 xiaotian_shi Add clean CAVLC B-Frame decoder support without whitespace change and general fix.
2018-11-27 895377235 spell error

Created with:
  roll-dep src/third_party/openh264/src

TBR=ssilken

Bug: 766721
Change-Id: I56ec9642db9af536dfb737134d83795a3f3980a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161246
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761999}

DEPS

@@ -1197,7 +1197,7 @@ deps = {
   },
 
   'src/third_party/openh264/src':
-    Var('chromium_git') + '/external/github.com/cisco/openh264' + '@' + '6f26bce0b1c4e8ce0e13332f7c0083788def5fdf',
+    Var('chromium_git') + '/external/github.com/cisco/openh264' + '@' + 'a5473711f3e20c6bd1c33d81b6c7b9a0618aa18f',
 
   'src/third_party/openscreen/src':
     Var('chromium_git') + '/openscreen' + '@' + '9a95cc089fbb642906eafad7d9cb028a9a74465e',

third_party/openh264/BUILD.gn

@@ -3,9 +3,9 @@
 # found in the LICENSE file.
 
 import("//build/config/sanitizers/sanitizers.gni")
+import("//third_party/nasm/nasm_assemble.gni")
 import("//third_party/openh264/openh264_args.gni")
 import("//third_party/openh264/openh264_sources.gni")
-import("//third_party/yasm/yasm_assemble.gni")
 
 # Config shared by all openh264 targets.
 config("config") {
@@ -40,7 +40,7 @@ config("config") {
   }
 }
 
-# YASM assembly is only checked to be working on Windows and Linux.
+# NASM assembly is only checked to be working on Windows and Linux.
 # Mac is known to fail certain tests when building, but actual assembly
 # is believed to work.
 # MSAN builds are flaky with assembler. crbug.com/685168
@@ -51,19 +51,19 @@ use_assembler = (is_win || is_linux) &&
 # This IF statement will make the targets visible only on specific builds,
 # which will lead to failures on other platforms if accidentally invoked.
 if (use_assembler) {
-  yasm_defines = []
+  asm_defines = []
   if (!is_component_build) {
     if (is_mac || is_ios) {
-      yasm_defines += [ "WELS_PRIVATE_EXTERN=:private_extern" ]
+      asm_defines += [ "WELS_PRIVATE_EXTERN=private_extern" ]
     } else if (is_linux || is_android || is_fuchsia) {
-      yasm_defines += [ "WELS_PRIVATE_EXTERN=:hidden" ]
+      asm_defines += [ "WELS_PRIVATE_EXTERN=hidden" ]
     }
   }
 
-  yasm_assemble("openh264_common_yasm") {
+  nasm_assemble("openh264_common_asm") {
     include_dirs = openh264_common_include_dirs
     sources = openh264_common_sources_asm_x86
-    defines = yasm_defines
+    defines = asm_defines
     if (current_cpu == "x86") {
       defines += [ "X86_32" ]
     } else {  # x64
@@ -80,11 +80,11 @@ if (use_assembler) {
     }
   }
 
-  yasm_assemble("openh264_processing_yasm") {
+  nasm_assemble("openh264_processing_asm") {
     include_dirs = openh264_processing_include_dirs
     include_dirs += [ "./src/codec/common/x86" ]
     sources = openh264_processing_sources_asm_x86
-    defines = yasm_defines
+    defines = asm_defines
     if (current_cpu == "x86") {
       defines += [ "X86_32" ]
     } else {  # x64
@@ -101,11 +101,11 @@ if (use_assembler) {
     }
   }
 
-  yasm_assemble("openh264_encoder_yasm") {
+  nasm_assemble("openh264_encoder_asm") {
     include_dirs = openh264_encoder_include_dirs
     include_dirs += [ "./src/codec/common/x86" ]
     sources = openh264_encoder_sources_asm_x86
-    defines = yasm_defines
+    defines = asm_defines
     if (current_cpu == "x86") {
       defines += [ "X86_32" ]
     } else {  # x64
@@ -136,7 +136,7 @@ source_set("common") {
   deps = []
   if (use_assembler) {
     defines = [ "X86_ASM" ]
-    deps += [ ":openh264_common_yasm" ]
+    deps += [ ":openh264_common_asm" ]
   }
   if (is_android) {
     deps += [
@@ -162,7 +162,7 @@ source_set("processing") {
   deps = [ ":common" ]
   if (use_assembler) {
     defines = [ "X86_ASM" ]
-    deps += [ ":openh264_processing_yasm" ]
+    deps += [ ":openh264_processing_asm" ]
   }
 }
 
@@ -188,6 +188,6 @@ source_set("encoder") {
   ]
   if (use_assembler) {
     defines = [ "X86_ASM" ]
-    deps += [ ":openh264_encoder_yasm" ]
+    deps += [ ":openh264_encoder_asm" ]
   }
 }

third_party/openh264/README.chromium

@@ -2,9 +2,8 @@ Name: OpenH264
 Short Name: openh264
 URL: http://www.openh264.org/
 Version: unknown
-CPEPrefix: cpe:/a:cisco:openh264:1.9.0
-(Cut at 6f26bce0b1c4e8ce0e13332f7c0083788def5fdf, which is between 1.9.0 and
-1.10.0)
+CPEPrefix: cpe:/a:cisco:openh264:2.1.0
+(Cut at 7067d2d9075ab4988bef2b9135ae9542f9778772, which is 2.1.0)
 License: 2-Clause BSD
 License File: src/LICENSE
 Security Critical: yes

third_party/openh264/openh264_sources.gni

@@ -4,6 +4,7 @@ openh264_common_include_dirs = [
   "//third_party/openh264/src/codec/common/arm",
   "//third_party/openh264/src/codec/common/inc",
   "//third_party/openh264/src/codec/common/src",
+  "//third_party/openh264/src/codec/common/x86",
 ]
 
 openh264_common_sources = [