Commit 7b5000e7 authored by Tibor Goldschwendt's avatar Tibor Goldschwendt Committed by Commit Bot

[webui][ntp] Re-enable NewTabPageLogoTest.All test suite

NewTabPageLogoTest.All is a suite of JS tests and was disabled because
the "receiving resize message resizes doodle" test was flaky. This CL
re-enables NewTabPageLogoTest.All and disables "receiving resize message
resizes doodle" to at least keep coverage of the non-flaky JS tests.

Bug: 1065812
Change-Id: Id17b039be73cbb81f4e4f370267b5c92a7402052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134403
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: default avatarEsmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756167}
parent edcfbd15
...@@ -107,7 +107,8 @@ suite('NewTabPageLogoTest', () => { ...@@ -107,7 +107,8 @@ suite('NewTabPageLogoTest', () => {
assertStyle(logo.$.multiColoredLogo, 'display', 'none'); assertStyle(logo.$.multiColoredLogo, 'display', 'none');
}); });
test('receiving resize message resizes doodle', async () => { // Disabled for flakiness, see https://crbug.com/1065812.
test.skip('receiving resize message resizes doodle', async () => {
// Arrange. // Arrange.
const logo = await createLogo({content: {url: {url: 'https://foo.com'}}}); const logo = await createLogo({content: {url: {url: 'https://foo.com'}}});
const transitionend = eventToPromise('transitionend', logo.$.iframe); const transitionend = eventToPromise('transitionend', logo.$.iframe);
......
...@@ -156,7 +156,6 @@ var NewTabPageLogoTest = class extends NewTabPageBrowserTest { ...@@ -156,7 +156,6 @@ var NewTabPageLogoTest = class extends NewTabPageBrowserTest {
} }
}; };
// Disabled for flakiness, see https://crbug.com/1065812 TEST_F('NewTabPageLogoTest', 'All', function() {
TEST_F('NewTabPageLogoTest', 'DISABLED_All', function() {
mocha.run(); mocha.run();
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment