Commit 7b539935 authored by Haiyang Pan's avatar Haiyang Pan Committed by Commit Bot

perf: support browser type that starts with 'reference'

And test if it works fine on the builder android-pixel2-perf-aab-fyi
Needs crrev.com/c/1975037 to land first

Bug: 986990
Change-Id: I26e492803eceb8bebc56e1e1b778cd6c4ebe04a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982234Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#727820}
parent e458a22b
...@@ -55,7 +55,8 @@ ...@@ -55,7 +55,8 @@
"-v", "-v",
"--browser=android-chrome-bundle", "--browser=android-chrome-bundle",
"--upload-results", "--upload-results",
"--test-shard-map-filename=android-pixel2-perf-aab-fyi_map.json" "--test-shard-map-filename=android-pixel2-perf-aab-fyi_map.json",
"--run-ref-build"
], ],
"isolate_name": "performance_test_suite", "isolate_name": "performance_test_suite",
"merge": { "merge": {
......
...@@ -377,7 +377,12 @@ class TelemetryCommandGenerator(object): ...@@ -377,7 +377,12 @@ class TelemetryCommandGenerator(object):
def _generate_reference_build_args(self): def _generate_reference_build_args(self):
if self._is_reference: if self._is_reference:
return ['--browser=reference', reference_browser_flag = '--browser=reference'
# TODO(crbug.com/1038137): Make the logic generic once more reference
# settings are added
if '--browser=android-chrome-bundle' in self._get_passthrough_args():
reference_browser_flag = '--browser=reference-android-chrome-bundle'
return [reference_browser_flag,
'--max-failures=5'] '--max-failures=5']
return [] return []
......
...@@ -131,6 +131,9 @@ FYI_BUILDERS = { ...@@ -131,6 +131,9 @@ FYI_BUILDERS = {
'tests': [ 'tests': [
{ {
'isolate': 'performance_test_suite', 'isolate': 'performance_test_suite',
'extra_args': [
'--run-ref-build',
],
} }
], ],
'platform': 'android-chrome-bundle', 'platform': 'android-chrome-bundle',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment