Commit 7b5df013 authored by Rouslan Solomakhin's avatar Rouslan Solomakhin Committed by Chromium LUCI CQ

[Web Payment] Enable secure payment confirmation on Windows.

Before this patch, secure payment confirmation was available only on Mac
as an origin trial.

This patch enables the renderer origin trial on Windows and enables by
default the browser feature on Windows, too.

After this patch, websites that are running the secure payment
confirmation origin trial can enroll and exercise payment credentials on
Windows with Windows Hello in addition to the existing support for
TouchID on MacOS.

The current origin trial runs to M-89, so enabling the origin trial on
Windows in M-90 will have no effect until a new origin trial is started.

Intent to experiment on MacOS until M-89:
https://groups.google.com/a/chromium.org/g/blink-dev/c/9cgsOW3XNw4/m/bBgGYUwACQAJ

Bug: 1169045
Change-Id: Ic6f37257571c4b162035c200f6eaa36919215c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642404
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: default avatarNick Burris <nburris@chromium.org>
Reviewed-by: default avatarIan Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846153}
parent 4f7da2ad
......@@ -82,7 +82,7 @@ const base::Feature kEnforceFullDelegation{"EnforceFullDelegation",
const base::Feature kSecurePaymentConfirmation {
"SecurePaymentConfirmation",
#if defined(OS_MAC)
#if defined(OS_MAC) || defined(OS_WIN)
base::FEATURE_ENABLED_BY_DEFAULT
#else
base::FEATURE_DISABLED_BY_DEFAULT
......
......@@ -85,9 +85,10 @@ extern const base::Feature kPaymentHandlerSecurityIcon;
extern const base::Feature kEnforceFullDelegation;
// Browser-side feature flag for SecurePaymentConfirmation, which can be used to
// disable the feature. The feature is also controlled by the Blink runtime
// feature "SecurePaymentConfirmation". Both have to be enabled for
// SecurePaymentConfirmation to be available.
// disable the feature. Enabling the browser-side feature by itself does not
// actually enable the feature by default. The feature is also controlled by the
// Blink runtime feature "SecurePaymentConfirmation". Both have to be enabled
// for SecurePaymentConfirmation to be available.
extern const base::Feature kSecurePaymentConfirmation;
// If enabled, the GooglePayPaymentApp handles communications between the native
......
......@@ -623,9 +623,16 @@
</message>
<!-- Secure Payment Confirmation strings -->
<message name="IDS_SECURE_PAYMENT_CONFIRMATION_VERIFY_PURCHASE" desc="The title string on a payment confirmation dialog that confirms the details of the payment that the user is about to verify. The user has the option to click 'Cancel' or 'Verify', and clicking 'Verify' will open the system interface to verify their identity with the Touch ID fingerprint sensor.">
Use Touch ID to verify and complete your purchase?
</message>
<if expr="not is_win">
<message name="IDS_SECURE_PAYMENT_CONFIRMATION_VERIFY_PURCHASE" desc="The title string on a payment confirmation dialog that confirms the details of the payment that the user is about to verify. The user has the option to click 'Cancel' or 'Verify', and clicking 'Verify' will open the system interface to verify their identity with the Touch ID fingerprint sensor.">
Use Touch ID to verify and complete your purchase?
</message>
</if> <!-- not is_win -->
<if expr="is_win">
<message name="IDS_SECURE_PAYMENT_CONFIRMATION_VERIFY_PURCHASE" desc="The title string on a payment confirmation dialog that confirms the details of the payment that the user is about to verify. The user has the option to click 'Cancel' or 'Verify', and clicking 'Verify' will open the system interface to verify their identity with the Windows Hello biometric sensor, such as fingerprint or face recognition.">
Use Windows Hello to verify and complete your purchase?
</message>
</if> <!-- is_win -->
<message name="IDS_SECURE_PAYMENT_CONFIRMATION_STORE_LABEL" desc="In a secure payment confirmation dialog, this is the label for the row of data that shows the store name, e.g. merchant.com.">
Store
</message>
......
d6454af2fab327588d43904eeb11fadc01551faa
\ No newline at end of file
1aa4c27b85bfc99f5a82bc22f0dc8e09be91ae2b
\ No newline at end of file
......@@ -1823,7 +1823,7 @@
{
name: "SecurePaymentConfirmation",
origin_trial_feature_name: "SecurePaymentConfirmation",
origin_trial_os: ["mac"],
origin_trial_os: ["mac", "win"],
status: "experimental",
},
{
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment