Commit 7b723d5c authored by hclam's avatar hclam Committed by Commit bot

Revert of Fix the Copresence permission. (patchset #1 of...

Revert of Fix the Copresence permission. (patchset #1 of https://codereview.chromium.org/523433002/)

Reason for revert:
This change causes a test failure:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/48008/steps/unit_tests/logs/stdio

Error:

[ RUN      ] PermissionsTest.PermissionMessages
../../chrome/common/extensions/permissions/permission_set_unittest.cc:781: Failure
Value of: permission_info->message_id()
Actual: 65
Expected: PermissionMessage::kNone
Which is: 1
unexpected message_id for copresence

Looks like this change is the cause.

Original issue's description:
> Fix the Copresence permission.
>
> The initializer for the Copresence permission is malformed. It specifies the
> message id instead of the flag.
>
> R=kalman@chromium.org
> BUG=408843
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/c2a41e8

TBR=kalman@chromium.org,rkc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408843

Review URL: https://codereview.chromium.org/520493002

Cr-Commit-Position: refs/heads/master@{#292532}
parent b3f24f36
......@@ -109,7 +109,7 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()
PermissionMessage::kContentSettings},
{APIPermission::kContextMenus, "contextMenus"},
{APIPermission::kCookie, "cookies"},
{APIPermission::kCopresence, "copresence", APIPermissionInfo::kFlagNone,
{APIPermission::kCopresence, "copresence",
IDS_EXTENSION_PROMPT_WARNING_COPRESENCE, PermissionMessage::kCopresence},
{APIPermission::kCopresencePrivate, "copresencePrivate"},
{APIPermission::kEnterprisePlatformKeys, "enterprise.platformKeys"},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment