Commit 7b82ce19 authored by Peter Marshall's avatar Peter Marshall Committed by Commit Bot

Fix devtools timeline aggregated test

This test includes a JSSample event that has no stackTrace property
which is not valid. The frontend assumes this property always exists
even if it is an empty array.

Drive-by fix the unused `model` var and change event to a const.

Bug: 1127827
Change-Id: Ia33e0103ba85b22e7ab18c7d7074935d65130c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454083Reviewed-by: default avatarPaul Lewis <aerotwist@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814648}
parent c6b239ff
...@@ -55,12 +55,12 @@ ...@@ -55,12 +55,12 @@
'pid': 17851, 'pid': 17851,
'tid': 23, 'tid': 23,
'ts': 142000, 'ts': 142000,
'args': {} 'args': {'data': {'stackTrace': []}}
} }
]; ];
var model = PerformanceTestRunner.createPerformanceModelWithEvents(rawTraceEvents); PerformanceTestRunner.createPerformanceModelWithEvents(rawTraceEvents);
var event = PerformanceTestRunner.mainTrackEvents().find( const event = PerformanceTestRunner.mainTrackEvents().find(
e => e.name === TimelineModel.TimelineModel.RecordType.FunctionCall); e => e.name === TimelineModel.TimelineModel.RecordType.FunctionCall);
TestRunner.addResult(`${event.startTime} ${event.endTime}`); TestRunner.addResult(`${event.startTime} ${event.endTime}`);
TestRunner.completeTest(); TestRunner.completeTest();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment