Replace deprecated getLastUsedProfile function in settings.

|Profile#getLastUsedProfile| is deprecated and replaced with
|Profile#getLastUsedRegularProfile|. This CL updates
HelpAndFeedback activity initialization at settings classes.

Since settings is considered as always running on regular mode,
it is safe to use regular profile even called in incognito mode.
For this reason, there is no need to make change on code behavior to
act differently for each profile. Therefore, it is safe to leave
behavior as-is today.

Note: This change is only code clean-up, does not change any behavior.

Bug: 1041781
Change-Id: Ic3bc99d747d28aa6269b7243d7f9feb7337ed75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058817Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742527}

chrome/android/java/src/org/chromium/chrome/browser/settings/LearnMorePreference.java

@@ -51,8 +51,8 @@ public class LearnMorePreference extends Preference {
     @Override
     protected void onClick() {
         Activity activity = ContextUtils.activityFromContext(getContext());
-        HelpAndFeedback.getInstance().show(
-                activity, activity.getString(mHelpContext), Profile.getLastUsedProfile(), null);
+        HelpAndFeedback.getInstance().show(activity, activity.getString(mHelpContext),
+                Profile.getLastUsedRegularProfile(), null);
     }
 
     @Override

chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java

@@ -239,7 +239,7 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
             return true;
         } else if (item.getItemId() == R.id.menu_id_general_help) {
             HelpAndFeedback.getInstance().show(this, getString(R.string.help_context_settings),
-                    Profile.getLastUsedProfile(), null);
+                    Profile.getLastUsedRegularProfile(), null);
             return true;
         }
         return super.onOptionsItemSelected(item);

chrome/android/java/src/org/chromium/chrome/browser/settings/password/PasswordSettings.java

@@ -175,7 +175,8 @@ public class PasswordSettings
         }
         if (id == R.id.menu_id_targeted_help) {
             HelpAndFeedback.getInstance().show(getActivity(),
-                    getString(R.string.help_context_passwords), Profile.getLastUsedProfile(), null);
+                    getString(R.string.help_context_passwords), Profile.getLastUsedRegularProfile(),
+                    null);
             return true;
         }
         return super.onOptionsItemSelected(item);

chrome/android/java/src/org/chromium/chrome/browser/settings/privacy/ClearBrowsingDataTabsFragment.java

@@ -189,7 +189,7 @@ public class ClearBrowsingDataTabsFragment extends Fragment {
         if (item.getItemId() == R.id.menu_id_targeted_help) {
             HelpAndFeedback.getInstance().show(getActivity(),
                     getString(R.string.help_context_clear_browsing_data),
-                    Profile.getLastUsedProfile(), null);
+                    Profile.getLastUsedRegularProfile(), null);
             return true;
         }
         return false;

chrome/android/java/src/org/chromium/chrome/browser/settings/privacy/PrivacySettings.java

@@ -156,7 +156,8 @@ public class PrivacySettings
     public boolean onOptionsItemSelected(MenuItem item) {
         if (item.getItemId() == R.id.menu_id_targeted_help) {
             HelpAndFeedback.getInstance().show(getActivity(),
-                    getString(R.string.help_context_privacy), Profile.getLastUsedProfile(), null);
+                    getString(R.string.help_context_privacy), Profile.getLastUsedRegularProfile(),
+                    null);
             return true;
         }
         return false;

chrome/android/java/src/org/chromium/chrome/browser/settings/website/ChosenObjectSettings.java

@@ -131,7 +131,8 @@ public class ChosenObjectSettings extends PreferenceFragmentCompat {
     public boolean onOptionsItemSelected(MenuItem item) {
         if (item.getItemId() == R.id.menu_id_targeted_help) {
             HelpAndFeedback.getInstance().show(getActivity(),
-                    getString(R.string.help_context_settings), Profile.getLastUsedProfile(), null);
+                    getString(R.string.help_context_settings), Profile.getLastUsedRegularProfile(),
+                    null);
             return true;
         }
         return false;

chrome/android/java/src/org/chromium/chrome/browser/settings/website/SingleCategorySettings.java

@@ -391,8 +391,8 @@ public class SingleCategorySettings extends PreferenceFragmentCompat
             if (mCategory.showSites(SiteSettingsCategory.Type.PROTECTED_MEDIA)) {
                 helpContextResId = R.string.help_context_protected_content;
             }
-            HelpAndFeedback.getInstance().show(
-                    getActivity(), getString(helpContextResId), Profile.getLastUsedProfile(), null);
+            HelpAndFeedback.getInstance().show(getActivity(), getString(helpContextResId),
+                    Profile.getLastUsedRegularProfile(), null);
             return true;
         }
         if (handleSearchNavigation(item, mSearchItem, mSearch, getActivity())) {