[omnibox] Remove dead flag: TabKeyCanEscapeOmniboxPopup

We WONTFIXed the bug already. We don't need this flag anymore.

Bug: 1033184
Change-Id: I0fe90e0a18ee995343ba233a74df78c15eba7aff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128787Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754733}

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -680,24 +680,6 @@ bool OmniboxViewViews::HandleEarlyTabActions(const ui::KeyEvent& event) {
       return true;
   }
 
-  if (base::FeatureList::IsEnabled(omnibox::kTabKeyCanEscapeOmniboxPopup)) {
-    // Close the popup if tab traversal exits the list.
-    size_t selected_line = model()->popup_model()->selected_line();
-    bool close_popup = event.IsShiftDown()
-                           ? selected_line == 0
-                           : selected_line == (model()->result().size() - 1);
-    if (close_popup) {
-      CloseOmniboxPopup();
-
-      // When we close the popup, we also want to restore the user's text back
-      // to the state it was before the popup opened.
-      model()->RevertTemporaryTextAndPopup();
-
-      // Return false so the focus manager will go to the next element.
-      return false;
-    }
-  }
-
   // Translate tab and shift-tab into down and up respectively.
   model()->OnUpOrDownKeyPressed(event.IsShiftDown() ? -1 : 1);
   // If we shift-tabbed (and actually moved) to a suggestion with a tab

components/omnibox/common/omnibox_features.cc

@@ -314,11 +314,6 @@ const base::Feature kOmniboxLooseMaxLimitOnDedicatedRows{
 const base::Feature kOmniboxSuggestionButtonRow{
     "OmniboxSuggestionButtonRow", base::FEATURE_DISABLED_BY_DEFAULT};
 
-// If enabled, allows Tab and Shift+Tab to escape the focus out of the omnibox
-// popup. Otherwise, Tab infinitely loops between suggestions in the popup.
-const base::Feature kTabKeyCanEscapeOmniboxPopup{
-    "TabKeyCanEscapeOmniboxPopup", base::FEATURE_DISABLED_BY_DEFAULT};
-
 // If enabled, uses WebUI to render the omnibox suggestions popup, similar to
 // how the NTP "fakebox" is implemented.
 const base::Feature kWebUIOmniboxPopup{"WebUIOmniboxPopup",

components/omnibox/common/omnibox_features.h

@@ -67,7 +67,6 @@ extern const base::Feature kDeferredKeyboardPopup;
 extern const base::Feature kRichAutocompletion;
 extern const base::Feature kOmniboxLooseMaxLimitOnDedicatedRows;
 extern const base::Feature kOmniboxSuggestionButtonRow;
-extern const base::Feature kTabKeyCanEscapeOmniboxPopup;
 extern const base::Feature kWebUIOmniboxPopup;
 
 // Omnibox UI - these affect the UI or function of the location bar (not the