Commit 7bbae44f authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Revert "Add dbghelp.dll to delay load list"

This reverts commit 4edc0503.

Reason for revert: Breaks minidump generation on Windows

Original change's description:
> Add dbghelp.dll to delay load list
>
> Currently, many of the binaries have a static dependency on dbghelp.dll.
> This results in dbghelp getting loaded in all chrome processes. Upon
> inspection, dbghelp.dll is only necessary for stack sampling and mini
> dump handing in crashpad. Stack sampling is only enabled by default on
> unofficial builds of dev and canary.  All other times we are needlessly
> loading this module which brings in 300k of image file refset and 60k
> of Copy on Write costs per process.  This change adds it to the delay
> load list.
>
> Change-Id: I13da0ce0735431c5c51cdbc9ba2cfea0cc3cded7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336541
> Commit-Queue: Chris Davis <chrdavis@microsoft.com>
> Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#796707}

TBR=thakis@chromium.org,brucedawson@chromium.org,cliffsmo@microsoft.com,chrdavis@microsoft.com

Change-Id: I6051562e22eaa9e778b7077c3efab1129bdfd77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350744
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797080}
parent afd9bed4
...@@ -386,7 +386,6 @@ config("delayloads") { ...@@ -386,7 +386,6 @@ config("delayloads") {
"/DELAYLOAD:cryptui.dll", "/DELAYLOAD:cryptui.dll",
"/DELAYLOAD:d3d11.dll", "/DELAYLOAD:d3d11.dll",
"/DELAYLOAD:d3d9.dll", "/DELAYLOAD:d3d9.dll",
"/DELAYLOAD:dbghelp.dll",
"/DELAYLOAD:dwmapi.dll", "/DELAYLOAD:dwmapi.dll",
"/DELAYLOAD:dxgi.dll", "/DELAYLOAD:dxgi.dll",
"/DELAYLOAD:dxva2.dll", "/DELAYLOAD:dxva2.dll",
...@@ -424,6 +423,7 @@ config("delayloads_not_for_child_dll") { ...@@ -424,6 +423,7 @@ config("delayloads_not_for_child_dll") {
ldflags = [ ldflags = [
"/DELAYLOAD:advapi32.dll", "/DELAYLOAD:advapi32.dll",
"/DELAYLOAD:crypt32.dll", "/DELAYLOAD:crypt32.dll",
"/DELAYLOAD:dbghelp.dll",
"/DELAYLOAD:dhcpcsvc.dll", "/DELAYLOAD:dhcpcsvc.dll",
"/DELAYLOAD:dwrite.dll", "/DELAYLOAD:dwrite.dll",
"/DELAYLOAD:iphlpapi.dll", "/DELAYLOAD:iphlpapi.dll",
......
...@@ -96,6 +96,7 @@ TEST_F(DelayloadsTest, ChromeDllDelayloadsCheck) { ...@@ -96,6 +96,7 @@ TEST_F(DelayloadsTest, ChromeDllDelayloadsCheck) {
"DWrite.dll", "DWrite.dll",
"ADVAPI32.dll", "ADVAPI32.dll",
"CRYPT32.dll", "CRYPT32.dll",
"dbghelp.dll",
"dhcpcsvc.DLL", "dhcpcsvc.DLL",
"IPHLPAPI.DLL", "IPHLPAPI.DLL",
"ntdll.dll", "ntdll.dll",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment