Commit 7bc49f82 authored by Michael Irani's avatar Michael Irani Committed by Commit Bot

a11y: Edit Printer dialog: ChromeVox does not read text contents

Add aria tags so that label and value for fields announced
when in ChromeVox mode.

Bug: 1034104
Change-Id: I47e7b98a01fb8ef694f179f26e120a67d4341859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464054Reviewed-by: default avatarRegan Hsu <hsuregan@chromium.org>
Commit-Queue: Michael Irani <michaelirani@chromium.org>
Auto-Submit: Michael Irani <michaelirani@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816311}
parent 09edd90d
...@@ -32,11 +32,13 @@ ...@@ -32,11 +32,13 @@
value="{{pendingPrinter_.printerName}}" value="{{pendingPrinter_.printerName}}"
on-input="onPrinterInfoChange_" on-input="onPrinterInfoChange_"
label="$i18n{printerName}" label="$i18n{printerName}"
aria-label="$i18n{printerName}"
maxlength=64> maxlength=64>
</cr-input> </cr-input>
</div> </div>
<div class="settings-box two-line"> <div class="settings-box two-line">
<cr-input label="$i18n{printerAddress}" <cr-input label="$i18n{printerAddress}"
aria-label="$i18n{printerAddress}"
id="printerAddress" id="printerAddress"
on-input="onPrinterInfoChange_" on-input="onPrinterInfoChange_"
value="{{pendingPrinter_.printerAddress}}" value="{{pendingPrinter_.printerAddress}}"
...@@ -93,6 +95,7 @@ ...@@ -93,6 +95,7 @@
</div> </div>
<div class="settings-box two-line"> <div class="settings-box two-line">
<cr-input id="printerQueue" label="$i18n{printerQueue}" <cr-input id="printerQueue" label="$i18n{printerQueue}"
aria-label="$i18n{printerQueue}"
value="{{pendingPrinter_.printerQueue}}" value="{{pendingPrinter_.printerQueue}}"
on-input="onPrinterInfoChange_" on-input="onPrinterInfoChange_"
maxlength=64 maxlength=64
...@@ -103,6 +106,7 @@ ...@@ -103,6 +106,7 @@
</div> </div>
<div class="settings-box two-line"> <div class="settings-box two-line">
<cr-input label="$i18n{printerURI}" readonly <cr-input label="$i18n{printerURI}" readonly
aria-label="$i18n{printerURI}"
value="[[getPrinterURI_(pendingPrinter_)]]" value="[[getPrinterURI_(pendingPrinter_)]]"
disabled="[[!isInputFieldEnabled_(networkProtocolActive_, disabled="[[!isInputFieldEnabled_(networkProtocolActive_,
pendingPrinter_.printServerUri)]]"> pendingPrinter_.printServerUri)]]">
...@@ -114,6 +118,7 @@ ...@@ -114,6 +118,7 @@
<cr-searchable-drop-down items="[[manufacturerList]]" <cr-searchable-drop-down items="[[manufacturerList]]"
id="printerPPDManufacturer" id="printerPPDManufacturer"
label="$i18n{printerManufacturer}" label="$i18n{printerManufacturer}"
aria-label="$i18n{printerManufacturer}"
value="{{pendingPrinter_.ppdManufacturer}}" value="{{pendingPrinter_.ppdManufacturer}}"
readonly="[[!isOnline_]]" readonly="[[!isOnline_]]"
invalid="{{isManufacturerInvalid_}}"> invalid="{{isManufacturerInvalid_}}">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment