Commit 7bd179d6 authored by pneubeck's avatar pneubeck Committed by Commit bot

Remove misleading BrowserContextKeyedAPI comment.

The comment suggests that one can manage the factory instance using the Singleton class.
That is not possible as Singleton<T> has private methods only and declares only T::GetInstance as friend.
BrowserContextKeyedAPIFactory<X>::GetInstance cannot be defined by users however.

That misleading comment was added here
https://chromiumcodereview.appspot.com/11682005

Review URL: https://codereview.chromium.org/1135343003

Cr-Commit-Position: refs/heads/master@{#330068}
parent 5789b14f
...@@ -43,9 +43,9 @@ class BrowserContextKeyedAPI : public KeyedService { ...@@ -43,9 +43,9 @@ class BrowserContextKeyedAPI : public KeyedService {
static const bool kServiceIsNULLWhileTesting = false; static const bool kServiceIsNULLWhileTesting = false;
// Users of this factory template must define a GetFactoryInstance() // Users of this factory template must define a GetFactoryInstance()
// and manage their own instances (typically using LazyInstance or // and manage their own instances (using LazyInstance), because those cannot
// Singleton), because those cannot be included in more than one // be included in more than one translation unit (and thus cannot be
// translation unit (and thus cannot be initialized in a header file). // initialized in a header file).
// //
// In the header file, declare GetFactoryInstance(), e.g.: // In the header file, declare GetFactoryInstance(), e.g.:
// class HistoryAPI { // class HistoryAPI {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment