Commit 7be9d959 authored by creis's avatar creis Committed by Commit bot

Replace NC_AUTO_SUBFRAME renderer kill with NOTREACHED for now.

BUG=486916
TEST=No more NC_AUTO_SUBFRAME renderer kills.

Review URL: https://codereview.chromium.org/1124313003

Cr-Commit-Position: refs/heads/master@{#329938}
parent 7894b555
...@@ -1461,8 +1461,11 @@ bool NavigationControllerImpl::RendererDidNavigateAutoSubframe( ...@@ -1461,8 +1461,11 @@ bool NavigationControllerImpl::RendererDidNavigateAutoSubframe(
// We can't check the path since that may change (https://crbug.com/373041). // We can't check the path since that may change (https://crbug.com/373041).
if (GetLastCommittedEntry()->GetURL().GetOrigin() != if (GetLastCommittedEntry()->GetURL().GetOrigin() !=
GetEntryAtIndex(entry_index)->GetURL().GetOrigin()) { GetEntryAtIndex(entry_index)->GetURL().GetOrigin()) {
bad_message::ReceivedBadMessage(rfh->GetProcess(), // TODO(creis): This is unexpectedly being encountered in practice. If
bad_message::NC_AUTO_SUBFRAME); // you encounter this in practice, please post details to
// https://crbug.com/486916. Once that's resolved, we'll change this to
// kill the renderer process with bad_message::NC_AUTO_SUBFRAME.
NOTREACHED() << "Unexpected main frame origin change on AUTO_SUBFRAME.";
} }
last_committed_entry_index_ = entry_index; last_committed_entry_index_ = entry_index;
DiscardNonCommittedEntriesInternal(); DiscardNonCommittedEntriesInternal();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment