Commit 7bf6f28e authored by Fabio Tirelo's avatar Fabio Tirelo Committed by Commit Bot

[AF] Remove test param from DevTools sanity browser tests

This is to prepare the field for removing feature
kAutofillExpandedPopupViews.

Bug: 831603
Change-Id: I7db276de2da430634e146ad7641669e139fc6fa1
Reviewed-on: https://chromium-review.googlesource.com/1210387Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589308}
parent 36f4c7fa
...@@ -1625,32 +1625,6 @@ class AutofillManagerTestDelegateDevtoolsImpl ...@@ -1625,32 +1625,6 @@ class AutofillManagerTestDelegateDevtoolsImpl
DISALLOW_COPY_AND_ASSIGN(AutofillManagerTestDelegateDevtoolsImpl); DISALLOW_COPY_AND_ASSIGN(AutofillManagerTestDelegateDevtoolsImpl);
}; };
// Test params:
// - bool popup_views_enabled: whether feature AutofillExpandedPopupViews
// is enabled for testing.
//
// This test is parametrized to ensure that it runs for the
// AutofillExpandedPopupViews feature either enabled or disabled, while it's
// rolled out.
// TODO(crbug.com/831603): This can be merged into DevToolsSanityTest when
// AutofillExpandedPopupViews becomes the default
// behavior and is no longer used.
class AutofillDevToolsSanityTest : public DevToolsSanityTest,
public ::testing::WithParamInterface<bool> {
public:
AutofillDevToolsSanityTest() = default;
~AutofillDevToolsSanityTest() override = default;
void SetUpOnMainThread() override {
const bool popup_views_enabled = GetParam();
scoped_feature_list_.InitWithFeatureState(
autofill::features::kAutofillExpandedPopupViews, popup_views_enabled);
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
// Disabled. Failing on MacOS MSAN. See https://crbug.com/849129. // Disabled. Failing on MacOS MSAN. See https://crbug.com/849129.
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
#define MAYBE_TestDispatchKeyEventShowsAutoFill \ #define MAYBE_TestDispatchKeyEventShowsAutoFill \
...@@ -1659,7 +1633,7 @@ class AutofillDevToolsSanityTest : public DevToolsSanityTest, ...@@ -1659,7 +1633,7 @@ class AutofillDevToolsSanityTest : public DevToolsSanityTest,
#define MAYBE_TestDispatchKeyEventShowsAutoFill \ #define MAYBE_TestDispatchKeyEventShowsAutoFill \
TestDispatchKeyEventShowsAutoFill TestDispatchKeyEventShowsAutoFill
#endif #endif
IN_PROC_BROWSER_TEST_P(AutofillDevToolsSanityTest, IN_PROC_BROWSER_TEST_F(DevToolsSanityTest,
MAYBE_TestDispatchKeyEventShowsAutoFill) { MAYBE_TestDispatchKeyEventShowsAutoFill) {
OpenDevToolsWindow(kDispatchKeyEventShowsAutoFill, false); OpenDevToolsWindow(kDispatchKeyEventShowsAutoFill, false);
...@@ -1676,8 +1650,6 @@ IN_PROC_BROWSER_TEST_P(AutofillDevToolsSanityTest, ...@@ -1676,8 +1650,6 @@ IN_PROC_BROWSER_TEST_P(AutofillDevToolsSanityTest,
CloseDevToolsWindow(); CloseDevToolsWindow();
} }
INSTANTIATE_TEST_CASE_P(All, AutofillDevToolsSanityTest, ::testing::Bool());
// Tests that settings are stored in profile correctly. // Tests that settings are stored in profile correctly.
IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestSettings) { IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestSettings) {
OpenDevToolsWindow("about:blank", true); OpenDevToolsWindow("about:blank", true);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment