Skip to content

GitLab

T
tangled
Commit 7c122bf9 authored by Prashant Nevase's avatar Prashant Nevase Committed by Commit Bot
Browse files
Options

Organize dark mode virtual tests. 

The virtual tests for dark mode were scattered in virtual test
directory. This patch moves them in web_tests/dark-mode, a single real
directory. The dark mode has two main categories of the tests viz.
colors and images. The tests are now organized in these categories.

The web_tests/dark-mode runs tests in normal mode. The virtual tests
run the tests in dark mode with additional arguments.

Bug: 1116914

Change-Id: I5c8dfc9b6085e5d70475a82d018c25482f53fb6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377037
Commit-Queue: Prashant Nevase <prashant.n@samsung.com>
Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803204}
parent e5b906d1
Hide whitespace changes
Inline Side-by-side
Showing with 31 additions and 37 deletions
third_party/blink/web_tests/VirtualTestSuites
View file @ 7c122bf9
...@@ -249,39 +249,24 @@ ...@@ -249,39 +249,24 @@
"args": ["--enable-blink-features=LayoutNGGrid"] "args": ["--enable-blink-features=LayoutNGGrid"]
}, },
{ {
"prefix": "dark-mode-grayscale-images", "prefix": "dark-mode-default",
"bases": [], "bases": ["dark-mode/colors"],
"args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeInversionAlgorithm=3,forceDarkModeImagePolicy=0,forceDarkModeImageStyle=1,forceDarkModeTextBrightnessThreshold=256,forceDarkModeBackgroundBrightnessThreshold=0"] "args": ["--blink-settings=forceDarkModeEnabled=true"]
}, },
{ {
"prefix": "dark-mode-image-filter-all", "prefix": "dark-mode-images-filter-all",
"bases": [], "bases": ["dark-mode/images"],
"args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeInversionAlgorithm=3,forceDarkModeImagePolicy=0,forceDarkModeTextBrightnessThreshold=256,forceDarkModeBackgroundBrightnessThreshold=0"] "args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=0"]
}, },
{ {
"prefix": "dark-mode-image-filter-none", "prefix": "dark-mode-images-filter-none",
"bases": [], "bases": ["dark-mode/images"],
"args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeInversionAlgorithm=3,forceDarkModeImagePolicy=1,forceDarkModeTextBrightnessThreshold=256,forceDarkModeBackgroundBrightnessThreshold=0"] "args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=1,"]
}, },
{ {
"prefix": "dark-mode-native-theme-off", "prefix": "dark-mode-images-grayscale",
"bases": [], "bases": ["dark-mode/images"],
"args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeInversionAlgorithm=3,forceDarkModeTextBrightnessThreshold=256,forceDarkModeBackgroundBrightnessThreshold=0"] "args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=0,forceDarkModeImageStyle=1"]
},
{
"prefix": "dark-mode-native-theme-on",
"bases": [],
"args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeInversionAlgorithm=3,forceDarkModeTextBrightnessThreshold=256,forceDarkModeBackgroundBrightnessThreshold=0"]
},
{
"prefix": "dark-mode-page-background",
"bases": [],
"args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeInversionAlgorithm=3,forceDarkModeTextBrightnessThreshold=256,forceDarkModeBackgroundBrightnessThreshold=0"]
},
{
"prefix": "dark-mode-text",
"bases": [],
"args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeInversionAlgorithm=3,forceDarkModeImagePolicy=1,forceDarkModeTextBrightnessThreshold=100,forceDarkModeBackgroundBrightnessThreshold=205"]
}, },
{ {
"prefix": "presentation", "prefix": "presentation",
......
third_party/blink/web_tests/dark-mode/images/desaturate-before-inversion.html 0 → 100644
View file @ 7c122bf9
<!DOCTYPE html>
<img src="resources/desaturate-before-inversion.svg" />
third_party/blink/web_tests/dark-mode/images/image-noinvert.html 0 → 100644
View file @ 7c122bf9
<!DOCTYPE html>
<img src="resources/png-simple.png">
third_party/blink/web_tests/virtual/dark-mode-native-theme-on/README.txt → third_party/blink/web_tests/virtual/dark-mode-default/dark-mode/colors/README.txt
View file @ 7c122bf9
# This suite runs the tests in LayoutTests/paint/dark-mode # This suite runs the tests in web_tests/dark-mode/colors
# with --blink-settings="darkMode=3" # with --blink-settings=forceDarkModeEnabled=true
# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py. # See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
third_party/blink/web_tests/virtual/dark-mode-image-filter-all/image-invert.html deleted 100644 → 0
View file @ e5b906d1
<!DOCTYPE html>
<img src="../../images/resources/png-simple.png">
third_party/blink/web_tests/virtual/dark-mode-image-filter-none/image-noinvert.html deleted 100644 → 0
View file @ e5b906d1
<!DOCTYPE html>
<img src="../../images/resources/png-simple.png">
third_party/blink/web_tests/virtual/dark-mode-image-filter-all/README.txt → third_party/blink/web_tests/virtual/dark-mode-images-filter-all/dark-mode/images/README.txt
View file @ 7c122bf9
# This suite runs the tests in LayoutTests/paint/dark-mode # This suite runs the tests in web_tests/dark-mode/images with
# with --blink-settings="darkMode=3,darkModeImagePolicy=0" # --blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=0
# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py. # See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
third_party/blink/web_tests/virtual/dark-mode-image-filter-none/README.txt → third_party/blink/web_tests/virtual/dark-mode-images-filter-none/dark-mode/images/README.txt
View file @ 7c122bf9
# This suite runs the tests in LayoutTests/paint/dark-mode # This suite runs the tests in web_tests/dark-mode/images with
# with --blink-settings="darkMode=3,darkModeImagePolicy=1" # --blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=1
# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py. # See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
third_party/blink/web_tests/virtual/dark-mode-grayscale-images/README.txt → third_party/blink/web_tests/virtual/dark-mode-images-grayscale/dark-mode/images/README.txt
View file @ 7c122bf9
# This suite runs the tests in LayoutTests/paint/dark-mode # This suite runs the tests in web_tests/dark-mode/images with
# with --blink-settings="darkMode=3,darkModeImagePolicy=0,darkModeImageStyle=1" # --blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=0,forceDarkModeImageStyle=1
# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py. # See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
third_party/blink/web_tests/virtual/dark-mode-native-theme-off/README.txt deleted 100644 → 0
View file @ e5b906d1
# This suite runs the tests in LayoutTests/paint/dark-mode
# with --blink-settings="darkMode=3"
# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
third_party/blink/web_tests/virtual/dark-mode-page-background/README.txt deleted 100644 → 0
View file @ e5b906d1
# This suite runs the tests in LayoutTests/paint/dark-mode
# with --blink-settings="darkMode=3"
# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment