Commit 7c13a39d authored by Yi Gu's avatar Yi Gu Committed by Commit Bot

Revert "[WebOTP] Tentatively re-enable SmsBrowserTests"

This reverts commit fb77bf14.

Reason for revert: Test is still flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=AtMostOneSmsRequestPerOriginPerTab

Original change's description:
> [WebOTP] Tentatively re-enable SmsBrowserTests
> 
> There were 3 tests disabled in Feb due to flakiness (RunLoop timeout).
> This patch re-enables one of them to verify whether the flakiness has
> been fixed by recent changes and gather up-to-date failure logs if not.
> 
> Bug: 1052385
> Change-Id: Ib9dcabf769a4ff03d31e1ec1601c69717f590040
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302409
> Reviewed-by: Sam Goto <goto@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#789789}

TBR=yigu@chromium.org,goto@chromium.org

Change-Id: I9dc46de890dd869ccc1324e72065beac7713471d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1052385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305831Reviewed-by: default avatarYi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789905}
parent cbf87d5f
......@@ -228,7 +228,9 @@ IN_PROC_BROWSER_TEST_F(SmsBrowserTest, AtMostOneSmsRequestPerOrigin) {
ExpectOutcomeUKM(url, blink::SMSReceiverOutcome::kSuccess);
}
IN_PROC_BROWSER_TEST_F(SmsBrowserTest, AtMostOneSmsRequestPerOriginPerTab) {
// Disabled test: https://crbug.com/1052385
IN_PROC_BROWSER_TEST_F(SmsBrowserTest,
DISABLED_AtMostOneSmsRequestPerOriginPerTab) {
auto provider = std::make_unique<MockSmsProvider>();
MockSmsProvider* mock_provider_ptr = provider.get();
BrowserMainLoop::GetInstance()->SetSmsProviderForTesting(std::move(provider));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment