Commit 7c159822 authored by bradnelson@google.com's avatar bradnelson@google.com

Re-enabling checkdeps for most of ppapi + nacl.

Many of the includes / dependencies in ppapi + nacl are badly specified.
This turns on checkdeps for most stuff and makes extra stuff explicit.

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=checkdeps passes
R=brettw@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10797018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148699 0039d316-1c4b-4281-b951-d872f2087c98
parent 1666bf2e
...@@ -495,7 +495,6 @@ skip_child_includes = [ ...@@ -495,7 +495,6 @@ skip_child_includes = [
"chrome_frame", "chrome_frame",
"delegate_execute", "delegate_execute",
"metro_driver", "metro_driver",
"native_client",
"native_client_sdk", "native_client_sdk",
"o3d", "o3d",
"pdf", "pdf",
......
...@@ -3,7 +3,6 @@ include_rules = [ ...@@ -3,7 +3,6 @@ include_rules = [
"+crypto", "+crypto",
"+gpu", "+gpu",
"+jni", "+jni",
"+native_client",
"+net", "+net",
"+printing", "+printing",
"+sql", "+sql",
...@@ -11,6 +10,12 @@ include_rules = [ ...@@ -11,6 +10,12 @@ include_rules = [
"-v8", "-v8",
"+v8/include", "+v8/include",
# Limit what we include from nacl.
"-native_client",
"+native_client/src/trusted/service_runtime/osx",
"+native_client/src/trusted/service_runtime/win",
"+native_client/src/shared/imc",
# The subdirectories in chrome/ will manually allow their own include # The subdirectories in chrome/ will manually allow their own include
# directories in chrome/ so we disallow all of them. # directories in chrome/ so we disallow all of them.
"-chrome", "-chrome",
......
include_rules = [ include_rules = [
"+native_client", "+native_client/src/include",
"+third_party/angle", "+third_party/angle",
"+third_party/amd", "+third_party/amd",
"+../../gpu_export.h", "+../../gpu_export.h",
......
...@@ -2,10 +2,3 @@ include_rules = [ ...@@ -2,10 +2,3 @@ include_rules = [
"+third_party/skia", "+third_party/skia",
"+third_party/WebKit/Source/WebKit/chromium/public", "+third_party/WebKit/Source/WebKit/chromium/public",
] ]
# checkdeps.py shouldn't check include paths for files in these dirs:
skip_child_includes = [
# TODO(bradnelson): fix these to comply, once migration is complete.
# http://code.google.com/p/chromium/issues/detail?id=93520
"native_client",
]
include_rules = [
"+native_client/src/include",
"+native_client/src/shared/platform",
# TODO(bradnelson): Eliminate these as they are actually incorrectly rooted
# internal references.
"+native_client/src/shared/ppapi_proxy",
"+native_client/tests/ppapi_geturl",
"+native_client/tests/ppapi_test_lib",
"+srpcgen",
"+trusted/srpcgen",
"+untrusted/srpcgen",
]
include_rules = [
# TODO(bradnelson): eliminate this as its actually an incorrectly rooted
# internal reference.
"+native_client/src/trusted/plugin",
"+gpu",
"+native_client/src/shared/imc",
"+native_client/src/shared/srpc",
"+native_client/src/trusted/desc",
"+native_client/src/trusted/service_runtime/include/machine",
"+native_client/src/untrusted/irt",
"+native_client/src/untrusted/pthread",
]
include_rules = [
"+native_client/src/shared/imc",
"+native_client/src/shared/srpc",
"+native_client/src/trusted",
"+third_party/jsoncpp",
]
include_rules = [
# TODO(bradnelson): Eliminate these rules. While we should keep this test,
# it does not currently appear to be connected to the build.
# It also appears to have bit-rotted as native_client/common/worker.h seems to
# be an obsolete filename.
# Once it is building, it shouldn't use files from native_client.
"+native_client/tests/earth",
"+native_client/common",
]
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment