Commit 7c26e35e authored by Patrick Monette's avatar Patrick Monette Committed by Commit Bot

Crash when a process node is destroyed while still hosting worker nodes

This is a temporary CHECK() to help diagnose an existing crash.

The goal is to turn it into a dcheck once the issue is solved.

Bug: 1058705
Change-Id: I985d38759dcbfdd00ccdea896c1630fa925cf35f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097175
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: default avatarSigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749162}
parent bd40164b
...@@ -22,6 +22,10 @@ ProcessNodeImpl::ProcessNodeImpl(GraphImpl* graph, ...@@ -22,6 +22,10 @@ ProcessNodeImpl::ProcessNodeImpl(GraphImpl* graph,
ProcessNodeImpl::~ProcessNodeImpl() { ProcessNodeImpl::~ProcessNodeImpl() {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
// Crash if this process node is destroyed while still hosting a worker node.
// TODO(https://crbug.com/1058705): Turn this into a DCHECK once the issue is
// resolved.
CHECK(worker_nodes_.empty());
} }
void ProcessNodeImpl::Bind( void ProcessNodeImpl::Bind(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment