Commit 7c49d002 authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

Remove unused member variable from ppb_var_unittest.cc

Recent Clang versions (r317076+) warn about this.

TBR=dmichael

Bug: 780523
Change-Id: Id3c239f109119aec9167096bed87a9b886632739
Reviewed-on: https://chromium-review.googlesource.com/749736Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513282}
parent 97ee2f8b
...@@ -98,12 +98,14 @@ class CreateVarThreadDelegate : public base::PlatformThread::Delegate { ...@@ -98,12 +98,14 @@ class CreateVarThreadDelegate : public base::PlatformThread::Delegate {
// |strings_in|, |vars|, and |strings_out| are arrays, and size is their size. // |strings_in|, |vars|, and |strings_out| are arrays, and size is their size.
// For each |strings_in[i]|, we will set |vars[i]| using that value. Then we // For each |strings_in[i]|, we will set |vars[i]| using that value. Then we
// read the var back out to |strings_out[i]|. // read the var back out to |strings_out[i]|.
CreateVarThreadDelegate(PP_Module pp_module, const std::string* strings_in, CreateVarThreadDelegate(const std::string* strings_in,
PP_Var* vars_out, std::string* strings_out, PP_Var* vars_out,
std::string* strings_out,
size_t size) size_t size)
: pp_module_(pp_module), strings_in_(strings_in), vars_out_(vars_out), : strings_in_(strings_in),
strings_out_(strings_out), size_(size) { vars_out_(vars_out),
} strings_out_(strings_out),
size_(size) {}
virtual ~CreateVarThreadDelegate() {} virtual ~CreateVarThreadDelegate() {}
virtual void ThreadMain() { virtual void ThreadMain() {
const PPB_Var* ppb_var = ppapi::PPB_Var_Shared::GetVarInterface1_2(); const PPB_Var* ppb_var = ppapi::PPB_Var_Shared::GetVarInterface1_2();
...@@ -115,7 +117,6 @@ class CreateVarThreadDelegate : public base::PlatformThread::Delegate { ...@@ -115,7 +117,6 @@ class CreateVarThreadDelegate : public base::PlatformThread::Delegate {
} }
} }
private: private:
PP_Module pp_module_;
const std::string* strings_in_; const std::string* strings_in_;
PP_Var* vars_out_; PP_Var* vars_out_;
std::string* strings_out_; std::string* strings_out_;
...@@ -181,13 +182,10 @@ TEST_F(PPB_VarTest, Threads) { ...@@ -181,13 +182,10 @@ TEST_F(PPB_VarTest, Threads) {
// kNumThreads). // kNumThreads).
for (size_t slice_start= 0; slice_start < kNumStrings; for (size_t slice_start= 0; slice_start < kNumStrings;
slice_start += strings_per_thread) { slice_start += strings_per_thread) {
create_var_delegates.push_back( create_var_delegates.push_back(CreateVarThreadDelegate(
CreateVarThreadDelegate(pp_module(), &test_strings_[slice_start], &vars_[slice_start],
&test_strings_[slice_start], &strings_out[slice_start],
&vars_[slice_start], std::min(strings_per_thread, kNumStrings - slice_start)));
&strings_out[slice_start],
std::min(strings_per_thread,
kNumStrings - slice_start)));
} }
// Now run then join all the threads. // Now run then join all the threads.
for (size_t i = 0; i < kNumThreads; ++i) for (size_t i = 0; i < kNumThreads; ++i)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment