Commit 7c554ad1 authored by manukh's avatar manukh Committed by Chromium LUCI CQ

[omnibox] [doc|drive] Set param defaults to launch values.

This does not enable the drive feature by default as it's currently
limited to enterprise users.

Sets:
- DocumentUseClientScore to true
- DocumentProviderMaxQueryLength to 200
- DebounceDocumentProviderDelayMs to 300

Change-Id: Idf85fcf6b25a844b196fa5ae82d5ac7617e6dad9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575378
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: default avatarJustin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834350}
parent 0ef9d928
...@@ -527,7 +527,7 @@ DocumentProvider::DocumentProvider(AutocompleteProviderClient* client, ...@@ -527,7 +527,7 @@ DocumentProvider::DocumentProvider(AutocompleteProviderClient* client,
static_cast<size_t>(base::GetFieldTrialParamByFeatureAsInt( static_cast<size_t>(base::GetFieldTrialParamByFeatureAsInt(
omnibox::kDocumentProvider, omnibox::kDocumentProvider,
"DocumentProviderMaxQueryLength", "DocumentProviderMaxQueryLength",
-1))), 200))),
min_query_show_length_( min_query_show_length_(
static_cast<size_t>(base::GetFieldTrialParamByFeatureAsInt( static_cast<size_t>(base::GetFieldTrialParamByFeatureAsInt(
omnibox::kDocumentProvider, omnibox::kDocumentProvider,
...@@ -561,7 +561,7 @@ DocumentProvider::DocumentProvider(AutocompleteProviderClient* client, ...@@ -561,7 +561,7 @@ DocumentProvider::DocumentProvider(AutocompleteProviderClient* client,
"DebounceDocumentProviderFromLastRun", true); "DebounceDocumentProviderFromLastRun", true);
int delay_ms = base::GetFieldTrialParamByFeatureAsInt( int delay_ms = base::GetFieldTrialParamByFeatureAsInt(
omnibox::kDebounceDocumentProvider, "DebounceDocumentProviderDelayMs", omnibox::kDebounceDocumentProvider, "DebounceDocumentProviderDelayMs",
100); 300);
debouncer_ = std::make_unique<AutocompleteProviderDebouncer>(from_last_run, debouncer_ = std::make_unique<AutocompleteProviderDebouncer>(from_last_run,
delay_ms); delay_ms);
} else } else
...@@ -705,7 +705,7 @@ ACMatches DocumentProvider::ParseDocumentSearchResults( ...@@ -705,7 +705,7 @@ ACMatches DocumentProvider::ParseDocumentSearchResults(
// two scores will be used. // two scores will be used.
// If both are false, the server score will be used. // If both are false, the server score will be used.
bool use_client_score = base::GetFieldTrialParamByFeatureAsBool( bool use_client_score = base::GetFieldTrialParamByFeatureAsBool(
omnibox::kDocumentProvider, "DocumentUseClientScore", false); omnibox::kDocumentProvider, "DocumentUseClientScore", true);
bool use_server_score = base::GetFieldTrialParamByFeatureAsBool( bool use_server_score = base::GetFieldTrialParamByFeatureAsBool(
omnibox::kDocumentProvider, "DocumentUseServerScore", true); omnibox::kDocumentProvider, "DocumentUseServerScore", true);
...@@ -799,7 +799,7 @@ ACMatches DocumentProvider::ParseDocumentSearchResults( ...@@ -799,7 +799,7 @@ ACMatches DocumentProvider::ParseDocumentSearchResults(
// Decrement scores if necessary to ensure suggestion order is preserved. // Decrement scores if necessary to ensure suggestion order is preserved.
// Don't decrement client scores which don't necessarily rank suggestions // Don't decrement client scores which don't necessarily rank suggestions
// the same as the server. // the same order as the server.
if (!use_client_score && score >= previous_score) if (!use_client_score && score >= previous_score)
score = std::max(previous_score - 1, 0); score = std::max(previous_score - 1, 0);
previous_score = score; previous_score = score;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment