Commit 7c6eef60 authored by Alex Rudenko's avatar Alex Rudenko Committed by Commit Bot

Fix hideHighlight

ClearInspectTool was not clearing inspect_tool_ in the expected
order (DisableFrameOverlay checks inspect_tool_ via IsVisible method),
thus, breaking hideHighlight functionality. This was broken
in https://crrev.com/c/2397735

Fixed: 1136455
Change-Id: I97dc444cffee98cb41a8ac8285f4e7d0cc797715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460732
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: default avatarSigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815147}
parent f94e194d
...@@ -1357,9 +1357,9 @@ void InspectorOverlayAgent::EnsureEnableFrameOverlay() { ...@@ -1357,9 +1357,9 @@ void InspectorOverlayAgent::EnsureEnableFrameOverlay() {
} }
void InspectorOverlayAgent::ClearInspectTool() { void InspectorOverlayAgent::ClearInspectTool() {
inspect_tool_ = nullptr;
if (!hinge_) if (!hinge_)
DisableFrameOverlay(); DisableFrameOverlay();
inspect_tool_ = nullptr;
} }
Response InspectorOverlayAgent::SetInspectTool(InspectTool* inspect_tool) { Response InspectorOverlayAgent::SetInspectTool(InspectTool* inspect_tool) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment