Fix timing of when pending flags are reset.
Previously, the pending pause and play flags were reset in Animation::Update. The flags should be reset when the animation is ready (received start notification or stopped a running animation). This change will affect when Animation::pending() changes state from true to false. The next step is to reset these flags inside of play and pause tasks per spec, which requires further cleanup of the use of PlayStateUpdateScope. The following patch introduced a subtle bug to the timing of notifications to devtools > Animations, whereby the devtools notification could fire a start notification before the start time was received. https://chromium-review.googlesource.com/c/chromium/src/+/1822321 Fixing the timing of the pending task resets forces the devtools notification to sync with the start of the animation, which in turn undoes the faulty perf improvement seen in 1822321. Bug: 960944 Change-Id: Icbcf546614570e1936bec3db94facb1b5bfc4e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873905Reviewed-by:Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#715417}
Showing
Please register or sign in to comment