Skip to content

GitLab

T
tangled
Commit 7c942e47 authored by primiano's avatar primiano Committed by Commit bot
Browse files
Options

[tracing] Move GN/gyp build files under trace_event 

Move all trace_event related build files in their own
gyp / gn target under base/trace_event.
This should allow easier maintenance of tracing code.

BUG=

Review URL: https://codereview.chromium.org/1014923002

Cr-Commit-Position: refs/heads/master@{#321430}
parent 47c18b77
Hide whitespace changes
Inline Side-by-side
Showing with 82 additions and 53 deletions
base/BUILD.gn
View file @ 7c942e47
...@@ -1251,16 +1251,6 @@ test("base_unittests") { ...@@ -1251,16 +1251,6 @@ test("base_unittests") {
"timer/mock_timer_unittest.cc", "timer/mock_timer_unittest.cc",
"timer/timer_unittest.cc", "timer/timer_unittest.cc",
"tools_sanity_unittest.cc", "tools_sanity_unittest.cc",
"trace_event/memory_allocator_dump_unittest.cc",
"trace_event/memory_dump_manager_unittest.cc",
"trace_event/process_memory_maps_dump_provider_unittest.cc",
"trace_event/process_memory_totals_dump_provider_unittest.cc",
"trace_event/trace_event_argument_unittest.cc",
"trace_event/trace_event_memory_unittest.cc",
"trace_event/trace_event_synthetic_delay_unittest.cc",
"trace_event/trace_event_system_stats_monitor_unittest.cc",
"trace_event/trace_event_unittest.cc",
"trace_event/trace_event_win_unittest.cc",
"tracked_objects_unittest.cc", "tracked_objects_unittest.cc",
"tuple_unittest.cc", "tuple_unittest.cc",
"values_unittest.cc", "values_unittest.cc",
...@@ -1298,6 +1288,7 @@ test("base_unittests") { ...@@ -1298,6 +1288,7 @@ test("base_unittests") {
"//base/test:test_support", "//base/test:test_support",
"//base/third_party/dynamic_annotations", "//base/third_party/dynamic_annotations",
"//base/third_party/nspr", "//base/third_party/nspr",
"//base/trace_event:trace_event_unittests",
"//testing/gmock", "//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//third_party/icu", "//third_party/icu",
......
base/base.gyp
View file @ 7c942e47
...@@ -656,16 +656,6 @@ ...@@ -656,16 +656,6 @@
'timer/mock_timer_unittest.cc', 'timer/mock_timer_unittest.cc',
'timer/timer_unittest.cc', 'timer/timer_unittest.cc',
'tools_sanity_unittest.cc', 'tools_sanity_unittest.cc',
'trace_event/memory_allocator_dump_unittest.cc',
'trace_event/memory_dump_manager_unittest.cc',
'trace_event/process_memory_maps_dump_provider_unittest.cc',
'trace_event/process_memory_totals_dump_provider_unittest.cc',
'trace_event/trace_event_argument_unittest.cc',
'trace_event/trace_event_memory_unittest.cc',
'trace_event/trace_event_synthetic_delay_unittest.cc',
'trace_event/trace_event_system_stats_monitor_unittest.cc',
'trace_event/trace_event_unittest.cc',
'trace_event/trace_event_win_unittest.cc',
'tracked_objects_unittest.cc', 'tracked_objects_unittest.cc',
'tuple_unittest.cc', 'tuple_unittest.cc',
'values_unittest.cc', 'values_unittest.cc',
...@@ -690,6 +680,7 @@ ...@@ -690,6 +680,7 @@
'win/startup_information_unittest.cc', 'win/startup_information_unittest.cc',
'win/win_util_unittest.cc', 'win/win_util_unittest.cc',
'win/wrapped_window_proc_unittest.cc', 'win/wrapped_window_proc_unittest.cc',
'<@(trace_event_test_sources)',
], ],
'dependencies': [ 'dependencies': [
'base', 'base',
......
base/base.gypi
View file @ 7c942e47
...@@ -3,6 +3,9 @@ ...@@ -3,6 +3,9 @@
# found in the LICENSE file. # found in the LICENSE file.
{ {
'includes': [
'trace_event/trace_event.gypi',
],
'target_defaults': { 'target_defaults': {
'variables': { 'variables': {
'base_target': 0, 'base_target': 0,
...@@ -660,38 +663,6 @@ ...@@ -660,38 +663,6 @@
'timer/mock_timer.h', 'timer/mock_timer.h',
'timer/timer.cc', 'timer/timer.cc',
'timer/timer.h', 'timer/timer.h',
'trace_event/memory_allocator_attributes.h',
'trace_event/memory_allocator_dump.cc',
'trace_event/memory_allocator_dump.h',
'trace_event/memory_dump_manager.cc',
'trace_event/memory_dump_manager.h',
'trace_event/memory_dump_provider.cc',
'trace_event/memory_dump_provider.h',
'trace_event/process_memory_dump.cc',
'trace_event/process_memory_dump.h',
'trace_event/process_memory_maps.cc',
'trace_event/process_memory_maps.h',
'trace_event/process_memory_maps_dump_provider.cc',
'trace_event/process_memory_maps_dump_provider.h',
'trace_event/process_memory_totals.cc',
'trace_event/process_memory_totals.h',
'trace_event/process_memory_totals_dump_provider.cc',
'trace_event/process_memory_totals_dump_provider.h',
'trace_event/trace_event.h',
'trace_event/trace_event_android.cc',
'trace_event/trace_event_argument.cc',
'trace_event/trace_event_argument.h',
'trace_event/trace_event_impl.cc',
'trace_event/trace_event_impl.h',
'trace_event/trace_event_impl_constants.cc',
'trace_event/trace_event_memory.cc',
'trace_event/trace_event_memory.h',
'trace_event/trace_event_synthetic_delay.cc',
'trace_event/trace_event_synthetic_delay.h',
'trace_event/trace_event_system_stats_monitor.cc',
'trace_event/trace_event_system_stats_monitor.h',
'trace_event/trace_event_win.cc',
'trace_event/trace_event_win.h',
'tracked_objects.cc', 'tracked_objects.cc',
'tracked_objects.h', 'tracked_objects.h',
'tracking_info.cc', 'tracking_info.cc',
...@@ -754,6 +725,7 @@ ...@@ -754,6 +725,7 @@
'win/windows_version.h', 'win/windows_version.h',
'win/wrapped_window_proc.cc', 'win/wrapped_window_proc.cc',
'win/wrapped_window_proc.h', 'win/wrapped_window_proc.h',
'<@(trace_event_sources)',
], ],
'defines': [ 'defines': [
'BASE_IMPLEMENTATION', 'BASE_IMPLEMENTATION',
......
base/trace_event/BUILD.gn
View file @ 7c942e47
# Copyright (c) 2015 The Chromium Authors. All rights reserved. # Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
...@@ -63,3 +63,25 @@ source_set("trace_event") { ...@@ -63,3 +63,25 @@ source_set("trace_event") {
visibility = [ "//base/*" ] visibility = [ "//base/*" ]
} }
source_set("trace_event_unittests") {
testonly = true
sources = [
"memory_allocator_dump_unittest.cc",
"memory_dump_manager_unittest.cc",
"process_memory_maps_dump_provider_unittest.cc",
"process_memory_totals_dump_provider_unittest.cc",
"trace_event_argument_unittest.cc",
"trace_event_memory_unittest.cc",
"trace_event_synthetic_delay_unittest.cc",
"trace_event_system_stats_monitor_unittest.cc",
"trace_event_unittest.cc",
"trace_event_win_unittest.cc",
]
deps = [
"//base/test:test_support",
"//testing/gmock",
"//testing/gtest",
]
}
base/trace_event/trace_event.gypi 0 → 100644
View file @ 7c942e47
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'variables': {
'trace_event_sources' : [
'trace_event/memory_allocator_attributes.h',
'trace_event/memory_allocator_dump.cc',
'trace_event/memory_allocator_dump.h',
'trace_event/memory_dump_manager.cc',
'trace_event/memory_dump_manager.h',
'trace_event/memory_dump_provider.cc',
'trace_event/memory_dump_provider.h',
'trace_event/process_memory_dump.cc',
'trace_event/process_memory_dump.h',
'trace_event/process_memory_maps.cc',
'trace_event/process_memory_maps.h',
'trace_event/process_memory_maps_dump_provider.cc',
'trace_event/process_memory_maps_dump_provider.h',
'trace_event/process_memory_totals.cc',
'trace_event/process_memory_totals.h',
'trace_event/process_memory_totals_dump_provider.cc',
'trace_event/process_memory_totals_dump_provider.h',
'trace_event/trace_event.h',
'trace_event/trace_event_android.cc',
'trace_event/trace_event_argument.cc',
'trace_event/trace_event_argument.h',
'trace_event/trace_event_impl.cc',
'trace_event/trace_event_impl.h',
'trace_event/trace_event_impl_constants.cc',
'trace_event/trace_event_memory.cc',
'trace_event/trace_event_memory.h',
'trace_event/trace_event_synthetic_delay.cc',
'trace_event/trace_event_synthetic_delay.h',
'trace_event/trace_event_system_stats_monitor.cc',
'trace_event/trace_event_system_stats_monitor.h',
'trace_event/trace_event_win.cc',
'trace_event/trace_event_win.h',
],
'trace_event_test_sources' : [
'trace_event/memory_allocator_dump_unittest.cc',
'trace_event/memory_dump_manager_unittest.cc',
'trace_event/process_memory_maps_dump_provider_unittest.cc',
'trace_event/process_memory_totals_dump_provider_unittest.cc',
'trace_event/trace_event_argument_unittest.cc',
'trace_event/trace_event_memory_unittest.cc',
'trace_event/trace_event_synthetic_delay_unittest.cc',
'trace_event/trace_event_system_stats_monitor_unittest.cc',
'trace_event/trace_event_unittest.cc',
'trace_event/trace_event_win_unittest.cc',
],
},
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment