Commit 7c999198 authored by Peter Wen's avatar Peter Wen Committed by Commit Bot

Android: Use the link pool for android_lint

Lint can use a good amount of RAM for generating build graphs for its
checks. Use the same pool as linking/proguarding to avoid bot OOMs.

e.g. chrome_modern_public_apk__lint's lint call takes about 1.7GB
  /usr/bin/time -v lint_cmd...
  Maximum resident set size (kbytes): 1679060

This should not affect local builds since usually only one lint task is
run (while building a single apk/app_bundle).

Bug: 1098333,1098752
Change-Id: I921642f01b31f08ae2b6524da737072a63bc09c0
Fixed: 1098333,1098752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264454Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781892}
parent 4e2d3aec
...@@ -912,6 +912,9 @@ if (enable_java_templates) { ...@@ -912,6 +912,9 @@ if (enable_java_templates) {
deps = [] deps = []
} }
# https://crbug.com/1098752 Fix for bot OOM (https://crbug.com/1098333).
pool = "//build/toolchain:link_pool($default_toolchain)"
# Lint only requires generated sources and generated resources from the # Lint only requires generated sources and generated resources from the
# build. Since turbine __header targets already depend on and generate all # build. Since turbine __header targets already depend on and generate all
# the generated sources, and the __assetres targets include all generated # the generated sources, and the __assetres targets include all generated
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment