PDF Viewer update: Add aria-expanded attribute to the menu button.

Fixed: 1132421
Change-Id: I7d3e3261fcd35a27bc0da0338a5c1182adca7378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431574
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811274}

chrome/browser/resources/pdf/elements/viewer-pdf-toolbar-new.html

@@ -173,6 +173,7 @@
   <div id="start">
     <cr-icon-button id="sidenavToggle" iron-icon="cr20:menu"
         title="$i18n{menu}" aria-label="$i18n{menu}"
+        aria-expanded$="[[getAriaExpanded_(sidenavCollapsed)]]"
 <if expr="chromeos">
         disabled="[[annotationMode]]"
 </if>

chrome/browser/resources/pdf/elements/viewer-pdf-toolbar-new.js

@@ -76,6 +76,7 @@ export class ViewerPdfToolbarNewElement extends PolymerElement {
         observer: 'viewportZoomChanged_',
       },
 
+      sidenavCollapsed: Boolean,
       twoUpViewEnabled: Boolean,
 
       moreMenuOpen_: {
@@ -111,6 +112,9 @@ export class ViewerPdfToolbarNewElement extends PolymerElement {
   constructor() {
     super();
 
+    /** @type {boolean} */
+    this.sidenavCollapsed = false;
+
     /** @private {!FittingType} */
     this.fittingType_ = FittingType.FIT_TO_PAGE;
 
@@ -230,6 +234,11 @@ export class ViewerPdfToolbarNewElement extends PolymerElement {
     return checked ? 'true' : 'false';
   }
 
+  /** @return {string} */
+  getAriaExpanded_() {
+    return this.sidenavCollapsed ? 'false' : 'true';
+  }
+
   /** @private */
   toggleTwoPageViewClick_() {
     const newTwoUpViewEnabled = !this.twoUpViewEnabled;

chrome/browser/resources/pdf/pdf_viewer.html

@@ -158,6 +158,7 @@
     pdf-form-save-enabled="[[pdfFormSaveEnabled_]]"
     printing-enabled="[[printingEnabled_]]" rotated="[[rotated_]]"
     is-form-field-focused="[[isFormFieldFocused_]]"
+    sidenav-collapsed="[[sidenavCollapsed_]]"
     two-up-view-enabled="[[twoUpViewEnabled_]]"
     viewport-zoom="[[viewportZoom_]]"
 <if expr="chromeos">

chrome/browser/resources/pdf/pdf_viewer.js

@@ -141,6 +141,7 @@ export class PDFViewerElement extends PDFViewerBaseElement {
 
       title_: String,
 
+      sidenavCollapsed_: Boolean,
       twoUpViewEnabled_: Boolean,
 
       isFormFieldFocused_: Boolean,

chrome/test/data/pdf/viewer_pdf_toolbar_new_test.js

@@ -232,9 +232,18 @@ const tests = [
 
   function testSidenavToggleButton() {
     const toolbar = createToolbar();
+    chrome.test.assertFalse(toolbar.sidenavCollapsed);
+
+    const toggleButton = toolbar.shadowRoot.querySelector('#sidenavToggle');
+    chrome.test.assertTrue(toggleButton.hasAttribute('aria-label'));
+    chrome.test.assertTrue(toggleButton.hasAttribute('title'));
+    chrome.test.assertEq('true', toggleButton.getAttribute('aria-expanded'));
+
+    toolbar.sidenavCollapsed = true;
+    chrome.test.assertEq('false', toggleButton.getAttribute('aria-expanded'));
+
     toolbar.addEventListener(
         'sidenav-toggle-click', () => chrome.test.succeed());
-    const toggleButton = toolbar.shadowRoot.querySelector('#sidenavToggle');
     toggleButton.click();
   },
 ];