Skip to content

GitLab

T
tangled
Commit 7caea30f authored by lushnikov@chromium.org's avatar lushnikov@chromium.org
Browse files
Options

Revert of DevTools: even more logging for... 

Revert of DevTools: even more logging for jump-to-previous-editing-location.html test (https://codereview.chromium.org/298723005/)

Reason for revert:
Looks like test is not accidentally failing any more during last week. Reverting this debugging patch

Original issue's description:
> DevTools: even more logging for jump-to-previous-editing-location.html test
> 
> Follow-up to r174282 to add some more logging into the test to figure out
> why the test fails from time to time. The core problem seems to be due to
> inconsistency in SimpleHistoryManager.
> The patch be reverted after the reason will be determined.
> 
> BUG=361588
> TBR=vsevik
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174502

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=361588

Review URL: https://codereview.chromium.org/304303004

git-svn-id: svn://svn.chromium.org/blink/trunk@175113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 1451e1c6
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 61 deletions
third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location-expected.txt
View file @ 7caea30f
......@@ -51,6 +51,7 @@ Running: testCrossFileJump
<Rolled over> line: 11 column: 1 [workspace-test.js]
Running: testCloseCrossFile
executed SimpleHistoryManager.filterOut; activeEntryIndex = 7
<Close active tab> line: 9 column: 4 [example-fileset-for-test.js]
<Rolled back> line: 9 column: 0 [example-fileset-for-test.js]
<Rolled over> line: 9 column: 4 [example-fileset-for-test.js]
......@@ -69,65 +70,25 @@ entries count: 8 active entry index: 7
entry[1] = {line: 7, column: 26}
entry[0] = {line: 2, column: 0}
=== ===
SimpleHistoryManager.active size: 8 active: 7
SimpleHistoryManager.push size: 9 active: 8
<Mouse click (10, 7)> line: 10 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 9 active: 8
SimpleHistoryManager.push size: 10 active: 9
<Mouse click (11, 7)> line: 11 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 10 active: 9
SimpleHistoryManager.push size: 11 active: 10
<Mouse click (12, 7)> line: 12 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 11 active: 10
SimpleHistoryManager.push size: 12 active: 11
<Mouse click (13, 7)> line: 13 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 12 active: 11
SimpleHistoryManager.push size: 13 active: 12
<Mouse click (14, 7)> line: 14 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 13 active: 12
SimpleHistoryManager.push size: 14 active: 13
<Mouse click (15, 7)> line: 15 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 14 active: 13
SimpleHistoryManager.push size: 15 active: 14
<Mouse click (16, 7)> line: 16 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 15 active: 14
SimpleHistoryManager.push size: 16 active: 15
<Mouse click (17, 7)> line: 17 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 16 active: 15
SimpleHistoryManager.push size: 17 active: 16
<Mouse click (18, 7)> line: 18 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 17 active: 16
SimpleHistoryManager.push size: 18 active: 17
<Mouse click (19, 7)> line: 19 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 18 active: 17
SimpleHistoryManager.push size: 19 active: 18
<Mouse click (20, 7)> line: 20 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 19 active: 18
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (21, 7)> line: 21 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (22, 7)> line: 22 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (23, 7)> line: 23 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (24, 7)> line: 24 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (25, 7)> line: 25 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (26, 7)> line: 26 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (27, 7)> line: 27 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (28, 7)> line: 28 column: 7 [example-fileset-for-test.js]
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
<Mouse click (29, 7)> line: 29 column: 7 [example-fileset-for-test.js]
=== SimpleHistoryManager state after filling history stack ===
entries count: 20 active entry index: 19
......@@ -152,10 +113,6 @@ entries count: 20 active entry index: 19
entry[1] = {line: 11, column: 7}
entry[0] = {line: 10, column: 7}
=== ===
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.active size: 20 active: 19
SimpleHistoryManager.push size: 20 active: 19
SimpleHistoryManager.rollback size: 20 active: 18
First rollback result: true
=== SimpleHistoryManager state after first rollback ===
entries count: 20 active entry index: 18
......
third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html
View file @ 7caea30f
......@@ -13,19 +13,9 @@ function test()
var sourcesView = panel._sourcesView;
var historyManager = sourcesView._historyManager;
var editorContainer = sourcesView._editorContainer;
var shouldLogSimpleHistoryManager = false;
function logSimpleHistoryManagerMethod(methodName)
{
if (!shouldLogSimpleHistoryManager)
return;
InspectorTest.addResult("SimpleHistoryManager." + methodName + " size: " + historyManager._historyManager._entries.length + " active: " + historyManager._historyManager._activeEntryIndex);
}
InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "push", logSimpleHistoryManagerMethod.bind(null, "push"), true);
InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "active", logSimpleHistoryManagerMethod.bind(null, "active"), true);
InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "rollback", logSimpleHistoryManagerMethod.bind(null, "rollback"), true);
InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "rollover", logSimpleHistoryManagerMethod.bind(null, "rollover"), true);
InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "filterOut", logSimpleHistoryManagerMethod.bind(null, "filterOut"), true);
InspectorTest.addSniffer(historyManager._historyManager, "filterOut", function() {
InspectorTest.addResult("executed SimpleHistoryManager.filterOut; activeEntryIndex = " + historyManager._historyManager._activeEntryIndex);
}, true);
function rollback()
{
......@@ -60,7 +50,7 @@ function test()
dumpSelection(editor, "Mouse click (" + lineNumber + ", " + columnNumber + ")");
}
function clickAndDump(editor, lines, columns, logLocation)
function clickAndDump(editor, lines, columns)
{
for (var i = 0; i < lines.length; ++i) {
var lineNumber = lines[i];
......@@ -214,15 +204,13 @@ function test()
var editor = panel.visibleView.textEditor;
//FIXME(lushnikov): here and below excessive dumping to figure out a reason for
// unreproducible bot failures.
shouldLogSimpleHistoryManager = true;
dumpSimpleHistoryManagerState("before filling history stack");
clickAndDump(editor, lines, columns, true);
clickAndDump(editor, lines, columns);
dumpSimpleHistoryManagerState("after filling history stack");
InspectorTest.addResult("First rollback result: " + historyManager._historyManager.rollback());
dumpSimpleHistoryManagerState("after first rollback");
dumpSelection(editor, "Rolled back");
shouldLogSimpleHistoryManager = false;
for (var i = 0; i < jumpsAmount - 1; ++i) {
rollback();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment