Make ApplicationImpl::args() be a std::vector<std::string>

BUG=

Review URL: https://codereview.chromium.org/657393003

Cr-Commit-Position: refs/heads/master@{#300033}

mojo/application_manager/application_manager_unittest.cc

@@ -108,9 +108,7 @@ class TestApplicationLoader : public ApplicationLoader,
 
   void set_context(TestContext* context) { context_ = context; }
   int num_loads() const { return num_loads_; }
-  std::vector<std::string> GetArgs() {
-    return test_app_->args().To<std::vector<std::string> >();
-  }
+  const std::vector<std::string>& GetArgs() { return test_app_->args(); }
 
  private:
   // ApplicationLoader implementation.

mojo/examples/apptest/example_apptest.cc

@@ -97,7 +97,7 @@ MojoResult MojoMain(MojoHandle shell_handle) {
   {
     // InitGoogleTest expects (argc + 1) elements, including a terminating NULL.
     // It also removes GTEST arguments from |argv| and updates the |argc| count.
-    const mojo::Array<mojo::String>& args = app.args();
+    const std::vector<std::string>& args = app.args();
     MOJO_CHECK(args.size() < INT_MAX);
     int argc = static_cast<int>(args.size());
     std::vector<char*> argv(argc + 1);

mojo/examples/wget/wget.cc

@@ -76,8 +76,8 @@ class WGetApp : public ApplicationDelegate {
   }
 
  private:
-  void Start(const Array<String>& args) {
-    std::string url((args.size() > 1) ? args[1].get() : PromptForURL());
+  void Start(const std::vector<std::string>& args) {
+    std::string url((args.size() > 1) ? args[1] : PromptForURL());
     printf("Loading: %s\n", url.c_str());
 
     network_service_->CreateURLLoader(GetProxy(&url_loader_));

mojo/public/cpp/application/application_impl.h

@@ -60,7 +60,7 @@ class ApplicationImpl : public InterfaceImpl<Application> {
   Shell* shell() const { return shell_.get(); }
 
   // Returns any initial configuration arguments, passed by the Shell.
-  const Array<String>& args() { return args_; }
+  const std::vector<std::string>& args() { return args_; }
 
   // Establishes a new connection to an application. Caller does not own.
   ApplicationConnection* ConnectToApplication(const String& application_url);
@@ -102,7 +102,7 @@ class ApplicationImpl : public InterfaceImpl<Application> {
   ApplicationDelegate* delegate_;
   ShellPtr shell_;
   ShellPtrWatcher* shell_watch_;
-  Array<String> args_;
+  std::vector<std::string> args_;
 
   MOJO_DISALLOW_COPY_AND_ASSIGN(ApplicationImpl);
 };

mojo/public/cpp/application/lib/application_impl.cc

@@ -57,7 +57,7 @@ ApplicationImpl::~ApplicationImpl() {
 void ApplicationImpl::Initialize(Array<String> args) {
   MOJO_CHECK(!initialized_);
   initialized_ = true;
-  args_ = args.Pass();
+  args_ = args.To<std::vector<std::string>>();
   delegate_->Initialize(this);
 }
 

mojo/services/native_viewport/main.cc

@@ -32,13 +32,13 @@ class NativeViewportAppDelegate
 
  private:
   bool HasArg(const std::string& arg) {
-    return std::find(args_.begin(), args_.end(), arg) != args_.end();
+    const auto& args = app_->args();
+    return std::find(args.begin(), args.end(), arg) != args.end();
   }
 
   // ApplicationDelegate implementation.
   virtual void Initialize(ApplicationImpl* application) override {
     app_ = application;
-    args_ = application->args().To<std::vector<std::string> >();
 
 #if !defined(COMPONENT_BUILD)
     if (HasArg(kUseTestConfig))
@@ -70,7 +70,6 @@ class NativeViewportAppDelegate
   }
 
   ApplicationImpl* app_;
-  std::vector<std::string> args_;
   scoped_refptr<gfx::GLShareGroup> share_group_;
   scoped_refptr<gpu::gles2::MailboxManager> mailbox_manager_;
   bool is_headless_;