Commit 7ccc4b52 authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

Migrate off BrowserThread::DeleteSoon in /content/browser/host_zoom_level_context.cc

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=wjmaclean@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I08632c1a3a1b69fec27fa626b6d35b61da6bfe2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895641Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712431}
parent 59e7f643
......@@ -7,7 +7,9 @@
#include <utility>
#include "base/files/file_path.h"
#include "base/task/post_task.h"
#include "content/browser/host_zoom_map_impl.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
namespace content {
......@@ -25,7 +27,7 @@ HostZoomLevelContext::~HostZoomLevelContext() {}
void HostZoomLevelContext::DeleteOnCorrectThread() const {
if (BrowserThread::IsThreadInitialized(BrowserThread::UI) &&
!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this);
base::DeleteSoon(FROM_HERE, {BrowserThread::UI}, this);
return;
}
delete this;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment