Commit 7ce49e6c authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

mac: Re-enable PermissionBubbleInteractiveUITest.*

The tests seem to pass now.

Bug: 630357,845389
Change-Id: I7e74c1a41f578dc70866d533742e36bafb787f63
Reviewed-on: https://chromium-review.googlesource.com/1251327Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595617}
parent 63824797
...@@ -23,22 +23,7 @@ ...@@ -23,22 +23,7 @@
#include "ui/base/ui_base_features.h" #include "ui/base/ui_base_features.h"
#import "ui/events/test/cocoa_test_event_utils.h" #import "ui/events/test/cocoa_test_event_utils.h"
namespace { class PermissionBubbleInteractiveUITest : public InProcessBrowserTest {
enum class UiMode {
VIEWS,
};
std::string UiModeToString(const ::testing::TestParamInfo<UiMode>& info) {
return "Views";
}
} // namespace
// TODO(crbug.com/630357): Remove parameterized testing for this class.
class PermissionBubbleInteractiveUITest
: public InProcessBrowserTest,
public ::testing::WithParamInterface<UiMode> {
public: public:
PermissionBubbleInteractiveUITest() {} PermissionBubbleInteractiveUITest() {}
...@@ -100,9 +85,7 @@ class PermissionBubbleInteractiveUITest ...@@ -100,9 +85,7 @@ class PermissionBubbleInteractiveUITest
}; };
// There is only one tab. Cmd+w will close it along with the browser window. // There is only one tab. Cmd+w will close it along with the browser window.
// TDOO(thakis): Reenable this once this test tests views. IN_PROC_BROWSER_TEST_F(PermissionBubbleInteractiveUITest, CmdWClosesWindow) {
IN_PROC_BROWSER_TEST_P(PermissionBubbleInteractiveUITest,
DISABLED_CmdWClosesWindow) {
base::scoped_nsobject<NSWindow> browser_window( base::scoped_nsobject<NSWindow> browser_window(
browser()->window()->GetNativeWindow(), base::scoped_policy::RETAIN); browser()->window()->GetNativeWindow(), base::scoped_policy::RETAIN);
EXPECT_TRUE([browser_window isVisible]); EXPECT_TRUE([browser_window isVisible]);
...@@ -120,9 +103,7 @@ IN_PROC_BROWSER_TEST_P(PermissionBubbleInteractiveUITest, ...@@ -120,9 +103,7 @@ IN_PROC_BROWSER_TEST_P(PermissionBubbleInteractiveUITest,
// Add a tab, ensure we can switch away and back using Cmd+Alt+Left/Right and // Add a tab, ensure we can switch away and back using Cmd+Alt+Left/Right and
// curly braces. // curly braces.
// Disabled. See https://crbug.com/845389 - this regressed somewhere between IN_PROC_BROWSER_TEST_F(PermissionBubbleInteractiveUITest, SwitchTabs) {
// r545258 and r559030, but it may be obsolete soon.
IN_PROC_BROWSER_TEST_P(PermissionBubbleInteractiveUITest, DISABLED_SwitchTabs) {
NSWindow* browser_window = browser()->window()->GetNativeWindow(); NSWindow* browser_window = browser()->window()->GetNativeWindow();
EXPECT_EQ(0, browser()->tab_strip_model()->active_index()); EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
...@@ -180,8 +161,3 @@ IN_PROC_BROWSER_TEST_P(PermissionBubbleInteractiveUITest, DISABLED_SwitchTabs) { ...@@ -180,8 +161,3 @@ IN_PROC_BROWSER_TEST_P(PermissionBubbleInteractiveUITest, DISABLED_SwitchTabs) {
EnsureWindowActive(browser_window, "switch away with curly brace"); EnsureWindowActive(browser_window, "switch away with curly brace");
EXPECT_FALSE(test_api_->GetPromptWindow()); EXPECT_FALSE(test_api_->GetPromptWindow());
} }
INSTANTIATE_TEST_CASE_P(,
PermissionBubbleInteractiveUITest,
::testing::Values(UiMode::VIEWS),
&UiModeToString);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment