[ios] Check if badge should be marked accepted before calling delegate

The translate badge should not be marked as accepted until the translate
has finished, not immediately when the action button in the banner is
tapped. A InfobarCoordinatorImplementation method isInfobarAccepted
will allow specific Infobars to decide whether to call infobarWasAccepted:
when the button is tapped.

Bug: 1014959
Change-Id: I544395077845dd89c9909afe38a11801df5fbf40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872759
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708904}

ios/chrome/browser/ui/infobars/coordinators/infobar_confirm_coordinator.mm

@@ -89,6 +89,10 @@
   return YES;
 }
 
+- (BOOL)isInfobarAccepted {
+  return NO;
+}
+
 - (void)infobarBannerWasPresented {
   // NO-OP.
 }

ios/chrome/browser/ui/infobars/coordinators/infobar_coordinator.mm

@@ -201,8 +201,10 @@ const CGFloat kiPadBannerOverlapWithOmnibox = 10.0;
 
 - (void)bannerInfobarButtonWasPressed:(id)sender {
   [self performInfobarAction];
-  [self.badgeDelegate infobarWasAccepted:self.infobarType
-                             forWebState:self.webState];
+  if ([self isInfobarAccepted]) {
+    [self.badgeDelegate infobarWasAccepted:self.infobarType
+                               forWebState:self.webState];
+  }
   [self dismissInfobarBanner:sender animated:YES completion:nil];
 }
 
@@ -350,6 +352,11 @@ const CGFloat kiPadBannerOverlapWithOmnibox = 10.0;
   return NO;
 }
 
+- (BOOL)isInfobarAccepted {
+  NOTREACHED() << "Subclass must implement.";
+  return NO;
+}
+
 - (void)infobarBannerWasPresented {
   NOTREACHED() << "Subclass must implement.";
 }

ios/chrome/browser/ui/infobars/coordinators/infobar_coordinator_implementation.h

@@ -17,6 +17,11 @@
 // successfully. If it returns NO no Modal should be presented.
 - (BOOL)configureModalViewController;
 
+// Returns YES if the Infobar action was completed successfully. Useful for
+// Infobar actions that finish asynchronously to delay marking the Infobar as
+// accepted.
+- (BOOL)isInfobarAccepted;
+
 // Performs any actions related to an Infobar Banner presentation.
 - (void)infobarBannerWasPresented;
 

ios/chrome/browser/ui/infobars/coordinators/infobar_password_coordinator.mm

@@ -149,6 +149,10 @@
   return YES;
 }
 
+- (BOOL)isInfobarAccepted {
+  return YES;
+}
+
 - (void)infobarBannerWasPresented {
   // There's a chance the Delegate was destroyed while the presentation was
   // taking place e.g. User navigated away. Check if the delegate still exists.

ios/chrome/browser/ui/infobars/coordinators/infobar_save_card_coordinator.mm

@@ -84,6 +84,10 @@
 
 #pragma mark - InfobarCoordinatorImplementation
 
+- (BOOL)isInfobarAccepted {
+  return YES;
+}
+
 - (void)performInfobarAction {
   if (self.saveCardInfoBarDelegate->upload()) {
     // TODO(crbug.com/1014652): Open Modal if CreditCard details will be

ios/chrome/browser/ui/infobars/coordinators/infobar_translate_coordinator.mm

@@ -32,6 +32,9 @@
 // InfobarBannerViewController owned by this Coordinator.
 @property(nonatomic, strong) InfobarBannerViewController* bannerViewController;
 
+// The current state of translate.
+@property(nonatomic, assign) translate::TranslateStep currentStep;
+
 // Tracks user actions taken throughout Translate lifetime.
 @property(nonatomic, assign) UserAction userAction;
 
@@ -52,6 +55,7 @@
         std::make_unique<TranslateInfobarDelegateObserverBridge>(
             infoBarDelegate, self);
     _userAction = UserActionNone;
+    _currentStep = translate::TranslateStep::TRANSLATE_STEP_BEFORE_TRANSLATE;
   }
   return self;
 }
@@ -61,7 +65,8 @@
 - (void)translateInfoBarDelegate:(translate::TranslateInfoBarDelegate*)delegate
           didChangeTranslateStep:(translate::TranslateStep)step
                    withErrorType:(translate::TranslateErrors::Type)errorType {
-  // TODO(crbug.com/1014959): implement
+  // TODO(crbug.com/1014959): Update currentStep and call
+  // infobarWasAccepted:forWebState: if translate finished.
 }
 
 - (BOOL)translateInfoBarDelegateDidDismissWithoutInteraction:
@@ -100,6 +105,11 @@
 
 #pragma mark - InfobarCoordinatorImplementation
 
+- (BOOL)shouldBadgeBeAccepted {
+  return self.currentStep ==
+         translate::TranslateStep::TRANSLATE_STEP_AFTER_TRANSLATE;
+}
+
 - (void)performInfobarAction {
   self.userAction |= UserActionTranslate;