Commit 7cfbc823 authored by Nicolás Peña Moreno's avatar Nicolás Peña Moreno Committed by Commit Bot

Mark base::BindRepeating explicitly in SandboxStatusExtension

AddInterface() uses base::BindRepeating, so the input object must be a
base::BindRepeating, and it seems that it can be called multiple times
based on the comment here:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/common/sandbox_status_extension_android.mojom;l=11

Similarly, CreateFunctionTemplate() receives a repeating callback, and
it is reasonable to allow getAndroidSandboxStatus to be called multiple
times.

Bug: 1007641
Change-Id: I3103b1e4ca8f5d6064c4b2c74d19cb9aad01fed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107705
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: default avatarBo <boliu@chromium.org>
Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751102}
parent 6ade5dc4
...@@ -31,9 +31,9 @@ SandboxStatusExtension::SandboxStatusExtension(content::RenderFrame* frame) ...@@ -31,9 +31,9 @@ SandboxStatusExtension::SandboxStatusExtension(content::RenderFrame* frame)
// Don't do anything else for subframes. // Don't do anything else for subframes.
if (!frame->IsMainFrame()) if (!frame->IsMainFrame())
return; return;
frame->GetAssociatedInterfaceRegistry()->AddInterface( frame->GetAssociatedInterfaceRegistry()->AddInterface(base::BindRepeating(
base::Bind(&SandboxStatusExtension::OnSandboxStatusExtensionRequest, &SandboxStatusExtension::OnSandboxStatusExtensionRequest,
base::RetainedRef(this))); base::RetainedRef(this)));
} }
SandboxStatusExtension::~SandboxStatusExtension() {} SandboxStatusExtension::~SandboxStatusExtension() {}
...@@ -81,7 +81,8 @@ void SandboxStatusExtension::Install() { ...@@ -81,7 +81,8 @@ void SandboxStatusExtension::Install() {
v8::Local<v8::Function> function; v8::Local<v8::Function> function;
bool success = bool success =
gin::CreateFunctionTemplate( gin::CreateFunctionTemplate(
isolate, base::Bind(&SandboxStatusExtension::GetSandboxStatus, this)) isolate,
base::BindRepeating(&SandboxStatusExtension::GetSandboxStatus, this))
->GetFunction(context) ->GetFunction(context)
.ToLocal(&function); .ToLocal(&function);
if (success) { if (success) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment