Commit 7d0f5ee4 authored by Pete Williamson's avatar Pete Williamson Committed by Chromium LUCI CQ

Set the FeedEngagementType histogram to never expire.

This histogram is reaching its expiration date, and we realized that
we will need it as long as we have a feed.  After a quick discussion
with the team, we decided to change it to never expire.

Bug: 1167830
Change-Id: I4740a4f76c6ebc285792d803af66a4aac7dd68c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643361Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarDan H <harringtond@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845893}
parent 8f402af9
...@@ -719,7 +719,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -719,7 +719,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="ContentSuggestions.Feed.EngagementType" <histogram name="ContentSuggestions.Feed.EngagementType"
enum="FeedEngagementType" expires_after="2021-03-01"> enum="FeedEngagementType" expires_after="never">
<!-- expires-never: key feature metric. We will need the Engagement
type as long as we have a feed, and it will be removed with the
feed code if the feed is ever removed. -->
<owner>petewil@chromium.org</owner> <owner>petewil@chromium.org</owner>
<owner>harringtond@chromium.org</owner> <owner>harringtond@chromium.org</owner>
<owner>feed@chromium.org</owner> <owner>feed@chromium.org</owner>
......
...@@ -306,7 +306,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -306,7 +306,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.ContentSuggestions.Opened" units="index" <histogram name="NewTabPage.ContentSuggestions.Opened" units="index"
expires_after="2021-07-01"> expires_after="never">
<!-- expires-never: key feature metric. We will need the Opened
metric as long as we have a feed, and it will be removed with the
feed code if the feed is ever removed. -->
<owner>freedjm@chromium.org</owner> <owner>freedjm@chromium.org</owner>
<owner>feed@chromium.org</owner> <owner>feed@chromium.org</owner>
<summary> <summary>
...@@ -396,7 +400,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -396,7 +400,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.ContentSuggestions.Shown" units="index" <histogram name="NewTabPage.ContentSuggestions.Shown" units="index"
expires_after="2021-07-01"> expires_after="never">
<!-- expires-never: key feature metric. We will need the Shown
metric as long as we have a feed, and it will be removed with
the feed code if the feed is ever removed. -->
<owner>freedjm@chromium.org</owner> <owner>freedjm@chromium.org</owner>
<owner>feed@chromium.org</owner> <owner>feed@chromium.org</owner>
<summary> <summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment