Remove remnants of the media-devtools experiment

It's been launched and on by default for a while now. Just noticed there
were some references to it laying around, so this cleans them up.

Change-Id: I9cd0a509a28c778e3efb92b9617a6c8948764017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467008
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816722}

content/renderer/media/media_factory.cc

@@ -402,11 +402,8 @@ blink::WebMediaPlayer* MediaFactory::CreateMediaPlayer(
 
   std::vector<std::unique_ptr<BatchingMediaLog::EventHandler>> handlers;
   handlers.push_back(std::make_unique<RenderMediaEventHandler>());
-
-  if (base::FeatureList::IsEnabled(media::kMediaInspectorLogging)) {
-    handlers.push_back(
-        std::make_unique<InspectorMediaEventHandler>(inspector_context));
-  }
+  handlers.push_back(
+      std::make_unique<InspectorMediaEventHandler>(inspector_context));
 
   // This must be created for every new WebMediaPlayer, each instance generates
   // a new player id which is used to collate logs on the browser side.
@@ -699,11 +696,8 @@ blink::WebMediaPlayer* MediaFactory::CreateWebMediaPlayerForMediaStream(
 
   std::vector<std::unique_ptr<BatchingMediaLog::EventHandler>> handlers;
   handlers.push_back(std::make_unique<RenderMediaEventHandler>());
-
-  if (base::FeatureList::IsEnabled(media::kMediaInspectorLogging)) {
-    handlers.push_back(
-        std::make_unique<InspectorMediaEventHandler>(inspector_context));
-  }
+  handlers.push_back(
+      std::make_unique<InspectorMediaEventHandler>(inspector_context));
 
   // This must be created for every new WebMediaPlayer, each instance generates
   // a new player id which is used to collate logs on the browser side.

media/base/media_switches.cc

@@ -740,10 +740,6 @@ const base::Feature kMediaFeedsBackgroundFetching{
 const base::Feature kMediaFeedsSafeSearch{"MediaFeedsSafeSearch",
                                           base::FEATURE_ENABLED_BY_DEFAULT};
 
-// Send events to devtools rather than to chrome://media-internals
-const base::Feature kMediaInspectorLogging{"MediaInspectorLogging",
-                                           base::FEATURE_ENABLED_BY_DEFAULT};
-
 // Enables experimental local learning for media. Used in the context of media
 // capabilities only. Adds reporting only; does not change media behavior.
 const base::Feature kMediaLearningExperiment{"MediaLearningExperiment",

media/base/media_switches.h

@@ -153,7 +153,6 @@ MEDIA_EXPORT extern const base::Feature kMediaEngagementHTTPSOnly;
 MEDIA_EXPORT extern const base::Feature kMediaFeeds;
 MEDIA_EXPORT extern const base::Feature kMediaFeedsBackgroundFetching;
 MEDIA_EXPORT extern const base::Feature kMediaFeedsSafeSearch;
-MEDIA_EXPORT extern const base::Feature kMediaInspectorLogging;
 MEDIA_EXPORT extern const base::Feature kMediaLearningExperiment;
 MEDIA_EXPORT extern const base::Feature kMediaLearningFramework;
 MEDIA_EXPORT extern const base::Feature kMediaLearningSmoothnessExperiment;

third_party/blink/web_tests/VirtualTestSuites

@@ -686,11 +686,6 @@
     "bases": [ "js/weakrefs" ],
     "args": [ "--js-flags=--harmony-weak-refs" ]
   },
-  {
-    "prefix": "media-devtools",
-    "bases": [ "inspector-protocol/media" ],
-    "args": ["--enable-features=MediaInspectorLogging"]
-  },
   {
     "prefix": "link-disabled-old-behavior",
     "bases": [ "external/wpt/css/cssom" ],

third_party/blink/web_tests/virtual/media-devtools/inspector-protocol/media/README.txt

-# This suite runs the tests in inspector-protocol/media
-# with --enable-features=MediaInspectorLogging