Commit 7d314666 authored by rnephew's avatar rnephew Committed by Commit Bot

[Telemetry] Move memory benchmarks to StoryExpectations.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I08457ceba85b7449c7809bf06983b1c3da5965eb
Reviewed-on: https://chromium-review.googlesource.com/539819Reviewed-by: default avatarrnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480542}
parent 1623f261
...@@ -83,6 +83,9 @@ class MemoryBenchmarkTrivialSitesDesktop(_MemoryInfra): ...@@ -83,6 +83,9 @@ class MemoryBenchmarkTrivialSitesDesktop(_MemoryInfra):
# is able to cope with the data load generated by TBMv2 metrics. # is able to cope with the data load generated by TBMv2 metrics.
return not _IGNORED_STATS_RE.search(value.name) return not _IGNORED_STATS_RE.search(value.name)
def GetExpectations(self):
return page_sets.TrivialSitesMemoryStoryExpectations()
@benchmark.Enabled('android') # catapult:#3176 @benchmark.Enabled('android') # catapult:#3176
@benchmark.Owner(emails=['perezju@chromium.org']) @benchmark.Owner(emails=['perezju@chromium.org'])
...@@ -109,6 +112,9 @@ class MemoryBenchmarkTop10Mobile(_MemoryInfra): ...@@ -109,6 +112,9 @@ class MemoryBenchmarkTop10Mobile(_MemoryInfra):
# is able to cope with the data load generated by TBMv2 metrics. # is able to cope with the data load generated by TBMv2 metrics.
return not _IGNORED_STATS_RE.search(value.name) return not _IGNORED_STATS_RE.search(value.name)
def GetExpectations(self):
return page_sets.MemoryTop10MobileStoryExpectations()
@benchmark.Enabled('android') # catapult:#3176 @benchmark.Enabled('android') # catapult:#3176
@benchmark.Owner(emails=['bashi@chromium.org']) @benchmark.Owner(emails=['bashi@chromium.org'])
...@@ -142,6 +148,9 @@ class RendererMemoryBlinkMemoryMobile(_MemoryInfra): ...@@ -142,6 +148,9 @@ class RendererMemoryBlinkMemoryMobile(_MemoryInfra):
return (possible_browser.browser_type == 'reference' and return (possible_browser.browser_type == 'reference' and
possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X') possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
def GetExpectations(self):
return page_sets.BlinkMemoryMobileStoryExpectations()
class _MemoryV8Benchmark(_MemoryInfra): class _MemoryV8Benchmark(_MemoryInfra):
...@@ -193,6 +202,9 @@ class MemoryLongRunningIdleGmail(_MemoryV8Benchmark): ...@@ -193,6 +202,9 @@ class MemoryLongRunningIdleGmail(_MemoryV8Benchmark):
((possible_browser.browser_type == 'reference' and ((possible_browser.browser_type == 'reference' and
possible_browser.platform.GetDeviceTypeName() == 'Nexus 5'))) possible_browser.platform.GetDeviceTypeName() == 'Nexus 5')))
def GetExpectations(self):
return page_sets.LongRunningIdleGmailStoryExpectations()
@benchmark.Enabled('has tabs') # http://crbug.com/612210 @benchmark.Enabled('has tabs') # http://crbug.com/612210
@benchmark.Owner(emails=['ulan@chromium.org']) @benchmark.Owner(emails=['ulan@chromium.org'])
...@@ -208,3 +220,6 @@ class MemoryLongRunningIdleGmailBackground(_MemoryV8Benchmark): ...@@ -208,3 +220,6 @@ class MemoryLongRunningIdleGmailBackground(_MemoryV8Benchmark):
@classmethod @classmethod
def ShouldDisable(cls, possible_browser): # http://crbug.com/616530 def ShouldDisable(cls, possible_browser): # http://crbug.com/616530
return cls.IsSvelte(possible_browser) return cls.IsSvelte(possible_browser)
def GetExpectations(self):
return page_sets.LongRunningIdleGmailBackgroundStoryExpectations()
...@@ -34,6 +34,9 @@ class DualBrowserBenchmark(memory._MemoryInfra): ...@@ -34,6 +34,9 @@ class DualBrowserBenchmark(memory._MemoryInfra):
# is able to cope with the data load generated by TBMv2 metrics. # is able to cope with the data load generated by TBMv2 metrics.
return not memory._IGNORED_STATS_RE.search(value.name) return not memory._IGNORED_STATS_RE.search(value.name)
def GetExpectations(self):
return page_sets.DualBrowserStoryExpectations()
@benchmark.Owner(emails=['perezju@chromium.org']) @benchmark.Owner(emails=['perezju@chromium.org'])
class LongRunningDualBrowserBenchmark(memory._MemoryInfra): class LongRunningDualBrowserBenchmark(memory._MemoryInfra):
...@@ -63,6 +66,9 @@ class LongRunningDualBrowserBenchmark(memory._MemoryInfra): ...@@ -63,6 +66,9 @@ class LongRunningDualBrowserBenchmark(memory._MemoryInfra):
# is able to cope with the data load generated by TBMv2 metrics. # is able to cope with the data load generated by TBMv2 metrics.
return not memory._IGNORED_STATS_RE.search(value.name) return not memory._IGNORED_STATS_RE.search(value.name)
def GetExpectations(self):
return page_sets.DualBrowserStoryExpectations()
@benchmark.Owner(emails=['etienneb@chromium.org']) @benchmark.Owner(emails=['etienneb@chromium.org'])
class LongRunningMemoryBenchmarkSitesDesktop(memory._MemoryInfra): class LongRunningMemoryBenchmarkSitesDesktop(memory._MemoryInfra):
...@@ -90,8 +96,6 @@ class LongRunningMemoryBenchmarkSitesDesktop(memory._MemoryInfra): ...@@ -90,8 +96,6 @@ class LongRunningMemoryBenchmarkSitesDesktop(memory._MemoryInfra):
# Disable taking screenshot on failing pages. # Disable taking screenshot on failing pages.
options.take_screenshot_for_failed_page = False options.take_screenshot_for_failed_page = False
@classmethod @classmethod
def Name(cls): def Name(cls):
return 'memory.long_running_desktop_sites' return 'memory.long_running_desktop_sites'
...@@ -109,3 +113,6 @@ class LongRunningMemoryBenchmarkSitesDesktop(memory._MemoryInfra): ...@@ -109,3 +113,6 @@ class LongRunningMemoryBenchmarkSitesDesktop(memory._MemoryInfra):
# TODO(crbug.com/610962): Remove this stopgap when the perf dashboard # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
# is able to cope with the data load generated by TBMv2 metrics. # is able to cope with the data load generated by TBMv2 metrics.
return not memory._IGNORED_STATS_RE.search(value.name) return not memory._IGNORED_STATS_RE.search(value.name)
def GetExpectations(self):
return page_sets.DesktopMemoryStoryExpectations()
...@@ -132,3 +132,8 @@ class BlinkMemoryMobilePageSet(story.StorySet): ...@@ -132,3 +132,8 @@ class BlinkMemoryMobilePageSet(story.StorySet):
'https://plus.google.com/app/basic/110031535020051778989/posts?source=apppromo', 'https://plus.google.com/app/basic/110031535020051778989/posts?source=apppromo',
page_set=self, page_set=self,
name='GooglePlus')) name='GooglePlus'))
class BlinkMemoryMobileStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # No tests disabled.
...@@ -69,3 +69,7 @@ class DesktopMemoryPageSet(story.StorySet): ...@@ -69,3 +69,7 @@ class DesktopMemoryPageSet(story.StorySet):
for url in urls_list: for url in urls_list:
self.AddStory(DesktopMemoryPage(url, self)) self.AddStory(DesktopMemoryPage(url, self))
class DesktopMemoryStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # Not tests disabled.
...@@ -257,3 +257,8 @@ class DualBrowserStorySet(story_module.StorySet): ...@@ -257,3 +257,8 @@ class DualBrowserStorySet(story_module.StorySet):
url=url, url=url,
browser_type='default', browser_type='default',
phase='on_chrome')) phase='on_chrome'))
class DualBrowserStoryExpectations(story_module.expectations.StoryExpectations):
def SetExpectations(self):
pass # No tests disabled.
...@@ -40,6 +40,12 @@ class LongRunningIdleGmailPageSet(story.StorySet): ...@@ -40,6 +40,12 @@ class LongRunningIdleGmailPageSet(story.StorySet):
_CreateIdlePageClass(google_pages.GmailPage)(self)) _CreateIdlePageClass(google_pages.GmailPage)(self))
class LongRunningIdleGmailStoryExpectations(
story.expectations.StoryExpectations):
def SetExpectations(self):
pass # No disaled tests.
class LongRunningIdleGmailBackgroundPageSet(story.StorySet): class LongRunningIdleGmailBackgroundPageSet(story.StorySet):
def __init__(self): def __init__(self):
# Reuse the wpr of foreground gmail. # Reuse the wpr of foreground gmail.
...@@ -48,3 +54,9 @@ class LongRunningIdleGmailBackgroundPageSet(story.StorySet): ...@@ -48,3 +54,9 @@ class LongRunningIdleGmailBackgroundPageSet(story.StorySet):
cloud_storage_bucket=story.PARTNER_BUCKET) cloud_storage_bucket=story.PARTNER_BUCKET)
self.AddStory( self.AddStory(
_CreateIdleBackgroundPageClass(google_pages.GmailPage)(self)) _CreateIdleBackgroundPageClass(google_pages.GmailPage)(self))
class LongRunningIdleGmailBackgroundStoryExpectations(
story.expectations.StoryExpectations):
def SetExpectations(self):
pass # No disaled tests.
...@@ -77,3 +77,8 @@ class MemoryTop10Mobile(story.StorySet): ...@@ -77,3 +77,8 @@ class MemoryTop10Mobile(story.StorySet):
name = re.sub(r'\W+', '_', url) name = re.sub(r'\W+', '_', url)
self.AddStory(ForegroundPage(self, name, url)) self.AddStory(ForegroundPage(self, name, url))
self.AddStory(BackgroundPage(self, 'after_' + name)) self.AddStory(BackgroundPage(self, 'after_' + name))
class MemoryTop10MobileStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # No tests disabled.
...@@ -158,3 +158,9 @@ class TrivialSitesStorySet(story.StorySet): ...@@ -158,3 +158,9 @@ class TrivialSitesStorySet(story.StorySet):
class TrivialStoryExpectations(story.expectations.StoryExpectations): class TrivialStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self): def SetExpectations(self):
pass # No tests are disabled. pass # No tests are disabled.
class TrivialSitesMemoryStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # No tests are disabled.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment