Commit 7d4328f4 authored by dcheng's avatar dcheng Committed by Commit bot

Standardize usage of virtual/override/final specifiers.

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=derat@chromium.org

Review URL: https://codereview.chromium.org/685543003

Cr-Commit-Position: refs/heads/master@{#301523}
parent c71b15e5
...@@ -26,37 +26,35 @@ namespace ash { ...@@ -26,37 +26,35 @@ namespace ash {
class CursorWindowDelegate : public aura::WindowDelegate { class CursorWindowDelegate : public aura::WindowDelegate {
public: public:
CursorWindowDelegate() : is_cursor_compositing_enabled_(false) {} CursorWindowDelegate() : is_cursor_compositing_enabled_(false) {}
virtual ~CursorWindowDelegate() {} ~CursorWindowDelegate() override {}
// aura::WindowDelegate overrides: // aura::WindowDelegate overrides:
virtual gfx::Size GetMinimumSize() const override { return size_; } gfx::Size GetMinimumSize() const override { return size_; }
virtual gfx::Size GetMaximumSize() const override { return size_; } gfx::Size GetMaximumSize() const override { return size_; }
virtual void OnBoundsChanged(const gfx::Rect& old_bounds, void OnBoundsChanged(const gfx::Rect& old_bounds,
const gfx::Rect& new_bounds) override {} const gfx::Rect& new_bounds) override {}
virtual gfx::NativeCursor GetCursor(const gfx::Point& point) override { gfx::NativeCursor GetCursor(const gfx::Point& point) override {
return gfx::kNullCursor; return gfx::kNullCursor;
} }
virtual int GetNonClientComponent( int GetNonClientComponent(const gfx::Point& point) const override {
const gfx::Point& point) const override {
return HTNOWHERE; return HTNOWHERE;
} }
virtual bool ShouldDescendIntoChildForEventHandling( bool ShouldDescendIntoChildForEventHandling(
aura::Window* child, aura::Window* child,
const gfx::Point& location) override { const gfx::Point& location) override {
return false; return false;
} }
virtual bool CanFocus() override { return false; } bool CanFocus() override { return false; }
virtual void OnCaptureLost() override {} void OnCaptureLost() override {}
virtual void OnPaint(gfx::Canvas* canvas) override { void OnPaint(gfx::Canvas* canvas) override {
canvas->DrawImageInt(cursor_image_, 0, 0); canvas->DrawImageInt(cursor_image_, 0, 0);
} }
virtual void OnDeviceScaleFactorChanged( void OnDeviceScaleFactorChanged(float device_scale_factor) override {}
float device_scale_factor) override {} void OnWindowDestroying(aura::Window* window) override {}
virtual void OnWindowDestroying(aura::Window* window) override {} void OnWindowDestroyed(aura::Window* window) override {}
virtual void OnWindowDestroyed(aura::Window* window) override {} void OnWindowTargetVisibilityChanged(bool visible) override {}
virtual void OnWindowTargetVisibilityChanged(bool visible) override {} bool HasHitTestMask() const override { return false; }
virtual bool HasHitTestMask() const override { return false; } void GetHitTestMask(gfx::Path* mask) const override {}
virtual void GetHitTestMask(gfx::Path* mask) const override {}
// Sets cursor compositing mode on/off. // Sets cursor compositing mode on/off.
void SetCursorCompositingEnabled(bool enabled) { void SetCursorCompositingEnabled(bool enabled) {
......
...@@ -72,7 +72,7 @@ class ASH_EXPORT DisplayController : public gfx::DisplayObserver, ...@@ -72,7 +72,7 @@ class ASH_EXPORT DisplayController : public gfx::DisplayObserver,
}; };
DisplayController(); DisplayController();
virtual ~DisplayController(); ~DisplayController() override;
void Start(); void Start();
void Shutdown(); void Shutdown();
...@@ -144,20 +144,19 @@ class ASH_EXPORT DisplayController : public gfx::DisplayObserver, ...@@ -144,20 +144,19 @@ class ASH_EXPORT DisplayController : public gfx::DisplayObserver,
bool UpdateWorkAreaOfDisplayNearestWindow(const aura::Window* window, bool UpdateWorkAreaOfDisplayNearestWindow(const aura::Window* window,
const gfx::Insets& insets); const gfx::Insets& insets);
// gfx::DisplayObserver overrides: // gfx::DisplayObserver overrides:
virtual void OnDisplayAdded(const gfx::Display& display) override; void OnDisplayAdded(const gfx::Display& display) override;
virtual void OnDisplayRemoved(const gfx::Display& display) override; void OnDisplayRemoved(const gfx::Display& display) override;
virtual void OnDisplayMetricsChanged(const gfx::Display& display, void OnDisplayMetricsChanged(const gfx::Display& display,
uint32_t metrics) override; uint32_t metrics) override;
// aura::WindowTreeHostObserver overrides: // aura::WindowTreeHostObserver overrides:
virtual void OnHostResized(const aura::WindowTreeHost* host) override; void OnHostResized(const aura::WindowTreeHost* host) override;
// aura::DisplayManager::Delegate overrides: // aura::DisplayManager::Delegate overrides:
virtual void CreateOrUpdateNonDesktopDisplay(const DisplayInfo& info) void CreateOrUpdateNonDesktopDisplay(const DisplayInfo& info) override;
override; void CloseNonDesktopDisplay() override;
virtual void CloseNonDesktopDisplay() override; void PreDisplayConfigurationChange(bool clear_focus) override;
virtual void PreDisplayConfigurationChange(bool clear_focus) override; void PostDisplayConfigurationChange() override;
virtual void PostDisplayConfigurationChange() override;
private: private:
FRIEND_TEST_ALL_PREFIXES(DisplayControllerTest, BoundsUpdated); FRIEND_TEST_ALL_PREFIXES(DisplayControllerTest, BoundsUpdated);
......
...@@ -80,7 +80,7 @@ class TestObserver : public DisplayController::Observer, ...@@ -80,7 +80,7 @@ class TestObserver : public DisplayController::Observer,
AddObserver(this); AddObserver(this);
} }
virtual ~TestObserver() { ~TestObserver() override {
Shell::GetInstance()->display_controller()->RemoveObserver(this); Shell::GetInstance()->display_controller()->RemoveObserver(this);
Shell::GetScreen()->RemoveObserver(this); Shell::GetScreen()->RemoveObserver(this);
aura::client::GetFocusClient(Shell::GetPrimaryRootWindow())-> aura::client::GetFocusClient(Shell::GetPrimaryRootWindow())->
...@@ -90,16 +90,12 @@ class TestObserver : public DisplayController::Observer, ...@@ -90,16 +90,12 @@ class TestObserver : public DisplayController::Observer,
} }
// Overridden from DisplayController::Observer // Overridden from DisplayController::Observer
virtual void OnDisplayConfigurationChanging() override { void OnDisplayConfigurationChanging() override { ++changing_count_; }
++changing_count_; void OnDisplayConfigurationChanged() override { ++changed_count_; }
}
virtual void OnDisplayConfigurationChanged() override {
++changed_count_;
}
// Overrideen from gfx::DisplayObserver // Overrideen from gfx::DisplayObserver
virtual void OnDisplayMetricsChanged(const gfx::Display& display, void OnDisplayMetricsChanged(const gfx::Display& display,
uint32_t metrics) override { uint32_t metrics) override {
changed_display_id_ = display.id(); changed_display_id_ = display.id();
if (metrics & DISPLAY_METRIC_BOUNDS) if (metrics & DISPLAY_METRIC_BOUNDS)
++bounds_changed_count_; ++bounds_changed_count_;
...@@ -108,26 +104,22 @@ class TestObserver : public DisplayController::Observer, ...@@ -108,26 +104,22 @@ class TestObserver : public DisplayController::Observer,
if (metrics & DISPLAY_METRIC_WORK_AREA) if (metrics & DISPLAY_METRIC_WORK_AREA)
++workarea_changed_count_; ++workarea_changed_count_;
} }
virtual void OnDisplayAdded(const gfx::Display& new_display) override { void OnDisplayAdded(const gfx::Display& new_display) override {}
} void OnDisplayRemoved(const gfx::Display& old_display) override {}
virtual void OnDisplayRemoved(const gfx::Display& old_display) override {
}
// Overridden from aura::client::FocusChangeObserver // Overridden from aura::client::FocusChangeObserver
virtual void OnWindowFocused(aura::Window* gained_focus, void OnWindowFocused(aura::Window* gained_focus,
aura::Window* lost_focus) override { aura::Window* lost_focus) override {
focus_changed_count_++; focus_changed_count_++;
} }
// Overridden from aura::client::ActivationChangeObserver // Overridden from aura::client::ActivationChangeObserver
virtual void OnWindowActivated(aura::Window* gained_active, void OnWindowActivated(aura::Window* gained_active,
aura::Window* lost_active) override { aura::Window* lost_active) override {
activation_changed_count_++; activation_changed_count_++;
} }
virtual void OnAttemptToReactivateWindow( void OnAttemptToReactivateWindow(aura::Window* request_active,
aura::Window* request_active, aura::Window* actual_active) override {}
aura::Window* actual_active) override {
}
int CountAndReset() { int CountAndReset() {
EXPECT_EQ(changing_count_, changed_count_); EXPECT_EQ(changing_count_, changed_count_);
...@@ -204,9 +196,9 @@ void SetDefaultDisplayLayout(DisplayLayout::Position position) { ...@@ -204,9 +196,9 @@ void SetDefaultDisplayLayout(DisplayLayout::Position position) {
class DisplayControllerShutdownTest : public test::AshTestBase { class DisplayControllerShutdownTest : public test::AshTestBase {
public: public:
DisplayControllerShutdownTest() {} DisplayControllerShutdownTest() {}
virtual ~DisplayControllerShutdownTest() {} ~DisplayControllerShutdownTest() override {}
virtual void TearDown() override { void TearDown() override {
test::AshTestBase::TearDown(); test::AshTestBase::TearDown();
if (!SupportsMultipleDisplays()) if (!SupportsMultipleDisplays())
return; return;
...@@ -225,15 +217,15 @@ class StartupHelper : public test::TestShellDelegate, ...@@ -225,15 +217,15 @@ class StartupHelper : public test::TestShellDelegate,
public DisplayController::Observer { public DisplayController::Observer {
public: public:
StartupHelper() : displays_initialized_(false) {} StartupHelper() : displays_initialized_(false) {}
virtual ~StartupHelper() {} ~StartupHelper() override {}
// ash::ShellSelegate: // ash::ShellSelegate:
virtual void PreInit() override { void PreInit() override {
Shell::GetInstance()->display_controller()->AddObserver(this); Shell::GetInstance()->display_controller()->AddObserver(this);
} }
// ash::DisplayController::Observer: // ash::DisplayController::Observer:
virtual void OnDisplaysInitialized() override { void OnDisplaysInitialized() override {
DCHECK(!displays_initialized_); DCHECK(!displays_initialized_);
displays_initialized_ = true; displays_initialized_ = true;
} }
...@@ -251,14 +243,14 @@ class StartupHelper : public test::TestShellDelegate, ...@@ -251,14 +243,14 @@ class StartupHelper : public test::TestShellDelegate,
class DisplayControllerStartupTest : public test::AshTestBase { class DisplayControllerStartupTest : public test::AshTestBase {
public: public:
DisplayControllerStartupTest() : startup_helper_(new StartupHelper) {} DisplayControllerStartupTest() : startup_helper_(new StartupHelper) {}
virtual ~DisplayControllerStartupTest() {} ~DisplayControllerStartupTest() override {}
// ash::test::AshTestBase: // ash::test::AshTestBase:
virtual void SetUp() override { void SetUp() override {
ash_test_helper()->set_test_shell_delegate(startup_helper_); ash_test_helper()->set_test_shell_delegate(startup_helper_);
test::AshTestBase::SetUp(); test::AshTestBase::SetUp();
} }
virtual void TearDown() override { void TearDown() override {
Shell::GetInstance()->display_controller()->RemoveObserver(startup_helper_); Shell::GetInstance()->display_controller()->RemoveObserver(startup_helper_);
test::AshTestBase::TearDown(); test::AshTestBase::TearDown();
} }
...@@ -280,9 +272,9 @@ class TestEventHandler : public ui::EventHandler { ...@@ -280,9 +272,9 @@ class TestEventHandler : public ui::EventHandler {
scroll_y_offset_(0.0), scroll_y_offset_(0.0),
scroll_x_offset_ordinal_(0.0), scroll_x_offset_ordinal_(0.0),
scroll_y_offset_ordinal_(0.0) {} scroll_y_offset_ordinal_(0.0) {}
virtual ~TestEventHandler() {} ~TestEventHandler() override {}
virtual void OnMouseEvent(ui::MouseEvent* event) override { void OnMouseEvent(ui::MouseEvent* event) override {
if (event->flags() & ui::EF_IS_SYNTHESIZED && if (event->flags() & ui::EF_IS_SYNTHESIZED &&
event->type() != ui::ET_MOUSE_EXITED && event->type() != ui::ET_MOUSE_EXITED &&
event->type() != ui::ET_MOUSE_ENTERED) { event->type() != ui::ET_MOUSE_ENTERED) {
...@@ -294,7 +286,7 @@ class TestEventHandler : public ui::EventHandler { ...@@ -294,7 +286,7 @@ class TestEventHandler : public ui::EventHandler {
event->StopPropagation(); event->StopPropagation();
} }
virtual void OnTouchEvent(ui::TouchEvent* event) override { void OnTouchEvent(ui::TouchEvent* event) override {
aura::Window* target = static_cast<aura::Window*>(event->target()); aura::Window* target = static_cast<aura::Window*>(event->target());
// Only record when the target is the background which covers // Only record when the target is the background which covers
// entire root window. // entire root window.
...@@ -305,7 +297,7 @@ class TestEventHandler : public ui::EventHandler { ...@@ -305,7 +297,7 @@ class TestEventHandler : public ui::EventHandler {
event->StopPropagation(); event->StopPropagation();
} }
virtual void OnScrollEvent(ui::ScrollEvent* event) override { void OnScrollEvent(ui::ScrollEvent* event) override {
aura::Window* target = static_cast<aura::Window*>(event->target()); aura::Window* target = static_cast<aura::Window*>(event->target());
// Only record when the target is the background which covers // Only record when the target is the background which covers
// entire root window. // entire root window.
......
...@@ -50,14 +50,14 @@ class DisplayManagerTest : public test::AshTestBase, ...@@ -50,14 +50,14 @@ class DisplayManagerTest : public test::AshTestBase,
: removed_count_(0U), : removed_count_(0U),
root_window_destroyed_(false) { root_window_destroyed_(false) {
} }
virtual ~DisplayManagerTest() {} ~DisplayManagerTest() override {}
virtual void SetUp() override { void SetUp() override {
AshTestBase::SetUp(); AshTestBase::SetUp();
Shell::GetScreen()->AddObserver(this); Shell::GetScreen()->AddObserver(this);
Shell::GetPrimaryRootWindow()->AddObserver(this); Shell::GetPrimaryRootWindow()->AddObserver(this);
} }
virtual void TearDown() override { void TearDown() override {
Shell::GetPrimaryRootWindow()->RemoveObserver(this); Shell::GetPrimaryRootWindow()->RemoveObserver(this);
Shell::GetScreen()->RemoveObserver(this); Shell::GetScreen()->RemoveObserver(this);
AshTestBase::TearDown(); AshTestBase::TearDown();
...@@ -102,19 +102,18 @@ class DisplayManagerTest : public test::AshTestBase, ...@@ -102,19 +102,18 @@ class DisplayManagerTest : public test::AshTestBase,
} }
// aura::DisplayObserver overrides: // aura::DisplayObserver overrides:
virtual void OnDisplayMetricsChanged(const gfx::Display& display, void OnDisplayMetricsChanged(const gfx::Display& display, uint32_t) override {
uint32_t) override {
changed_.push_back(display); changed_.push_back(display);
} }
virtual void OnDisplayAdded(const gfx::Display& new_display) override { void OnDisplayAdded(const gfx::Display& new_display) override {
added_.push_back(new_display); added_.push_back(new_display);
} }
virtual void OnDisplayRemoved(const gfx::Display& old_display) override { void OnDisplayRemoved(const gfx::Display& old_display) override {
++removed_count_; ++removed_count_;
} }
// aura::WindowObserver overrides: // aura::WindowObserver overrides:
virtual void OnWindowDestroying(aura::Window* window) override { void OnWindowDestroying(aura::Window* window) override {
ASSERT_EQ(Shell::GetPrimaryRootWindow(), window); ASSERT_EQ(Shell::GetPrimaryRootWindow(), window);
root_window_destroyed_ = true; root_window_destroyed_ = true;
} }
...@@ -1182,17 +1181,17 @@ TEST_F(DisplayManagerTest, MAYBE_UpdateMouseCursorAfterRotateZoom) { ...@@ -1182,17 +1181,17 @@ TEST_F(DisplayManagerTest, MAYBE_UpdateMouseCursorAfterRotateZoom) {
class TestDisplayObserver : public gfx::DisplayObserver { class TestDisplayObserver : public gfx::DisplayObserver {
public: public:
TestDisplayObserver() : changed_(false) {} TestDisplayObserver() : changed_(false) {}
virtual ~TestDisplayObserver() {} ~TestDisplayObserver() override {}
// gfx::DisplayObserver overrides: // gfx::DisplayObserver overrides:
virtual void OnDisplayMetricsChanged(const gfx::Display&,uint32_t) override {} void OnDisplayMetricsChanged(const gfx::Display&, uint32_t) override {}
virtual void OnDisplayAdded(const gfx::Display& new_display) override { void OnDisplayAdded(const gfx::Display& new_display) override {
// Mirror window should already be delete before restoring // Mirror window should already be delete before restoring
// the external display. // the external display.
EXPECT_FALSE(test_api.GetHost()); EXPECT_FALSE(test_api.GetHost());
changed_ = true; changed_ = true;
} }
virtual void OnDisplayRemoved(const gfx::Display& old_display) override { void OnDisplayRemoved(const gfx::Display& old_display) override {
// Mirror window should not be created until the external display // Mirror window should not be created until the external display
// is removed. // is removed.
EXPECT_FALSE(test_api.GetHost()); EXPECT_FALSE(test_api.GetHost());
...@@ -1417,9 +1416,9 @@ class ScreenShutdownTest : public test::AshTestBase { ...@@ -1417,9 +1416,9 @@ class ScreenShutdownTest : public test::AshTestBase {
public: public:
ScreenShutdownTest() { ScreenShutdownTest() {
} }
virtual ~ScreenShutdownTest() {} ~ScreenShutdownTest() override {}
virtual void TearDown() override { void TearDown() override {
gfx::Screen* orig_screen = gfx::Screen* orig_screen =
gfx::Screen::GetScreenByType(gfx::SCREEN_TYPE_ALTERNATE); gfx::Screen::GetScreenByType(gfx::SCREEN_TYPE_ALTERNATE);
AshTestBase::TearDown(); AshTestBase::TearDown();
......
...@@ -23,14 +23,14 @@ class ASH_EXPORT EventTransformationHandler : public ui::EventHandler { ...@@ -23,14 +23,14 @@ class ASH_EXPORT EventTransformationHandler : public ui::EventHandler {
}; };
EventTransformationHandler(); EventTransformationHandler();
virtual ~EventTransformationHandler(); ~EventTransformationHandler() override;
void set_transformation_mode(TransformationMode transformation_mode) { void set_transformation_mode(TransformationMode transformation_mode) {
transformation_mode_ = transformation_mode; transformation_mode_ = transformation_mode;
} }
// Overridden from ui::EventHandler. // Overridden from ui::EventHandler.
virtual void OnScrollEvent(ui::ScrollEvent* event) override; void OnScrollEvent(ui::ScrollEvent* event) override;
private: private:
TransformationMode transformation_mode_; TransformationMode transformation_mode_;
......
...@@ -58,22 +58,18 @@ void DisableInput(XID window) { ...@@ -58,22 +58,18 @@ void DisableInput(XID window) {
class NoneCaptureClient : public aura::client::CaptureClient { class NoneCaptureClient : public aura::client::CaptureClient {
public: public:
NoneCaptureClient() {} NoneCaptureClient() {}
virtual ~NoneCaptureClient() {} ~NoneCaptureClient() override {}
private: private:
// Does a capture on the |window|. // Does a capture on the |window|.
virtual void SetCapture(aura::Window* window) override {} void SetCapture(aura::Window* window) override {}
// Releases a capture from the |window|. // Releases a capture from the |window|.
virtual void ReleaseCapture(aura::Window* window) override {} void ReleaseCapture(aura::Window* window) override {}
// Returns the current capture window. // Returns the current capture window.
virtual aura::Window* GetCaptureWindow() override { aura::Window* GetCaptureWindow() override { return NULL; }
return NULL; aura::Window* GetGlobalCaptureWindow() override { return NULL; }
}
virtual aura::Window* GetGlobalCaptureWindow() override {
return NULL;
}
DISALLOW_COPY_AND_ASSIGN(NoneCaptureClient); DISALLOW_COPY_AND_ASSIGN(NoneCaptureClient);
}; };
......
...@@ -36,7 +36,7 @@ class MirrorWindowTestApi; ...@@ -36,7 +36,7 @@ class MirrorWindowTestApi;
class ASH_EXPORT MirrorWindowController : public aura::WindowTreeHostObserver { class ASH_EXPORT MirrorWindowController : public aura::WindowTreeHostObserver {
public: public:
MirrorWindowController(); MirrorWindowController();
virtual ~MirrorWindowController(); ~MirrorWindowController() override;
// Updates the root window's bounds using |display_info|. // Updates the root window's bounds using |display_info|.
// Creates the new root window if one doesn't exist. // Creates the new root window if one doesn't exist.
...@@ -50,7 +50,7 @@ class ASH_EXPORT MirrorWindowController : public aura::WindowTreeHostObserver { ...@@ -50,7 +50,7 @@ class ASH_EXPORT MirrorWindowController : public aura::WindowTreeHostObserver {
void Close(); void Close();
// aura::WindowTreeHostObserver overrides: // aura::WindowTreeHostObserver overrides:
virtual void OnHostResized(const aura::WindowTreeHost* host) override; void OnHostResized(const aura::WindowTreeHost* host) override;
// Return the root window used to mirror the content. NULL if the // Return the root window used to mirror the content. NULL if the
// display is not mirrored by the compositor path. // display is not mirrored by the compositor path.
......
...@@ -31,18 +31,16 @@ DisplayInfo CreateDisplayInfo(int64 id, const gfx::Rect& bounds) { ...@@ -31,18 +31,16 @@ DisplayInfo CreateDisplayInfo(int64 id, const gfx::Rect& bounds) {
class MirrorOnBootTest : public test::AshTestBase { class MirrorOnBootTest : public test::AshTestBase {
public: public:
MirrorOnBootTest() {} MirrorOnBootTest() {}
virtual ~MirrorOnBootTest() {} ~MirrorOnBootTest() override {}
virtual void SetUp() override { void SetUp() override {
CommandLine::ForCurrentProcess()->AppendSwitchASCII( CommandLine::ForCurrentProcess()->AppendSwitchASCII(
switches::kAshHostWindowBounds, "1+1-300x300,1+301-300x300"); switches::kAshHostWindowBounds, "1+1-300x300,1+301-300x300");
CommandLine::ForCurrentProcess()->AppendSwitch( CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kAshEnableSoftwareMirroring); switches::kAshEnableSoftwareMirroring);
test::AshTestBase::SetUp(); test::AshTestBase::SetUp();
} }
virtual void TearDown() override { void TearDown() override { test::AshTestBase::TearDown(); }
test::AshTestBase::TearDown();
}
private: private:
DISALLOW_COPY_AND_ASSIGN(MirrorOnBootTest); DISALLOW_COPY_AND_ASSIGN(MirrorOnBootTest);
......
...@@ -35,7 +35,7 @@ class ASH_EXPORT MouseCursorEventFilter : public ui::EventHandler, ...@@ -35,7 +35,7 @@ class ASH_EXPORT MouseCursorEventFilter : public ui::EventHandler,
}; };
MouseCursorEventFilter(); MouseCursorEventFilter();
virtual ~MouseCursorEventFilter(); ~MouseCursorEventFilter() override;
void set_mouse_warp_mode(MouseWarpMode mouse_warp_mode) { void set_mouse_warp_mode(MouseWarpMode mouse_warp_mode) {
mouse_warp_mode_ = mouse_warp_mode; mouse_warp_mode_ = mouse_warp_mode;
...@@ -47,11 +47,11 @@ class ASH_EXPORT MouseCursorEventFilter : public ui::EventHandler, ...@@ -47,11 +47,11 @@ class ASH_EXPORT MouseCursorEventFilter : public ui::EventHandler,
void HideSharedEdgeIndicator(); void HideSharedEdgeIndicator();
// DisplayController::Observer: // DisplayController::Observer:
virtual void OnDisplaysInitialized() override; void OnDisplaysInitialized() override;
virtual void OnDisplayConfigurationChanged() override; void OnDisplayConfigurationChanged() override;
// ui::EventHandler: // ui::EventHandler:
virtual void OnMouseEvent(ui::MouseEvent* event) override; void OnMouseEvent(ui::MouseEvent* event) override;
private: private:
friend class DragWindowResizerTest; friend class DragWindowResizerTest;
......
...@@ -19,7 +19,7 @@ namespace ash { ...@@ -19,7 +19,7 @@ namespace ash {
class MouseCursorEventFilterTest : public test::AshTestBase { class MouseCursorEventFilterTest : public test::AshTestBase {
public: public:
MouseCursorEventFilterTest() {} MouseCursorEventFilterTest() {}
virtual ~MouseCursorEventFilterTest() {} ~MouseCursorEventFilterTest() override {}
protected: protected:
MouseCursorEventFilter* event_filter() { MouseCursorEventFilter* event_filter() {
......
...@@ -142,14 +142,11 @@ class AshRootWindowTransformer : public RootWindowTransformer { ...@@ -142,14 +142,11 @@ class AshRootWindowTransformer : public RootWindowTransformer {
} }
// aura::RootWindowTransformer overrides: // aura::RootWindowTransformer overrides:
virtual gfx::Transform GetTransform() const override { gfx::Transform GetTransform() const override { return transform_; }
return transform_; gfx::Transform GetInverseTransform() const override {
}
virtual gfx::Transform GetInverseTransform() const override {
return invert_transform_; return invert_transform_;
} }
virtual gfx::Rect GetRootWindowBounds( gfx::Rect GetRootWindowBounds(const gfx::Size& host_size) const override {
const gfx::Size& host_size) const override {
gfx::Rect bounds(host_size); gfx::Rect bounds(host_size);
bounds.Inset(host_insets_); bounds.Inset(host_insets_);
bounds = ui::ConvertRectToDIP(root_window_->layer(), bounds); bounds = ui::ConvertRectToDIP(root_window_->layer(), bounds);
...@@ -168,12 +165,10 @@ class AshRootWindowTransformer : public RootWindowTransformer { ...@@ -168,12 +165,10 @@ class AshRootWindowTransformer : public RootWindowTransformer {
return gfx::Rect(gfx::ToFlooredSize(new_bounds.size())); return gfx::Rect(gfx::ToFlooredSize(new_bounds.size()));
} }
virtual gfx::Insets GetHostInsets() const override { gfx::Insets GetHostInsets() const override { return host_insets_; }
return host_insets_;
}
private: private:
virtual ~AshRootWindowTransformer() {} ~AshRootWindowTransformer() override {}
aura::Window* root_window_; aura::Window* root_window_;
gfx::Transform transform_; gfx::Transform transform_;
...@@ -238,24 +233,19 @@ class MirrorRootWindowTransformer : public RootWindowTransformer { ...@@ -238,24 +233,19 @@ class MirrorRootWindowTransformer : public RootWindowTransformer {
} }
// aura::RootWindowTransformer overrides: // aura::RootWindowTransformer overrides:
virtual gfx::Transform GetTransform() const override { gfx::Transform GetTransform() const override { return transform_; }
return transform_; gfx::Transform GetInverseTransform() const override {
}
virtual gfx::Transform GetInverseTransform() const override {
gfx::Transform invert; gfx::Transform invert;
CHECK(transform_.GetInverse(&invert)); CHECK(transform_.GetInverse(&invert));
return invert; return invert;
} }
virtual gfx::Rect GetRootWindowBounds( gfx::Rect GetRootWindowBounds(const gfx::Size& host_size) const override {
const gfx::Size& host_size) const override {
return root_bounds_; return root_bounds_;
} }
virtual gfx::Insets GetHostInsets() const override { gfx::Insets GetHostInsets() const override { return insets_; }
return insets_;
}
private: private:
virtual ~MirrorRootWindowTransformer() {} ~MirrorRootWindowTransformer() override {}
gfx::Transform transform_; gfx::Transform transform_;
gfx::Rect root_bounds_; gfx::Rect root_bounds_;
......
...@@ -40,9 +40,9 @@ class TestEventHandler : public ui::EventHandler { ...@@ -40,9 +40,9 @@ class TestEventHandler : public ui::EventHandler {
scroll_y_offset_(0.0), scroll_y_offset_(0.0),
scroll_x_offset_ordinal_(0.0), scroll_x_offset_ordinal_(0.0),
scroll_y_offset_ordinal_(0.0) {} scroll_y_offset_ordinal_(0.0) {}
virtual ~TestEventHandler() {} ~TestEventHandler() override {}
virtual void OnMouseEvent(ui::MouseEvent* event) override { void OnMouseEvent(ui::MouseEvent* event) override {
if (event->flags() & ui::EF_IS_SYNTHESIZED) if (event->flags() & ui::EF_IS_SYNTHESIZED)
return; return;
aura::Window* target = static_cast<aura::Window*>(event->target()); aura::Window* target = static_cast<aura::Window*>(event->target());
...@@ -51,7 +51,7 @@ class TestEventHandler : public ui::EventHandler { ...@@ -51,7 +51,7 @@ class TestEventHandler : public ui::EventHandler {
event->StopPropagation(); event->StopPropagation();
} }
virtual void OnTouchEvent(ui::TouchEvent* event) override { void OnTouchEvent(ui::TouchEvent* event) override {
aura::Window* target = static_cast<aura::Window*>(event->target()); aura::Window* target = static_cast<aura::Window*>(event->target());
// Only record when the target is the background which covers // Only record when the target is the background which covers
// entire root window. // entire root window.
...@@ -62,7 +62,7 @@ class TestEventHandler : public ui::EventHandler { ...@@ -62,7 +62,7 @@ class TestEventHandler : public ui::EventHandler {
event->StopPropagation(); event->StopPropagation();
} }
virtual void OnScrollEvent(ui::ScrollEvent* event) override { void OnScrollEvent(ui::ScrollEvent* event) override {
aura::Window* target = static_cast<aura::Window*>(event->target()); aura::Window* target = static_cast<aura::Window*>(event->target());
// Only record when the target is the background which covers // Only record when the target is the background which covers
// entire root window. // entire root window.
......
...@@ -71,45 +71,32 @@ class ScreenForShutdown : public gfx::Screen { ...@@ -71,45 +71,32 @@ class ScreenForShutdown : public gfx::Screen {
} }
// gfx::Screen overrides: // gfx::Screen overrides:
virtual gfx::Point GetCursorScreenPoint() override { gfx::Point GetCursorScreenPoint() override { return gfx::Point(); }
return gfx::Point(); gfx::NativeWindow GetWindowUnderCursor() override { return NULL; }
} gfx::NativeWindow GetWindowAtScreenPoint(const gfx::Point& point) override {
virtual gfx::NativeWindow GetWindowUnderCursor() override {
return NULL;
}
virtual gfx::NativeWindow GetWindowAtScreenPoint(
const gfx::Point& point) override {
return NULL; return NULL;
} }
virtual int GetNumDisplays() const override { int GetNumDisplays() const override { return display_list_.size(); }
return display_list_.size(); std::vector<gfx::Display> GetAllDisplays() const override {
}
virtual std::vector<gfx::Display> GetAllDisplays() const override {
return display_list_; return display_list_;
} }
virtual gfx::Display GetDisplayNearestWindow(gfx::NativeView view) gfx::Display GetDisplayNearestWindow(gfx::NativeView view) const override {
const override {
return primary_display_; return primary_display_;
} }
virtual gfx::Display GetDisplayNearestPoint( gfx::Display GetDisplayNearestPoint(const gfx::Point& point) const override {
const gfx::Point& point) const override {
return FindDisplayNearestPoint(display_list_, point); return FindDisplayNearestPoint(display_list_, point);
} }
virtual gfx::Display GetDisplayMatching(const gfx::Rect& match_rect) gfx::Display GetDisplayMatching(const gfx::Rect& match_rect) const override {
const override {
const gfx::Display* matching = const gfx::Display* matching =
FindDisplayMatching(display_list_, match_rect); FindDisplayMatching(display_list_, match_rect);
// Fallback to the primary display if there is no matching display. // Fallback to the primary display if there is no matching display.
return matching ? *matching : GetPrimaryDisplay(); return matching ? *matching : GetPrimaryDisplay();
} }
virtual gfx::Display GetPrimaryDisplay() const override { gfx::Display GetPrimaryDisplay() const override { return primary_display_; }
return primary_display_; void AddObserver(gfx::DisplayObserver* observer) override {
}
virtual void AddObserver(gfx::DisplayObserver* observer) override {
NOTREACHED() << "Observer should not be added during shutdown"; NOTREACHED() << "Observer should not be added during shutdown";
} }
virtual void RemoveObserver(gfx::DisplayObserver* observer) override { void RemoveObserver(gfx::DisplayObserver* observer) override {}
}
private: private:
const std::vector<gfx::Display> display_list_; const std::vector<gfx::Display> display_list_;
......
...@@ -25,7 +25,7 @@ class DisplayManager; ...@@ -25,7 +25,7 @@ class DisplayManager;
class ASH_EXPORT ScreenAsh : public gfx::Screen { class ASH_EXPORT ScreenAsh : public gfx::Screen {
public: public:
ScreenAsh(); ScreenAsh();
virtual ~ScreenAsh(); ~ScreenAsh() override;
// Finds the display that contains |point| in screeen coordinates. // Finds the display that contains |point| in screeen coordinates.
// Returns invalid display if there is no display that can satisfy // Returns invalid display if there is no display that can satisfy
...@@ -61,21 +61,17 @@ class ASH_EXPORT ScreenAsh : public gfx::Screen { ...@@ -61,21 +61,17 @@ class ASH_EXPORT ScreenAsh : public gfx::Screen {
static const gfx::Display& GetDisplayForId(int64 display_id); static const gfx::Display& GetDisplayForId(int64 display_id);
// gfx::Screen overrides: // gfx::Screen overrides:
virtual gfx::Point GetCursorScreenPoint() override; gfx::Point GetCursorScreenPoint() override;
virtual gfx::NativeWindow GetWindowUnderCursor() override; gfx::NativeWindow GetWindowUnderCursor() override;
virtual gfx::NativeWindow GetWindowAtScreenPoint(const gfx::Point& point) gfx::NativeWindow GetWindowAtScreenPoint(const gfx::Point& point) override;
override; int GetNumDisplays() const override;
virtual int GetNumDisplays() const override; std::vector<gfx::Display> GetAllDisplays() const override;
virtual std::vector<gfx::Display> GetAllDisplays() const override; gfx::Display GetDisplayNearestWindow(gfx::NativeView view) const override;
virtual gfx::Display GetDisplayNearestWindow( gfx::Display GetDisplayNearestPoint(const gfx::Point& point) const override;
gfx::NativeView view) const override; gfx::Display GetDisplayMatching(const gfx::Rect& match_rect) const override;
virtual gfx::Display GetDisplayNearestPoint( gfx::Display GetPrimaryDisplay() const override;
const gfx::Point& point) const override; void AddObserver(gfx::DisplayObserver* observer) override;
virtual gfx::Display GetDisplayMatching( void RemoveObserver(gfx::DisplayObserver* observer) override;
const gfx::Rect& match_rect) const override;
virtual gfx::Display GetPrimaryDisplay() const override;
virtual void AddObserver(gfx::DisplayObserver* observer) override;
virtual void RemoveObserver(gfx::DisplayObserver* observer) override;
private: private:
friend class DisplayManager; friend class DisplayManager;
......
...@@ -13,18 +13,18 @@ namespace ash { ...@@ -13,18 +13,18 @@ namespace ash {
class ScreenPositionController : public aura::client::ScreenPositionClient { class ScreenPositionController : public aura::client::ScreenPositionClient {
public: public:
ScreenPositionController() {} ScreenPositionController() {}
virtual ~ScreenPositionController() {} ~ScreenPositionController() override {}
// aura::client::ScreenPositionClient overrides: // aura::client::ScreenPositionClient overrides:
virtual void ConvertPointToScreen(const aura::Window* window, void ConvertPointToScreen(const aura::Window* window,
gfx::Point* point) override; gfx::Point* point) override;
virtual void ConvertPointFromScreen(const aura::Window* window, void ConvertPointFromScreen(const aura::Window* window,
gfx::Point* point) override; gfx::Point* point) override;
virtual void ConvertHostPointToScreen(aura::Window* window, void ConvertHostPointToScreen(aura::Window* window,
gfx::Point* point) override; gfx::Point* point) override;
virtual void SetBounds(aura::Window* window, void SetBounds(aura::Window* window,
const gfx::Rect& bounds, const gfx::Rect& bounds,
const gfx::Display& display) override; const gfx::Display& display) override;
private: private:
DISALLOW_COPY_AND_ASSIGN(ScreenPositionController); DISALLOW_COPY_AND_ASSIGN(ScreenPositionController);
......
...@@ -49,9 +49,9 @@ ScreenPositionController* GetScreenPositionController() { ...@@ -49,9 +49,9 @@ ScreenPositionController* GetScreenPositionController() {
class ScreenPositionControllerTest : public test::AshTestBase { class ScreenPositionControllerTest : public test::AshTestBase {
public: public:
ScreenPositionControllerTest() {} ScreenPositionControllerTest() {}
virtual ~ScreenPositionControllerTest() {} ~ScreenPositionControllerTest() override {}
virtual void SetUp() override { void SetUp() override {
AshTestBase::SetUp(); AshTestBase::SetUp();
window_.reset(new aura::Window(&window_delegate_)); window_.reset(new aura::Window(&window_delegate_));
window_->SetType(ui::wm::WINDOW_TYPE_NORMAL); window_->SetType(ui::wm::WINDOW_TYPE_NORMAL);
...@@ -60,7 +60,7 @@ class ScreenPositionControllerTest : public test::AshTestBase { ...@@ -60,7 +60,7 @@ class ScreenPositionControllerTest : public test::AshTestBase {
window_->set_id(1); window_->set_id(1);
} }
virtual void TearDown() override { void TearDown() override {
window_.reset(); window_.reset();
AshTestBase::TearDown(); AshTestBase::TearDown();
} }
......
...@@ -26,8 +26,7 @@ class IndicatorView : public views::View { ...@@ -26,8 +26,7 @@ class IndicatorView : public views::View {
public: public:
IndicatorView() { IndicatorView() {
} }
virtual ~IndicatorView() { ~IndicatorView() override {}
}
void SetColor(SkColor color) { void SetColor(SkColor color) {
color_ = color; color_ = color;
...@@ -35,7 +34,7 @@ class IndicatorView : public views::View { ...@@ -35,7 +34,7 @@ class IndicatorView : public views::View {
} }
// views::Views overrides: // views::Views overrides:
virtual void OnPaint(gfx::Canvas* canvas) override { void OnPaint(gfx::Canvas* canvas) override {
canvas->FillRect(gfx::Rect(bounds().size()), color_); canvas->FillRect(gfx::Rect(bounds().size()), color_);
} }
......
...@@ -28,7 +28,7 @@ namespace ash { ...@@ -28,7 +28,7 @@ namespace ash {
class ASH_EXPORT SharedDisplayEdgeIndicator : public gfx::AnimationDelegate { class ASH_EXPORT SharedDisplayEdgeIndicator : public gfx::AnimationDelegate {
public: public:
SharedDisplayEdgeIndicator(); SharedDisplayEdgeIndicator();
virtual ~SharedDisplayEdgeIndicator(); ~SharedDisplayEdgeIndicator() override;
// Shows/Hides the indicator window. The |src_bounds| is for the window on // Shows/Hides the indicator window. The |src_bounds| is for the window on
// the source display, and the |dst_bounds| is for the window on the other // the source display, and the |dst_bounds| is for the window on the other
...@@ -37,7 +37,7 @@ class ASH_EXPORT SharedDisplayEdgeIndicator : public gfx::AnimationDelegate { ...@@ -37,7 +37,7 @@ class ASH_EXPORT SharedDisplayEdgeIndicator : public gfx::AnimationDelegate {
void Hide(); void Hide();
// gfx::AnimationDelegate overrides: // gfx::AnimationDelegate overrides:
virtual void AnimationProgressed(const gfx::Animation* animation) override; void AnimationProgressed(const gfx::Animation* animation) override;
private: private:
// Used to show the displays' shared edge where a window can be moved across. // Used to show the displays' shared edge where a window can be moved across.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment