Mac PKG: Make sure files show up in the Installer.

Work around an Installer.app bug.

Bug: 1022413
Change-Id: I4eab147d15bcae44f1d0fc6a4e4da9ac78a34772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904688
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713891}

chrome/installer/mac/signing/pipeline.py

@@ -163,10 +163,15 @@ def _package_and_sign_pkg(paths, dist_config):
     #   2. The outer product archive (which is the installable thing that has
     #      pre-install requirements). This is built with `productbuild`.
 
-    # The component package.
-
-    component_pkg_path = os.path.join(paths.work,
-                                      '{}.pkg'.format(dist_config.app_product))
+    ## The component package.
+
+    # The spaces are removed from |dist_config.app_product| for the component
+    # package path due to a bug in Installer.app that causes the "Show Files"
+    # window to be blank if there is a space in a component package name.
+    # https://stackoverflow.com/questions/43031272/
+    component_pkg_name = '{}.pkg'.format(dist_config.app_product).replace(
+        ' ', '')
+    component_pkg_path = os.path.join(paths.work, component_pkg_name)
     app_path = os.path.join(paths.work, dist_config.app_dir)
 
     commands.run_command([
@@ -175,7 +180,7 @@ def _package_and_sign_pkg(paths, dist_config):
         '/Applications', component_pkg_path
     ])
 
-    # The product archive.
+    ## The product archive.
 
     # There are two steps here. The first is to create the "distribution file"
     # which describes the product archive. `productbuild` has a mode to generate

chrome/installer/mac/signing/pipeline_test.py

@@ -314,7 +314,7 @@ class TestPipelineHelpers(unittest.TestCase):
             '$W/App Product.req',
             _get_adjacent_item(productbuild_synthesize_args, '--product'))
         self.assertEqual(
-            '$W/App Product.pkg',
+            '$W/AppProduct.pkg',
             _get_adjacent_item(productbuild_synthesize_args, '--package'))
 
         self.assertEqual(
@@ -401,7 +401,7 @@ class TestPipelineHelpers(unittest.TestCase):
             '$W/App Product.req',
             _get_adjacent_item(productbuild_synthesize_args, '--product'))
         self.assertEqual(
-            '$W/App Product.pkg',
+            '$W/AppProduct.pkg',
             _get_adjacent_item(productbuild_synthesize_args, '--package'))
 
         self.assertEqual(