[v8][wasm] Fix WebAssembly streaming tests
This CL fixes a test that is checking the wrong behavior at the moment, and disables the test until the fix in V8 lands. Background: The idea of the test is to create an invalid WebAssembly module, and then check that the module is rejected by streaming compilation. The invalid module was created by taking an empty module and adding two '0' bytes at the end. However, two '0' bytes represent an empty unknown section, which was originally accected by the streaming decoder. The test, however, misinterpreted the test result (i.e. "FAIL Invalid code: compileStreaming assert_unreached: Should have rejected: undefined Reached unreachable decoder" a.k.a. FAIL, streaming compilation succeeded unexpectedly) as the error message of the streaming compiler, and then marked it in the test expectations as the expected behavior. The CL changed the test now to add bytes that clearly create an invalid module, and also deleted the invalid test expectations. R=leszeks@chromium.org Bug: v8:10126 Change-Id: Ie49a7a890abd841a85dc9f634308762ea07e5928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066907Reviewed-by:Leszek Swirski <leszeks@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#743908}
Showing
Please register or sign in to comment