Make ChromeVox hint an oobe-modal-dialog instead of a cr-dialog.

Make the ChromeVox hint dialog an oobe-modal-dialog in accordance with
the following change: http://crrev.com/c/2563481. This ensures that the
shelf buttons cannot be acted on while the dialog is open.

Bug: N/A
Change-Id: Ie08bfc44fdc6eb73e803c2ec10449cc461e455c2
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577545
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834286}

chrome/browser/chromeos/login/screens/welcome_screen_browsertest.cc

@@ -519,15 +519,15 @@ class WelcomeScreenChromeVoxHintTest : public WelcomeScreenBrowserTest {
 
   void WaitForChromeVoxHintDialogToOpen() {
     test::OobeJS()
-        .CreateAttributePresenceWaiter("open", true /*present*/,
-                                       kChromeVoxHintDialog)
+        .CreateWaiter(test::GetOobeElementPath({kChromeVoxHintDialog}) +
+                      ".open")
         ->Wait();
   }
 
   void WaitForChromeVoxHintDialogToClose() {
     test::OobeJS()
-        .CreateAttributePresenceWaiter("open", false /*present*/,
-                                       kChromeVoxHintDialog)
+        .CreateWaiter(test::GetOobeElementPath({kChromeVoxHintDialog}) +
+                      ".open === false")
         ->Wait();
   }
 

chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html

@@ -5,7 +5,6 @@
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html">
 <link rel="import" href="chrome://resources/html/action_link.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
-<link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
 
 <link rel="import" href="/components/oobe_i18n_behavior.html">
@@ -154,11 +153,11 @@
         </oobe-text-button>
       </div>
     </oobe-dialog>
-    <cr-dialog id="chromeVoxHint">
-      <div class="title" slot="title">
+    <oobe-modal-dialog id="chromeVoxHint">
+      <div slot="title">
         <p>[[i18nDynamic(locale, 'chromeVoxHintText')]]</p>
       </div>
-      <div class="button-container" slot="button-container">
+      <div slot="buttons">
         <oobe-text-button id="dismissChromeVoxButton"
             on-click="dismissChromeVoxHint_"
             text-key="continueWithoutChromeVox">
@@ -167,6 +166,6 @@
             on-click="activateChromeVox_" text-key="activateChromeVox">
         </oobe-text-button>
       </div>
-    </cr-dialog>
+    </oobe-modal-dialog>
   </template>
 </dom-module>

chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js

@@ -453,14 +453,14 @@
      * Called to show the ChromeVox hint dialog.
      */
     showChromeVoxHint() {
-      this.$.chromeVoxHint.showModal();
+      this.$.chromeVoxHint.showDialog();
     },
 
     /**
      * Called to close the ChromeVox hint dialog.
      */
     closeChromeVoxHint() {
-      this.$.chromeVoxHint.close();
+      this.$.chromeVoxHint.hideDialog();
     },
 
     /**