Commit 7d67cae3 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Disable flaky ContextMenuJsFindElementAtPointTest tests.

Bug: 1046580
TBR: michaeldo@chromium.org
Change-Id: Id8424c65cf9f0827ddee02d59dce656184ebcb38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026371Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736149}
parent 83dc2c4b
...@@ -239,7 +239,8 @@ class ContextMenuJsFindElementAtPointTest : public web::WebTest { ...@@ -239,7 +239,8 @@ class ContextMenuJsFindElementAtPointTest : public web::WebTest {
#pragma mark - Image without link #pragma mark - Image without link
// Tests that the correct src and referrer are found for an image. // Tests that the correct src and referrer are found for an image.
TEST_F(ContextMenuJsFindElementAtPointTest, FindImageElementAtPoint) { // TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest, FLAKY_FindImageElementAtPoint) {
NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForImage()); NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForImage());
ASSERT_TRUE(web::test::LoadHtml(web_view_, html, GetTestURL())); ASSERT_TRUE(web::test::LoadHtml(web_view_, html, GetTestURL()));
...@@ -254,7 +255,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, FindImageElementAtPoint) { ...@@ -254,7 +255,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, FindImageElementAtPoint) {
} }
// Tests that the correct title is found for an image. // Tests that the correct title is found for an image.
TEST_F(ContextMenuJsFindElementAtPointTest, FindImageElementWithTitleAtPoint) { // TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest,
FLAKY_FindImageElementWithTitleAtPoint) {
NSString* const image_title = @"Hello world!"; NSString* const image_title = @"Hello world!";
NSString* html = GetHtmlForPage( NSString* html = GetHtmlForPage(
/*head=*/nil, GetHtmlForImage(kImageSource, image_title, /*style=*/nil)); /*head=*/nil, GetHtmlForImage(kImageSource, image_title, /*style=*/nil));
...@@ -273,8 +276,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, FindImageElementWithTitleAtPoint) { ...@@ -273,8 +276,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, FindImageElementWithTitleAtPoint) {
// Tests that image details are not returned for a point outside of the document // Tests that image details are not returned for a point outside of the document
// margins. // margins.
// TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest, TEST_F(ContextMenuJsFindElementAtPointTest,
FindImageElementAtPointOutsideDocument) { FLAKY_FindImageElementAtPointOutsideDocument) {
NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForImage()); NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForImage());
ASSERT_TRUE(web::test::LoadHtml(web_view_, html, GetTestURL())); ASSERT_TRUE(web::test::LoadHtml(web_view_, html, GetTestURL()));
...@@ -286,8 +290,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, ...@@ -286,8 +290,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest,
} }
// Tests that image details are not returned for a point outside of the element. // Tests that image details are not returned for a point outside of the element.
// TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest, TEST_F(ContextMenuJsFindElementAtPointTest,
FindImageElementAtPointOutsideElement) { FLAKY_FindImageElementAtPointOutsideElement) {
NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForImage()); NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForImage());
ASSERT_TRUE(web::test::LoadHtml(web_view_, html, GetTestURL())); ASSERT_TRUE(web::test::LoadHtml(web_view_, html, GetTestURL()));
...@@ -302,7 +307,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, ...@@ -302,7 +307,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest,
// Tests that an image link returns details for both the image and the link // Tests that an image link returns details for both the image and the link
// destination when the image source is a file:// url. // destination when the image source is a file:// url.
TEST_F(ContextMenuJsFindElementAtPointTest, FindLinkImageAtPointForFileUrl) { // TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest,
FLAKY_FindLinkImageAtPointForFileUrl) {
NSString* const image_link = @"file:///linky"; NSString* const image_link = @"file:///linky";
NSString* html = GetHtmlForPage( NSString* html = GetHtmlForPage(
/*head=*/nil, GetHtmlForLink(image_link, GetHtmlForImage())); /*head=*/nil, GetHtmlForLink(image_link, GetHtmlForImage()));
...@@ -320,8 +327,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, FindLinkImageAtPointForFileUrl) { ...@@ -320,8 +327,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, FindLinkImageAtPointForFileUrl) {
// Tests that an image link does not return image and link details for a point // Tests that an image link does not return image and link details for a point
// outside the document. // outside the document.
// TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest, TEST_F(ContextMenuJsFindElementAtPointTest,
FindLinkImageAtPointOutsideDocument) { FLAKY_FindLinkImageAtPointOutsideDocument) {
NSString* const image_link = @"file:///linky"; NSString* const image_link = @"file:///linky";
NSString* html = GetHtmlForPage( NSString* html = GetHtmlForPage(
/*head=*/nil, GetHtmlForLink(image_link, GetHtmlForImage())); /*head=*/nil, GetHtmlForLink(image_link, GetHtmlForImage()));
...@@ -336,8 +344,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, ...@@ -336,8 +344,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest,
// Tests that an image link does not return image and link details for a point // Tests that an image link does not return image and link details for a point
// outside the element. // outside the element.
// TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest, TEST_F(ContextMenuJsFindElementAtPointTest,
FindLinkImageAtPointOutsideElement) { FLAKY_FindLinkImageAtPointOutsideElement) {
NSString* const image_link = @"file:///linky"; NSString* const image_link = @"file:///linky";
NSString* html = GetHtmlForPage( NSString* html = GetHtmlForPage(
/*head=*/nil, GetHtmlForLink(image_link, GetHtmlForImage())); /*head=*/nil, GetHtmlForLink(image_link, GetHtmlForImage()));
...@@ -461,7 +470,8 @@ TEST_F(ContextMenuJsFindElementAtPointTest, ...@@ -461,7 +470,8 @@ TEST_F(ContextMenuJsFindElementAtPointTest,
// Tests that only the parent link details are returned for an image with // Tests that only the parent link details are returned for an image with
// "-webkit-touch-callout:none" style and a parent link. // "-webkit-touch-callout:none" style and a parent link.
TEST_F(ContextMenuJsFindElementAtPointTest, LinkOfImageWithCalloutNone) { // TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest, FLAKY_LinkOfImageWithCalloutNone) {
NSString* const image_link = @"http://destination/"; NSString* const image_link = @"http://destination/";
NSString* image_html = GetHtmlForImage(kImageSource, /*title=*/nil, NSString* image_html = GetHtmlForImage(kImageSource, /*title=*/nil,
@"-webkit-touch-callout:none;"); @"-webkit-touch-callout:none;");
...@@ -498,7 +508,8 @@ TEST_F(ContextMenuJsFindElementAtPointTest, FindSvgLinkAtPoint) { ...@@ -498,7 +508,8 @@ TEST_F(ContextMenuJsFindElementAtPointTest, FindSvgLinkAtPoint) {
} }
// Tests that an SVG shape xlink returns details for the link. // Tests that an SVG shape xlink returns details for the link.
TEST_F(ContextMenuJsFindElementAtPointTest, FindSvgXlinkAtPoint) { // TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest, FLAKY_FindSvgXlinkAtPoint) {
NSString* const link = @"file:///linky"; NSString* const link = @"file:///linky";
NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForSvgXlink(link)); NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForSvgXlink(link));
ASSERT_TRUE(web::test::LoadHtml(web_view_, html, GetTestURL())); ASSERT_TRUE(web::test::LoadHtml(web_view_, html, GetTestURL()));
...@@ -552,7 +563,8 @@ TEST_F(ContextMenuJsFindElementAtPointTest, TextAreaStopsProximity) { ...@@ -552,7 +563,8 @@ TEST_F(ContextMenuJsFindElementAtPointTest, TextAreaStopsProximity) {
// Tests that __gCrWeb.findElementAtPoint reports "never" as the referrer // Tests that __gCrWeb.findElementAtPoint reports "never" as the referrer
// policy for pages that have an unsupported policy in a meta tag. // policy for pages that have an unsupported policy in a meta tag.
TEST_F(ContextMenuJsFindElementAtPointTest, UnsupportedReferrerPolicy) { // TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest, FLAKY_UnsupportedReferrerPolicy) {
// A page with an unsupported referrer meta tag and an image. // A page with an unsupported referrer meta tag and an image.
NSString* const head = NSString* const head =
@"<meta name=\"referrer\" content=\"unsupported-value\">"; @"<meta name=\"referrer\" content=\"unsupported-value\">";
...@@ -636,7 +648,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, PointOutsideShadowDomLink) { ...@@ -636,7 +648,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, PointOutsideShadowDomLink) {
// Tests that a callout information about a link is displayed when // Tests that a callout information about a link is displayed when
// -webkit-touch-callout property is not specified. Please see: // -webkit-touch-callout property is not specified. Please see:
// https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout // https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout
TEST_F(ContextMenuJsFindElementAtPointTest, LinkOfTextWithoutCalloutProperty) { // TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest,
FLAKY_LinkOfTextWithoutCalloutProperty) {
NSString* const link = @"http://destination/"; NSString* const link = @"http://destination/";
NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForLink(link, @"link")); NSString* html = GetHtmlForPage(/*head=*/nil, GetHtmlForLink(link, @"link"));
...@@ -655,7 +669,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, LinkOfTextWithoutCalloutProperty) { ...@@ -655,7 +669,9 @@ TEST_F(ContextMenuJsFindElementAtPointTest, LinkOfTextWithoutCalloutProperty) {
// Tests that a callout information about a link is displayed when // Tests that a callout information about a link is displayed when
// -webkit-touch-callout property is set to default. Please see: // -webkit-touch-callout property is set to default. Please see:
// https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout // https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout
TEST_F(ContextMenuJsFindElementAtPointTest, LinkOfTextWithCalloutDefault) { // TODO(crbug.com/1046580): this test is flaky.
TEST_F(ContextMenuJsFindElementAtPointTest,
FLAKY_LinkOfTextWithCalloutDefault) {
NSString* const link = @"http://destination/"; NSString* const link = @"http://destination/";
NSString* const link_style = @"-webkit-touch-callout:default;"; NSString* const link_style = @"-webkit-touch-callout:default;";
NSString* html = NSString* html =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment