Commit 7d6e3b39 authored by Changwan Ryu's avatar Changwan Ryu Committed by Commit Bot

Stop running AwStrictModeTest when jacoco is enabled

jacoco (Java code coverage tool) requires turning off strict mode
since it writes the coverage data to files.

AwStrictModeTest enables strict mode and therefore it currently
causes strict mode violation (in a flaky way).

Unfortunately, we are disabling this in one of the main tryservers
(android-marshmallow-arm64-rel) which enables jacoco, but
android-pie-arm64-rel in CQ and 5 other bots run this
continuously, and such violations will be locally reproducible.

        test can be run, check tryserver result

Bug: 1021403, 1045270
Tested: change use_jacoco_coverage value in build gn and see if
Change-Id: I95b41f82906f6d7f0ec32a353203928f831079a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029327Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736988}
parent f6634222
......@@ -234,7 +234,6 @@ instrumentation_test_apk("webview_instrumentation_test_apk") {
"../javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java",
"../javatests/src/org/chromium/android_webview/test/AwServiceWorkerClientTest.java",
"../javatests/src/org/chromium/android_webview/test/AwSettingsTest.java",
"../javatests/src/org/chromium/android_webview/test/AwStrictModeTest.java",
"../javatests/src/org/chromium/android_webview/test/AwUncaughtExceptionTest.java",
"../javatests/src/org/chromium/android_webview/test/AwVariationsSeedFetcherTest.java",
"../javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java",
......@@ -308,6 +307,11 @@ instrumentation_test_apk("webview_instrumentation_test_apk") {
"../javatests/src/org/chromium/android_webview/test/util/VideoTestUtil.java",
"../javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java",
]
if (!use_jacoco_coverage) {
# Jacoco requires strict mode to be turned off since it writes coverage data to files.
sources += [ "../javatests/src/org/chromium/android_webview/test/AwStrictModeTest.java" ]
}
data = [ "data/" ]
data_deps =
[ "//testing/buildbot/filters:webview_instrumentation_test_apk_filters" ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment