Commit 7da4ea6d authored by agrieve's avatar agrieve Committed by Commit Bot

Revert "Reactivate deflaked keyboard accessory tests"

This reverts commit dc92f9db.

Reason for revert: Tests consistently fail on 
https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Tablet%20Tester/12646

Original change's description:
> Reactivate deflaked keyboard accessory tests
> 
> After having landed https://crrev.com/c/1028230, the problems of the
> linked bug seem to have gone (as assumed).
> 
> I removed the Disabling and RetryOnFailure annotations to test on 3
> devices (one physical, two emulator with different screen sizes and OS)
> and couldn't find a single broken test.
> Edit: I changed the font size recently (not finally) which seems to
> bother some bots - unrelated from the filed bug. Changed that back.
> 
> This CL now reenables all the tests but keeps the RetryOnFailure
> annotation. That way, I can test whether the tests start failing on
> some bots again without making the sheriffs life harder.
> If the bots don't notice any flakiness, I will remove the
> RetryOnFailure annotation as well and mark the linked bug fixed.
> 
> Bug: 838922
> Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4
> Reviewed-on: https://chromium-review.googlesource.com/1044371
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556798}

TBR=bauerb@chromium.org,fhorschig@chromium.org

Change-Id: I60198d2fbcd36c4687b379d07995e1b873112d51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838922
Reviewed-on: https://chromium-review.googlesource.com/1051026Reviewed-by: default avataragrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557048}
parent 9aca9b6f
......@@ -128,7 +128,7 @@
<dimen name="keyboard_accessory_height">36dp</dimen>
<dimen name="keyboard_accessory_padding">4dp</dimen>
<dimen name="keyboard_accessory_sheet_height">200dp</dimen>
<dimen name="keyboard_accessory_text_size">10sp</dimen>
<dimen name="keyboard_accessory_text_size">6sp</dimen>
<!-- Password generation popup dimensions -->
<dimen name="password_generation_divider_height">1dp</dimen>
......
......@@ -26,6 +26,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.MinAndroidSdkLevel;
import org.chromium.base.test.util.RetryOnFailure;
......@@ -126,6 +127,7 @@ public class AutofillKeyboardAccessoryIntegrationTest {
@Test
@MediumTest
@Feature({"keyboard-accessory"})
@DisabledTest(message = "crbug.com/838922")
public void testTapInputFieldShowsKeyboardAccessory()
throws ExecutionException, InterruptedException, TimeoutException {
loadTestPage(false);
......@@ -144,6 +146,7 @@ public class AutofillKeyboardAccessoryIntegrationTest {
@Test
@MediumTest
@Feature({"keyboard-accessory"})
@DisabledTest(message = "crbug.com/836027")
public void testSwitchFieldsRescrollsKeyboardAccessory()
throws ExecutionException, InterruptedException, TimeoutException {
loadTestPage(false);
......@@ -173,6 +176,7 @@ public class AutofillKeyboardAccessoryIntegrationTest {
@MediumTest
@Feature({"keyboard-accessory"})
@MinAndroidSdkLevel(Build.VERSION_CODES.JELLY_BEAN_MR1)
@DisabledTest(message = "crbug.com/836027")
public void testSwitchFieldsRescrollsKeyboardAccessoryRtl()
throws ExecutionException, InterruptedException, TimeoutException {
loadTestPage(true);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment